Received: by 2002:a05:6358:bb9e:b0:b9:5105:a5b4 with SMTP id df30csp3001187rwb; Mon, 5 Sep 2022 05:07:14 -0700 (PDT) X-Google-Smtp-Source: AA6agR7zdK+Lmz1/79S377EpKqm8GzNlWhNTEJjtQ2NUVEf3i3YjiJAEtKUfQBi1W25hDYXwsKW1 X-Received: by 2002:a63:8bc9:0:b0:42b:2375:79b3 with SMTP id j192-20020a638bc9000000b0042b237579b3mr40583694pge.207.1662379633923; Mon, 05 Sep 2022 05:07:13 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1662379633; cv=none; d=google.com; s=arc-20160816; b=CiV+UP7ETIG1iniD4jvEK1xQrUrUX39mjrcniaUn/zjL2VjMzQQ05R2uxLCEPA/NPa 0hHb7H3jh56ucUjKE8EbJIbkpPnyGrjtHrUdVbAQ5dwov5w7981j4t2Dfp+/sxVq+qHB XaH+BBm1figM/KicJvNNWlcyYDHS9qMZd31Vlu3qMaAhAbIYHaTMwposvgYcvlKYafPP iazo019h+OWfbX59fZrBUn1DQgOKNyoLXau+/vn/G4umPiUroBoiqT1B5zvcXdio+nei ZVT8eZfAZeovAsMIV7iVBwuLo1Jk2cWp8alJUYKQ5gmOxBUSWP4vBmOURV4PxfLkPCZP 5Oaw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:references:in-reply-to:message-id :date:subject:cc:to:from; bh=1sPr9qIsu64yNXyH0LE6b0OMEzr0KMJEhsIeC2PnHAo=; b=myNyPqxDB5Ur1rGw2sLhU5pLt73kAmAV44aRZGB79p8nFHAehr4KM4lPTej6wTqAWl 8cwlOZH8esJdI3J/eZdWQdglkCxbrsFcJrDdE7Qf5ZhZhPR3X7Nkf3ZMfSocSRAndHs2 Lg7j29CebA4Mz0VzbB7eJjvhheU8wri/xjfZ6AnG+7iLo53Bwl9QVq/HTr8IlM6RDRCF JU5pGdNf9ACpcEJ1TwWCLmxiAPdEDIb2biPsPhaFKhBGfgRZaaaIVvY0MzmJVBUDPCIY SVPsbinuaQghqYFC5gBLoYgUjSeGWugP+L+eh7fvBJqQqmjdQocwtzon9+jaTofN05ah 4aMw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=huawei.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id p10-20020a170902ebca00b00174a5cd31fdsi5711744plg.346.2022.09.05.05.06.49; Mon, 05 Sep 2022 05:07:13 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=huawei.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237925AbiIELzj (ORCPT + 99 others); Mon, 5 Sep 2022 07:55:39 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47236 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S238158AbiIELzb (ORCPT ); Mon, 5 Sep 2022 07:55:31 -0400 Received: from frasgout.his.huawei.com (frasgout.his.huawei.com [185.176.79.56]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 444F02C13E; Mon, 5 Sep 2022 04:55:27 -0700 (PDT) Received: from fraeml713-chm.china.huawei.com (unknown [172.18.147.200]) by frasgout.his.huawei.com (SkyGuard) with ESMTP id 4MLn0t6W8gz688G2; Mon, 5 Sep 2022 19:51:26 +0800 (CST) Received: from lhrpeml500003.china.huawei.com (7.191.162.67) by fraeml713-chm.china.huawei.com (10.206.15.32) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Mon, 5 Sep 2022 13:55:25 +0200 Received: from localhost.localdomain (10.69.192.58) by lhrpeml500003.china.huawei.com (7.191.162.67) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Mon, 5 Sep 2022 12:55:23 +0100 From: John Garry To: , CC: , , , John Garry Subject: [PATCH 2/5] scsi: hisi_sas: Clear HISI_SAS_HW_FAULT_BIT earlier Date: Mon, 5 Sep 2022 19:48:46 +0800 Message-ID: <1662378529-101489-3-git-send-email-john.garry@huawei.com> X-Mailer: git-send-email 2.8.1 In-Reply-To: <1662378529-101489-1-git-send-email-john.garry@huawei.com> References: <1662378529-101489-1-git-send-email-john.garry@huawei.com> MIME-Version: 1.0 Content-Type: text/plain X-Originating-IP: [10.69.192.58] X-ClientProxiedBy: dggems705-chm.china.huawei.com (10.3.19.182) To lhrpeml500003.china.huawei.com (7.191.162.67) X-CFilter-Loop: Reflected X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_MED, RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Once the controller HW has been reset then we can unset flag HISI_SAS_HW_FAULT_BIT. In clearing this flag earlier we can now successfully execute commands in hisi_sas_controller_reset_done(), like bcast processing. Signed-off-by: John Garry --- drivers/scsi/hisi_sas/hisi_sas_main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/scsi/hisi_sas/hisi_sas_main.c b/drivers/scsi/hisi_sas/hisi_sas_main.c index 33af5b8dede2..a33d46a5d7cd 100644 --- a/drivers/scsi/hisi_sas/hisi_sas_main.c +++ b/drivers/scsi/hisi_sas/hisi_sas_main.c @@ -1527,9 +1527,9 @@ static int hisi_sas_controller_reset(struct hisi_hba *hisi_hba) clear_bit(HISI_SAS_RESETTING_BIT, &hisi_hba->flags); return rc; } + clear_bit(HISI_SAS_HW_FAULT_BIT, &hisi_hba->flags); hisi_sas_controller_reset_done(hisi_hba); - clear_bit(HISI_SAS_HW_FAULT_BIT, &hisi_hba->flags); dev_info(dev, "controller reset complete\n"); return 0; -- 2.35.3