Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <47d30adc-00ac-75ad-106b-18010d8083c5@amd.com>
Date:   Mon, 5 Sep 2022 13:26:50 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.11.0
Subject: Re: [PATCH 3/4] dma-buf: Add callback and enable signaling on debug
Content-Language: en-US
To:     Arvind Yadav <Arvind.Yadav@amd.com>, andrey.grodzovsky@amd.com,
        shashank.sharma@amd.com, amaranath.somalapuram@amd.com,
        Arunpravin.PaneerSelvam@amd.com, sumit.semwal@linaro.org,
        gustavo@padovan.org, airlied@linux.ie, daniel@ffwll.ch,
        linux-media@vger.kernel.org, dri-devel@lists.freedesktop.org,
        linaro-mm-sig@lists.linaro.org, linux-kernel@vger.kernel.org
References: <20220905105653.13670-1-Arvind.Yadav@amd.com>
 <20220905105653.13670-4-Arvind.Yadav@amd.com>
From:   =?UTF-8?Q?Christian_K=c3=b6nig?= <christian.koenig@amd.com>
In-Reply-To: <20220905105653.13670-4-Arvind.Yadav@amd.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?THZETHZrVkpqK1FLTStGU1dYQXd3WWZEcThSakI2cGdZWS9JbnFvbFdtR3B3?=
 =?utf-8?B?dzZBL3pRV3lhZG9NZVFJRTZJVmNzdndoZkRUUEZ2QWZmcm5Zd2xMYW9ZTmdj?=
 =?utf-8?B?SXF3Q0dXLzdZN3JYa0FVYTBsZVR1VDVtUXZnUmlWNjhYNXJydDZPbkwxa0Zk?=
 =?utf-8?B?WE9ISVVTTFJES1RGWkRHQzAvcHJBa0hyK1FLaUlwMFpQME5CRzhXdzJZR2wz?=
 =?utf-8?B?RU5FYjNPT0xFNHRtYUVyeklrbktyRTR6S3pWZHNDMGxrbkNzZWpCTjVGbE81?=
 =?utf-8?B?SWlRRGhiWnBxYS8zNlVXSVNvMkx3MlFrK0p3Y2RIT1BoUkF1YnJIR291R21v?=
 =?utf-8?B?UE5lUFMyV0c1RjlQUks3RTB0Mkl4aEhSUElNZnZpM3c5dGoyZ3JCNm1oZ2RU?=
 =?utf-8?B?SXN1QUIvSE5wbnlTS2NxakVVdGhGdmhLYjBEeUdXRmJLNXNYQ2xvczFndGls?=
 =?utf-8?B?SVN2Q1lUWWoxR1g3UVNNdUxGeGljSFlmNnF0SkpNM0kxdkVCMVlXVEpvWmg0?=
 =?utf-8?B?TmVpVWFJdzBzeG9CWm1Ka1c1OVhpVXJ1MncvL3psMkpzZUdxdGRZL1plb2lN?=
 =?utf-8?B?dDNoaThKZmdPUTBPeStObXA5NjBYZ2dEczlYZDlYb3BBWEZZYmMwSUdTaWVY?=
 =?utf-8?B?YTdESjNLM3EvRDZJd09tRElpa1RkNWxKOEJCOFNIZmpXL1Jtd2hmR2s4WS9n?=
 =?utf-8?B?aXk4VjBvUFk0eFJsQWxFVjlGMk9qU1BnYWZOMnpkMVFzV3lidS9LNUd6VVVP?=
 =?utf-8?B?VUZ3WXdvWXpYRGNmNkczRURIWGJrWEVuakFkcmtHQWw0cHp2QUlJSU54bzJ6?=
 =?utf-8?B?VHRMdCt5QmpaZ1R2TGxleWRPSGNTMHJ1OE04SE9rV1BQdVBWY0tKK1A5eWZR?=
 =?utf-8?B?TlFzRVNhT3ZhVHhDdDVNcS9iR0xxS24xZ2FDd05INWliY0hlUFNqWjhOa0xj?=
 =?utf-8?B?K1FQTUt6bks1clIyWENWQTAwa0g2aXNPRXdPZ3ZIcDB4d202OXZpc3FBcHhE?=
 =?utf-8?B?VEpXWTd4QmlRQWNxNDBNV3ljdmtsL1NpWEU4eTRBOGhjcEI1NDdtTlI2bWFq?=
 =?utf-8?B?YlhsK3FsMUxyVDU2S0RqQ2hrTEg3V2NsWEZTc0tzZVRtcEhOalJvemVDOUlJ?=
 =?utf-8?B?NDFlbDUyeU1PNFpPZDJ6cFBtRmxXVXo2Vlp4ZFlWVlhucFB4VTVhb3RreVpD?=
 =?utf-8?B?KzQ3VXlTZmlmZmRxbkR5VE56bFVDb29oakN4RlREZzRndVZqVE9tOW1HWEZK?=
 =?utf-8?B?SkpiZWMrQXJWSEpjUnlRcUFJQlVZQkpITCs1SDFKRjcyY05wOFJRU0dGeXlR?=
 =?utf-8?B?bUJuaDc5b05uMWNNUG94eFdMREd2RFE3U1RQcG5MSFRnUVo0K0Q3NE4yOUIz?=
 =?utf-8?B?Q0huTkhjTXdJWFpkc2FGeTVXazR0OUlWYXVzWHRNYU5kMG5YYkVDdDNNbEh2?=
 =?utf-8?B?WSsvcit4Sm05VUY2a2xEcnpRaGZ6QzlneHhzVVByZVRmSDczUlVqV3RWakRr?=
 =?utf-8?B?NWN4WXV5NTRQNTZMWitsbUZGN2ZidDYxcHU1NWMvTjRKL0psdW5NNy9TUjZy?=
 =?utf-8?B?c3BxdDFDS0U2cCtUM3NyZGJtOCtGRnZaWTQvWXVwM1hDSkcrYlZtSzBjY0dP?=
 =?utf-8?B?M0ZxWlpBVDZiNnBiNEczV1ZmeUQ1UkhKaEE0cGIyZERLOTR2SzF4NDJjVncv?=
 =?utf-8?B?VmRuM1l5ZHpSY05pMER0WWJCQ1R5QUNWcmtBSUVZbmZkNUZSbnA0UXVod2xJ?=
 =?utf-8?B?TUpwSHl6cm9sTjNvdlRNaTVqY3JhOWZBMXVMeWZ5djE1cWNCQW5hT1dvOVZj?=
 =?utf-8?B?b3BQUEhsdWxwU1Z1Y2FqajF5Yzd3bm8xMWlQcHU5OG9lOXBWNUpmVGRiY1dp?=
 =?utf-8?B?ajRseDB1NlR2OU1wbjhnUzhsbTJQK09qTkI5aFFKWVhBUDE4L1hGVHVUSTlY?=
 =?utf-8?B?YmdwNks3RDVuUi9TckJDLysvL2JYL29OOVJVbjA1VDVkTkRBWWRwOGZBNlhu?=
 =?utf-8?B?MTh6OExLN0lIWnlNeTFlOFNuOVVqT1hkRmc2LzFCbDd1czdSdnRjR1BXWncr?=
 =?utf-8?B?c2RvVkxSVTVwd20xZ2VpMi8xdTgwS1J4Z2g3a016NDVCQkk2UW9ZNGV6TWE5?=
 =?utf-8?Q?PUAhWReSlB75OX1e4cHycOtiZ?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 4eb8c5c8-5d34-40e7-5c92-08da8f318aa7
X-MS-Exchange-CrossTenant-AuthSource: BN8PR12MB3587.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Sep 2022 11:26:57.0771
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 0XuRUqstimfv0JOCNJEzTgwAVSzrgiVBPtqi9Dsrkz/T6DCP1Cvlk+290cz4nIyv
X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA0PR12MB7577
X-Spam-Status: No, score=-3.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,T_SCC_BODY_TEXT_LINE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


Am 05.09.22 um 12:56 schrieb Arvind Yadav:
> Here's on debug adding an enable_signaling callback for the stub
> fences and enabling software signaling for the stub fence which
> is always signaled. This fence should enable software signaling
> otherwise the AMD GPU scheduler will cause a GPU reset due to a
> GPU scheduler cleanup activity timeout.
>
> Signed-off-by: Arvind Yadav <Arvind.Yadav@amd.com>
> ---
>   drivers/dma-buf/dma-fence.c | 17 +++++++++++++++++
>   1 file changed, 17 insertions(+)
>
> diff --git a/drivers/dma-buf/dma-fence.c b/drivers/dma-buf/dma-fence.c
> index 066400ed8841..0a67af945ef8 100644
> --- a/drivers/dma-buf/dma-fence.c
> +++ b/drivers/dma-buf/dma-fence.c
> @@ -27,6 +27,10 @@ EXPORT_TRACEPOINT_SYMBOL(dma_fence_signaled);
>   static DEFINE_SPINLOCK(dma_fence_stub_lock);
>   static struct dma_fence dma_fence_stub;
>   
> +#ifdef CONFIG_DEBUG_FS
> +static bool __dma_fence_enable_signaling(struct dma_fence *fence);
> +#endif
> +
>   /*
>    * fence context counter: each execution context should have its own
>    * fence context, this allows checking if fences belong to the same
> @@ -116,9 +120,19 @@ static const char *dma_fence_stub_get_name(struct dma_fence *fence)
>           return "stub";
>   }
>   
> +#ifdef CONFIG_DEBUG_FS
> +static bool dma_fence_stub_enable_signaling(struct dma_fence *f)
> +{
> +	return true;
> +}
> +#endif

Again, adding the callback is unnecessary.

> +
>   static const struct dma_fence_ops dma_fence_stub_ops = {
>   	.get_driver_name = dma_fence_stub_get_name,
>   	.get_timeline_name = dma_fence_stub_get_name,
> +#ifdef CONFIG_DEBUG_FS
> +	.enable_signaling =  dma_fence_stub_enable_signaling,
> +#endif
>   };
>   
>   /**
> @@ -136,6 +150,9 @@ struct dma_fence *dma_fence_get_stub(void)
>   			       &dma_fence_stub_ops,
>   			       &dma_fence_stub_lock,
>   			       0, 0);
> +#ifdef CONFIG_DEBUG_FS
> +		__dma_fence_enable_signaling(&dma_fence_stub);
> +#endif
>   		dma_fence_signal_locked(&dma_fence_stub);
>   	}
>   	spin_unlock(&dma_fence_stub_lock);