Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <96d14c8a-e3de-fcea-b3b1-434bc6a78ae4@amd.com>
Date:   Mon, 5 Sep 2022 13:25:44 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.11.0
Subject: Re: [PATCH 2/4] drm/sched: Add callback and enable signaling on debug
Content-Language: en-US
To:     Arvind Yadav <Arvind.Yadav@amd.com>, andrey.grodzovsky@amd.com,
        shashank.sharma@amd.com, amaranath.somalapuram@amd.com,
        Arunpravin.PaneerSelvam@amd.com, sumit.semwal@linaro.org,
        gustavo@padovan.org, airlied@linux.ie, daniel@ffwll.ch,
        linux-media@vger.kernel.org, dri-devel@lists.freedesktop.org,
        linaro-mm-sig@lists.linaro.org, linux-kernel@vger.kernel.org
References: <20220905105653.13670-1-Arvind.Yadav@amd.com>
 <20220905105653.13670-3-Arvind.Yadav@amd.com>
From:   =?UTF-8?Q?Christian_K=c3=b6nig?= <christian.koenig@amd.com>
In-Reply-To: <20220905105653.13670-3-Arvind.Yadav@amd.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?Ym82SENRQTNRSmNhTlY4Ny9ZbDFkaEg5OHg2MWRENXU4UWV0clU5Z3FxU09v?=
 =?utf-8?B?dDEzSldLSkxaRWdySVZGZ0hEREtMRE9memZGRTlPcTl5MHBnQ3FkcEhjWU9n?=
 =?utf-8?B?dEFUSlpZd0tsYjZjcGJHVzlRcVNOck5QOFhFZVF5azUzOVZrb1A0ZkRkeUlV?=
 =?utf-8?B?R0tSdDdLbGR6Q0JlN2dlUHRTZ1c5am9EVTRqM0wrUjhtYitTOFIxSnpGT1Z0?=
 =?utf-8?B?V050cE1pQXh4TjJpV2piZU9JenV2eEE1RklURElKQzFYZ3I5bWNEblFYSnpM?=
 =?utf-8?B?Y2dHRU1WUTdFTlVKb1FndXNOcUMxbW9ZL0c0Yjk5MlJ2dHMrNld6N0pNTnRU?=
 =?utf-8?B?Y3Y4eE5JQXlGeThTK1g1cTFlZ0V5L3h2b3dnL3gxRWdkd2JYdzRlalZZSzl0?=
 =?utf-8?B?Y3pkcUlRNndCNXBtS3k3b0xoTEQ1U1Vmc3ZzZGFEMWxSZkFYdGpUeWZkOUx6?=
 =?utf-8?B?cVVwbVkvanZEOVNaSTZnc3lFdWNYUy9Idm81YTN6RGR0dWhMR0xkaHhBSm1I?=
 =?utf-8?B?NDZpM1YrcUZMUFpFL0p2ZmhJSFhwR0V2YzBKb2IxK25zd0NLYTdiT21oemEz?=
 =?utf-8?B?WlpyajUrL0UwV054Y2dTcHdNcmFmSnoyTGVYaWZWdG5kQlVucENUOUFBTkdL?=
 =?utf-8?B?c1d1NDY3U1FFdGZLU2tub09CUnRzMU4xcSs5S2trSVRKWk5pdUNuTnp4Y05q?=
 =?utf-8?B?akl6T2ZEbkk4aFdBK1FCTzBNWXFoa016djFqVUQ3TWJOcExBRko1Tml5QXBV?=
 =?utf-8?B?VUtOdHMyUXRZMFM2U28wV2ZpWVJnN0Z4RWpwWStDeDJBaGtHeUw2bStqWklZ?=
 =?utf-8?B?MXhzd3J0eGlQU1k4amwrU3ErWnBNMDlVUmkyd0RHR2tzUTR3U3loMVZ3WXUx?=
 =?utf-8?B?WmZQZ205dG1HUFdkMUZVQTBpVWZyRVJ4dXRGV1JHSUltL2JQSHh4T1BWNXhF?=
 =?utf-8?B?aTdCamIyMys3WDZUQ2RIeHExN09MQUE5c2tKWng0ZlNvZUVWTWVUZ0RScldD?=
 =?utf-8?B?dklKVWprYlJ6SXU0S2RUcTNjeXp5NGJhcjJOM1dkSW9qRzBJdXBaRW0zKzNI?=
 =?utf-8?B?RTlFT2lPU29OdWdjaEYwOFBPWVgzb3VQa3Y5WmpiM3pnWDc3enRrcWVmeW9x?=
 =?utf-8?B?SFFsamhqVlI0MFF2a29lN0Nqb0tIRjJDMU1qcWVtRTY0UjJmeEttUVBMUWJi?=
 =?utf-8?B?S0YyVkIwUXZMbVN6QmRXZStQT3JsK1VFeGZacTQ3aCt2L2NhY3lmK1lMS0sw?=
 =?utf-8?B?Ny94d0VBVmZrS3FlalFSczFqTmNnei8xOWRGZmIvdVdEdVBnaFRFYzh5T2Fp?=
 =?utf-8?B?REsveHhVbG43R1RZYUI0bStFWFMyaVlUbm56QkFHd29id1huNERXR2ZzMllo?=
 =?utf-8?B?SDhUUS8xemNaODJpNWdwTlR3K0lnQ01BeVBFU2p4QnFqYXd3czU2UzF5d2NS?=
 =?utf-8?B?Y21XZU9QSTk2Umt2R3U4S3haQk1JdnFkeU5sMnVVbTBCMDVLMFI5YnlFL3Fw?=
 =?utf-8?B?eWQrb0tzRzl5MS85bE1DOGlxVnUxMld6aTl1LzNHeHVaVGpSZUNBSDBQbmJp?=
 =?utf-8?B?SUx1bWxkaU1sWURGV1I2YVprS3FHUngxaHRjaTZ2eFFGdkhWMnlQK0Fzemhu?=
 =?utf-8?B?TUxrR2Y5YWp2aDUvYkxwK3k4aXlXQlVneUZpK0ZBOHNtWDRXdVEvdWFpcUhJ?=
 =?utf-8?B?SGc2RStXRGFvNHlGcGVwd0h6Zkp0d042bmpFL29TR3ZuL1lCb1NudDh2Um4z?=
 =?utf-8?B?RlFrNXVUSE9adDg0TGdvOUVuYVdKdkdwdTZIdkI1cUpWeTJrYnRsUlR0ZkZm?=
 =?utf-8?B?K2tMbzFEMmxxdWgxc2tEMkhFdHJlMHpTc1ZRK3IySXFnWExMSFdYU09mRzFO?=
 =?utf-8?B?UVhYSGV4ZUhGK2lQcHl3b053UG5aLzJoM2dVckx2aHZPWjFmWEppNkhaazFo?=
 =?utf-8?B?WkpDNHVzL2tHb1VOZytUa2RWTnk4a3E4Nm5DdDl4Njg5blBzajRvbm9Qc0lL?=
 =?utf-8?B?YWE4SXpFcHRVRVQ5WDJ1dDZ0bFVrUm5kWW9qNTdRNmNrbVo0bG5rUTA4UWZL?=
 =?utf-8?B?eXlSaFo3MXErUVg0WWNwQ0x5RysxSjdYZVByYmcvWmptdHVWK3BaSkxtQkhG?=
 =?utf-8?Q?u+LFrNfF1KKBb8YSOAWYVafEM?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 5adae3eb-7587-4db7-640b-08da8f316358
X-MS-Exchange-CrossTenant-AuthSource: BN8PR12MB3587.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Sep 2022 11:25:51.1440
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: xB8/TVc07AZmmnNOFfRGlhXcshH7rsNap/dBNHj6mG6guj8SaqdG39mPoUmzA6ki
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS7PR12MB6237
X-Spam-Status: No, score=-3.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,T_SCC_BODY_TEXT_LINE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


Am 05.09.22 um 12:56 schrieb Arvind Yadav:
> Here's on debug adding an enable_signaling callback for finished
> fences and enabling software signaling for finished fence.
>
> Signed-off-by: Arvind Yadav <Arvind.Yadav@amd.com>
> ---
>   drivers/gpu/drm/scheduler/sched_fence.c | 12 ++++++++++++
>   drivers/gpu/drm/scheduler/sched_main.c  |  4 +++-
>   2 files changed, 15 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/scheduler/sched_fence.c b/drivers/gpu/drm/scheduler/sched_fence.c
> index 7fd869520ef2..ebd26cdb79a0 100644
> --- a/drivers/gpu/drm/scheduler/sched_fence.c
> +++ b/drivers/gpu/drm/scheduler/sched_fence.c
> @@ -122,16 +122,28 @@ static void drm_sched_fence_release_finished(struct dma_fence *f)
>   
>   	dma_fence_put(&fence->scheduled);
>   }
> +#ifdef CONFIG_DEBUG_FS
> +static bool drm_sched_enable_signaling(struct dma_fence *f)
> +{
> +	return true;
> +}
> +#endif
>   
>   static const struct dma_fence_ops drm_sched_fence_ops_scheduled = {
>   	.get_driver_name = drm_sched_fence_get_driver_name,
>   	.get_timeline_name = drm_sched_fence_get_timeline_name,
> +#ifdef CONFIG_DEBUG_FS
> +	.enable_signaling = drm_sched_enable_signaling,
> +#endif
>   	.release = drm_sched_fence_release_scheduled,
>   };
>   
>   static const struct dma_fence_ops drm_sched_fence_ops_finished = {
>   	.get_driver_name = drm_sched_fence_get_driver_name,
>   	.get_timeline_name = drm_sched_fence_get_timeline_name,
> +#ifdef CONFIG_DEBUG_FS
> +	.enable_signaling = drm_sched_enable_signaling,
> +#endif

Adding the callback should not be necessary.

>   	.release = drm_sched_fence_release_finished,
>   };
>   
> diff --git a/drivers/gpu/drm/scheduler/sched_main.c b/drivers/gpu/drm/scheduler/sched_main.c
> index e0ab14e0fb6b..140e3d8646e2 100644
> --- a/drivers/gpu/drm/scheduler/sched_main.c
> +++ b/drivers/gpu/drm/scheduler/sched_main.c
> @@ -961,7 +961,9 @@ static int drm_sched_main(void *param)
>   			s_fence->parent = dma_fence_get(fence);
>   			/* Drop for original kref_init of the fence */
>   			dma_fence_put(fence);

Uff, not related to your patch but that looks wrong to me. The reference 
can only be dropped after the call to dma_fence_add_callback().

> -
> +#ifdef CONFIG_DEBUG_FS
> +			dma_fence_enable_sw_signaling(&s_fence->finished);
> +#endif

This should always be called, independent of the config options set.

Christian.

>   			r = dma_fence_add_callback(fence, &sched_job->cb,
>   						   drm_sched_job_done_cb);
>   			if (r == -ENOENT)