Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Niklas Cassel <Niklas.Cassel@wdc.com>
To:     Dennis Maisenbacher <dennis.maisenbacher@wdc.com>
CC:     "linux-nvme@lists.infradead.org" <linux-nvme@lists.infradead.org>,
        Christoph Hellwig <hch@lst.de>,
        Sagi Grimberg <sagi@grimberg.me>,
        Chaitanya Kulkarni <kch@nvidia.com>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] nvmet: fix mar and mor off-by-one errors
Thread-Topic: [PATCH] nvmet: fix mar and mor off-by-one errors
Thread-Index: AQHYwSJaL0sgHpgYm06eo7YO4ydfha3QxSsA
Date:   Mon, 5 Sep 2022 12:33:38 +0000
Message-ID: <YxXsoAk+RMUs25L8@x1-carbon>
References: <20220905122116.2678206-1-Dennis.Maisenbacher@wdc.com>
In-Reply-To: <20220905122116.2678206-1-Dennis.Maisenbacher@wdc.com>
Accept-Language: en-US
Content-Language: en-US
wdcipoutbound: EOP-TRUE
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?GWlArK+wibxpi7x4J3OflDTia1cfq9uyblRRt0Kv0JoqIrLlsLkgqcsDBv06?=
 =?us-ascii?Q?F0rDHFKYyJ/hsPoFzyQeM4/vU8zUwFKNYRbctsX4430JyV//g00vUCOXfeHC?=
 =?us-ascii?Q?Fduc7VK5bttKtoJ/qnHxCR/6lnpvgc4yI+X2Nfe38z7ioAueaYkA9moZPZxT?=
 =?us-ascii?Q?E7k813Iy1n0CidwhPniUoncHpxknhy6rB7N9EzTVGRnio8TwjYpU+d5yigBd?=
 =?us-ascii?Q?TeF71nOpT5sXUQ+vv+vVS8RPHmMHyCRzzXjTu+7l21WZakdyGj91QSb2+K9I?=
 =?us-ascii?Q?46UiXwss92LrSaF5k6AVyAtbmAUzZo3/o/iO54cviHLsvMyTH3LUFLuQQ/2a?=
 =?us-ascii?Q?Fw/L/UWMHaMmb2cH/esN5PMiKip76F5wwS6Ol3XbYp8HdmawhLTbpYUSzEld?=
 =?us-ascii?Q?QTHAVryUMPLO6NQ0UtUilNgcSKeV+StNjQ5S/71tpZObAC9qbSL0IpF596k3?=
 =?us-ascii?Q?b/EMe8Qy/RSS8+c2S6qyRbAZ7MsOxUGeGKYWxRRDpJAjv6ihZszGDMRMk+hO?=
 =?us-ascii?Q?KQjltHE2hKKoRQLBjmvzZIQov8eauvCiK02trYFgDwpzug4mdyj5Oe9GV/D+?=
 =?us-ascii?Q?hZPqkH7HgBow+TbAmra23/35KMfCuRUM4BSbXQw+MylBvRA0YAY4E0x85Fl2?=
 =?us-ascii?Q?x/S15oydG7VxqonrIQWKeXOfmP9tADHki2+Kr0c5bTJj8+1vnmfVof1dA2Z/?=
 =?us-ascii?Q?fTN8EL8afHTvN6of4fZRRNoyk5lkUz6xeNjmuHZcrEz6jZnHBmlOspkrKnq7?=
 =?us-ascii?Q?sSae1SIP1mgv2VLD2RXpiJdwfnc3ihrTAaStmHuxIFJ6yirVF9WNzUx17Ydk?=
 =?us-ascii?Q?d+70NKbWK03/GCecgmqrutQlCkr5pWZogY2BCc7jCuFZbp6UmoIn6LAqB2Zv?=
 =?us-ascii?Q?/85xE6FMhlzSROxAya7WaUcXmHL9PjzfNZmeGKVmvKUOl6IEiKepKZK9h3FI?=
 =?us-ascii?Q?rXi9rKbT8FlvYsRL27fqt4VZUjb8QCSi7w8QtRZ0na5Roz/COI0iLWuDQmHB?=
 =?us-ascii?Q?Q76QZpkKHffbgWERR6O6hDjbeqjh6ijK3g7o/fg8SD2BuzAJVV3bGHDCaN1X?=
 =?us-ascii?Q?Yeebu0NtmaLDchNtEO+RAmUboE/21Y6n1Y+q7W6xJEJqvtgfhk4sKpvWXiAg?=
 =?us-ascii?Q?rJWjNoVkDKqRSdmR68AREqHAk94U0DADB6N/i3xmOsh2yRyNMlUKW2Ra4cna?=
 =?us-ascii?Q?xN1gFLU4APhrncmFhnDn4AZVRi29hFU7SwqIdb2nLZ7IKm0SsZPis2oqU5gc?=
 =?us-ascii?Q?lcGhwFnAFkoJqdQcpdTqUNJ89uZ3xRH52HI3WDlV8oHAb/zg/WjcWTW3GlDi?=
 =?us-ascii?Q?z5ZDJxkNFmQdZMMZvgy2AslkXoboOBBpRE6FtlBwWfyvsA1BDnZmkF8x/x8Z?=
 =?us-ascii?Q?8gUVL/8Wxdlivh/rgHKzG47X2VV4ROXMohhAJy1J3PIBZF5wqRzUzFtgOMNo?=
 =?us-ascii?Q?sgC/8BqPZOdtxrEj/SzQU7F/vQhEhYWk2vecvM7BAKNdRw+sdvR8r066sEr0?=
 =?us-ascii?Q?M/sSTPF8uwEkp1GW+6sWeIyf7cxke4Q7q7sxlC3I3L14WicMmRqsZmbwl14L?=
 =?us-ascii?Q?OktQNpkhtZjCYI+rGIu3Z/kiPIXtuMWv9Oj4IKXJr0s9f8omQZLNR6z0Zp2t?=
 =?us-ascii?Q?9g=3D=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-ID: <4ABF074E98D5844AB2E78BEC724F9DBC@namprd04.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: wdc.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: PH0PR04MB7158.namprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: e234198e-200c-49f5-9ddb-08da8f3adb8e
X-MS-Exchange-CrossTenant-originalarrivaltime: 05 Sep 2022 12:33:38.0466
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: b61c8803-16f3-4c35-9b17-6f65f441df86
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: qrnZET5e/hhnOtLUR0u0hCx+u+R/aL5O8FQaDK2U2z4WCbnpjGqwJ/K02yklAXXp8W8PUrK2vLQM+SE8K+PD9w==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN6PR04MB4813
X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,SPF_HELO_PASS,
        SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no
        version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Mon, Sep 05, 2022 at 02:21:16PM +0200, Dennis Maisenbacher wrote:
> From: Dennis Maisenbacher <dennis.maisenbacher@wdc.com>
>=20
> Maximum Active Resources (MAR) and Maximum Open Resources (MOR) are 0's
> based vales where a value of 0xffffffff indicates that there is no limit.
>=20
> Cast the unsigned int values that are returned by bdev_max_open_zones and
> bdev_max_active_zones into u32 vales which need to be decremented as the
> returned values of the block layer helpers are not 0's based.
> The cast to u32 is necessary because the size of unsigned int is
> architecture dependent and a 0 reported by the block layer helpers
> indicates no limit, thus it needs to be converted to 0xffffffff which
> happens by underflowing the u32.
>=20
> Suggested-by: Niklas Cassel <niklas.cassel@wdc.com>
> Signed-off-by: Dennis Maisenbacher <dennis.maisenbacher@wdc.com>
> ---
>  drivers/nvme/target/zns.c | 7 +++++--
>  1 file changed, 5 insertions(+), 2 deletions(-)
>=20
> diff --git a/drivers/nvme/target/zns.c b/drivers/nvme/target/zns.c
> index c7ef69f29fe4..606f21ee21bf 100644
> --- a/drivers/nvme/target/zns.c
> +++ b/drivers/nvme/target/zns.c
> @@ -100,6 +100,7 @@ void nvmet_execute_identify_cns_cs_ns(struct nvmet_re=
q *req)
>  	struct nvme_id_ns_zns *id_zns;
>  	u64 zsze;
>  	u16 status;
> +	u32 mar, mor;
> =20
>  	if (le32_to_cpu(req->cmd->identify.nsid) =3D=3D NVME_NSID_ALL) {
>  		req->error_loc =3D offsetof(struct nvme_identify, nsid);
> @@ -130,8 +131,10 @@ void nvmet_execute_identify_cns_cs_ns(struct nvmet_r=
eq *req)
>  	zsze =3D (bdev_zone_sectors(req->ns->bdev) << 9) >>
>  					req->ns->blksize_shift;
>  	id_zns->lbafe[0].zsze =3D cpu_to_le64(zsze);
> -	id_zns->mor =3D cpu_to_le32(bdev_max_open_zones(req->ns->bdev));
> -	id_zns->mar =3D cpu_to_le32(bdev_max_active_zones(req->ns->bdev));
> +	mor =3D bdev_max_open_zones(req->ns->bdev);
> +	id_zns->mor =3D cpu_to_le32(--mor);
> +	mar =3D bdev_max_active_zones(req->ns->bdev);
> +	id_zns->mar =3D cpu_to_le32(--mar);
> =20
>  done:
>  	status =3D nvmet_copy_to_sgl(req, 0, id_zns, sizeof(*id_zns));
> --=20
> 2.25.1
>=20

Reviewed-by: Niklas Cassel <niklas.cassel@wdc.com>=