Received: by 2002:a05:6358:bb9e:b0:b9:5105:a5b4 with SMTP id df30csp3127124rwb; Mon, 5 Sep 2022 06:55:55 -0700 (PDT) X-Google-Smtp-Source: AA6agR7BjompeD1BBYWZY7f48wKQXDPUXI2yvOf6OCWZYkkZ4ST+Qz8Izd/e682pRueJunOh+5FI X-Received: by 2002:a17:907:94c5:b0:74f:25e3:5f86 with SMTP id dn5-20020a17090794c500b0074f25e35f86mr11138916ejc.304.1662386154600; Mon, 05 Sep 2022 06:55:54 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1662386154; cv=none; d=google.com; s=arc-20160816; b=C1BN9jDRanc8epTqk7oSPnUqL2mlsWHDSEJU5x3JSB3Al9rcDoo7ICY8T7pjP0eHXe s5Jq7eDkr8GEffySBdkaw1DQ49ZRijGqRmLSOCB7Lej2nOEdv3J2Mt4W944gP9i+2IcP 0RrClCF/tkQWQlFvWQazm7V3aYHJ75/taO7JpeysEwVwfz0W+vbL9gz+l8bzJQq2v1Zn wGNDRI0G/GsE/cBWv37CNsx+afbQRVGoaVzcgORKkIAtNHcdHT/qDrgfB6mLLPqbSp7O 498h+i4BKBR1Ly2vqgsvLorviqo6dBIsb2b7OzxJaUboatCL01iugWQu0V4etJOFeBzi QezQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:in-reply-to:references:date:message-id :from:subject:content-transfer-encoding:mime-version:dkim-signature; bh=GbFpUKpmn8+3G8MYLTRbcyymKN1IZOrLJeJdy/dqTI0=; b=UtFR2oUCTuGkIOjBA4E1mudp+GbnLmZ7byhYtZzVL7OqH47xEnALJsPgOGo0+zzZ1v MqKfln4fA1VjpNpUP63woT8E0PPol1ENA1c/u8YYMXIdFT07qoekvPW77fLgVendOMwe bp12djjubzIcdmEAkdrIIywXulQUCQcipV5oPFAEZQwPOeI63hExid91lh8+shtI6NHZ GsvYqlkCCRc+MXmXORHJ4nexWW7MZ/GZtgmZXI6RdAop+5444vDOP0yJiH6s/iYD829M 79ozziIHKc20ybWKkj+ISabSaIoF22MHOdfMDa3HeMvcqmdyEZLPmDIiet68ujKLK7kg udIA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=hUJvm8xP; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id fd21-20020a056402389500b0044dd5489087si3190289edb.456.2022.09.05.06.55.29; Mon, 05 Sep 2022 06:55:54 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=hUJvm8xP; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237567AbiIENUW (ORCPT + 99 others); Mon, 5 Sep 2022 09:20:22 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41246 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237156AbiIENUT (ORCPT ); Mon, 5 Sep 2022 09:20:19 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 047F73A4AC; Mon, 5 Sep 2022 06:20:17 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id B598FB81199; Mon, 5 Sep 2022 13:20:15 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPS id 687F0C433B5; Mon, 5 Sep 2022 13:20:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1662384014; bh=e9NEwRa9nVE7vDMPK/zgYTGoSMf7Tlz/nhF2GzBSrgs=; h=Subject:From:Date:References:In-Reply-To:To:Cc:From; b=hUJvm8xP4h0LpId+ykFj4g/mw6OA0294exGolRgPYQ7tz2omje0h8GgbjxPyyZRw0 Bcgb94YPKvVlsgnKzV3mxcQuNZoBZ1KQV/CB2z/A8WIuyw1+DUscKZSZrPirDrVj1A SWOBelSxMOXMEzYbP8HhXOWEmylTefH07+XTqlyWe2MUQR0gp2aU77sX37qqvnuSBv fVDbeHuVtFPG8Ikrp+CFQyEM7f+uYEHRsKYsF5UfBr0nTCoTftEZONU5YiIBKak57H lyaTH9+bDrcYp9BiiMx6D3V7av9HroHYkQQCNY8HhCuGz2udy4677/+kC3RI4kJRtZ 9V+/ZvyL3VMpQ== Received: from aws-us-west-2-korg-oddjob-1.ci.codeaurora.org (localhost.localdomain [127.0.0.1]) by aws-us-west-2-korg-oddjob-1.ci.codeaurora.org (Postfix) with ESMTP id 4F006E1CABF; Mon, 5 Sep 2022 13:20:14 +0000 (UTC) Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: Re: [PATCH net] net: mvpp2: debugfs: fix memory leak when using debugfs_lookup() From: patchwork-bot+netdevbpf@kernel.org Message-Id: <166238401431.22589.16841027268928953217.git-patchwork-notify@kernel.org> Date: Mon, 05 Sep 2022 13:20:14 +0000 References: <20220902134111.280657-1-gregkh@linuxfoundation.org> In-Reply-To: <20220902134111.280657-1-gregkh@linuxfoundation.org> To: Greg Kroah-Hartman Cc: mw@semihalf.com, linux@armlinux.org.uk, linux-kernel@vger.kernel.org, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, netdev@vger.kernel.org, stable@kernel.org X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello: This patch was applied to netdev/net.git (master) by David S. Miller : On Fri, 2 Sep 2022 15:41:11 +0200 you wrote: > When calling debugfs_lookup() the result must have dput() called on it, > otherwise the memory will leak over time. Fix this up to be much > simpler logic and only create the root debugfs directory once when the > driver is first accessed. That resolves the memory leak and makes > things more obvious as to what the intent is. > > Cc: Marcin Wojtas > Cc: Russell King > Cc: "David S. Miller" > Cc: Eric Dumazet > Cc: Jakub Kicinski > Cc: Paolo Abeni > Cc: netdev@vger.kernel.org > Cc: stable > Fixes: 21da57a23125 ("net: mvpp2: add a debugfs interface for the Header Parser") > Signed-off-by: Greg Kroah-Hartman > > [...] Here is the summary with links: - [net] net: mvpp2: debugfs: fix memory leak when using debugfs_lookup() https://git.kernel.org/netdev/net/c/fe2c9c61f668 You are awesome, thank you! -- Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html