Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <f9042797-1c41-a4c2-fdd2-60feaf38e87a@amd.com>
Date:   Mon, 5 Sep 2022 19:13:52 +0530
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.2.1
Subject: Re: [PATCH 1/4] dma-buf: Check status of enable-signaling bit on
 debug
Content-Language: en-US
To:     =?UTF-8?Q?Christian_K=c3=b6nig?= <christian.koenig@amd.com>,
        Arvind Yadav <Arvind.Yadav@amd.com>, andrey.grodzovsky@amd.com,
        shashank.sharma@amd.com, amaranath.somalapuram@amd.com,
        Arunpravin.PaneerSelvam@amd.com, sumit.semwal@linaro.org,
        gustavo@padovan.org, airlied@linux.ie, daniel@ffwll.ch,
        linux-media@vger.kernel.org, dri-devel@lists.freedesktop.org,
        linaro-mm-sig@lists.linaro.org, linux-kernel@vger.kernel.org
References: <20220905105653.13670-1-Arvind.Yadav@amd.com>
 <20220905105653.13670-2-Arvind.Yadav@amd.com>
 <0038fcff-35f1-87e3-aa26-cdd104a13628@amd.com>
From:   "Yadav, Arvind" <arvyadav@amd.com>
In-Reply-To: <0038fcff-35f1-87e3-aa26-cdd104a13628@amd.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?OTNIai9xSk04RFcvVnlWdDBsbVcxUEU5dU5FVno0b09iWXlYWkpQWkdYckpF?=
 =?utf-8?B?endBdnF6ajk3QmRoOUtUclZ4Vmthcno5R1NVL0xaa25BcVZnRXREOG15Z0s3?=
 =?utf-8?B?YzFkUm1QSkszS0UyajJmYTNkcldNOG1WNjB6REQwL1JCa0hMMWl6cjM0a0JJ?=
 =?utf-8?B?MjlnZ291QVI2T0l3MXNkOHA4RlNFVTRWbytMZTJjWlp5aUhsRVBMY01hM3hL?=
 =?utf-8?B?UDlCUk9TRHp1em9rbzZ0YUgwUHVpMFQ1WE1tS0p5ZU9US01tbW11WWtKaVFr?=
 =?utf-8?B?MjJ1dVREYTc0dmEySUxuUUQ4Ynd5aGNYWElYZWJCcmpDYzBwa0FiTm5hMWlZ?=
 =?utf-8?B?SUdncTQ3NDJ6Z1ZRNitUcXY3S1F1Yzd4UWVOdFBCMTU0VGN0SDBtbjJRMmJi?=
 =?utf-8?B?aUkyaDhXM1dJcnBUVnZzT2dMcStDd09hNmRjSzBkQzhiK3FPN3hsd1lSc2Rz?=
 =?utf-8?B?N1BPR2h2TC9VckE4elRaY053NDdYbTllQTQ1bXo2TkpyV3FPUi9ld3dQWFNU?=
 =?utf-8?B?cnUrUEJqOEo5RDc2L00wQVZ4S3I5cjVsUEthQ0pDU05Ha01hSHNNWkgrVHpx?=
 =?utf-8?B?azF5YVNtS2RqaytFRkRGRjRjSVBqTndNTlduKzBRZW5nb2Z1VTEyMnFzSmMx?=
 =?utf-8?B?dk13V3FTMkJPT1RZWUVSd09veklwRFVYMFZZaXNiZ2UvcVJJaXNkb3VpZ3Jv?=
 =?utf-8?B?Yy9nUUJacXozdGJ3TURiMHVNRWZ2Zm5HNTdiak56aGZpSzJrZlBhdTJXOVgy?=
 =?utf-8?B?SS96bWpvZEg1K2crR2pBSGpNRk9WNWNnTnlmSkpWS1Fuc0JvVmNyaWRCd1Fs?=
 =?utf-8?B?R09ldTNYRE5lSzYycm11c0tEWWF6dVVpSjlldEZxVlZ4TTJYZHYxOGdBaGI2?=
 =?utf-8?B?WWg3alJWbDc2c3lrWkVyTGlyZG1qR3J1RTV0L0RUOENWYy9idE9KbktZZTVx?=
 =?utf-8?B?NjdNcmo2RWgyY29XSVhoNmVtaWwzWnRHcit2OVBzNjZSeU1qYXNudm5JS3FH?=
 =?utf-8?B?djM1Y3BDQzBmVHFkc0pVcS9uK1g4N2lpdjJwTmNJWllmM0wzUWU1RFZYS3Y3?=
 =?utf-8?B?aVZWeXdnUTh3dEJDZUR1RWY5by9Ha2Jtb0hyMzBvb0tPbXpXTllPSURVTG1W?=
 =?utf-8?B?OTJkdUtsR0EwNSs5YklrVkhTYkV6L2tIclluWVVNSm8zQTV0VG82dXJocU0y?=
 =?utf-8?B?TE1nMFkrQ214TjljclZTQllBNVEzblpRV0tIQU1MRUZkRHh3WTAwendadGhy?=
 =?utf-8?B?UVNTSkhOVXdJa3JBdUdKeWIrNmV6akFmN1NPckxuTWZTQ0FSVTB2NGFHcTlF?=
 =?utf-8?B?V1djMVdORmZCK0hZYU9PTGdpMHhaNEhiNFZETkdoanNVZ1hKSEpwMjZ6bFVK?=
 =?utf-8?B?NWZjM0crckNLL2grTmtCMm9BaG0xR3A2eU9sK2hHTjUwTFpsU3BCbzNHSDJO?=
 =?utf-8?B?S05RT0h4UDZWZncydUNWbTM0WXA3OXoweDBQMWVsb3ZKZWJzRXVXTm5WUWhz?=
 =?utf-8?B?NFRGVXNsMFFvSWZvOWVWNUVyRlZOa2FEZHcvb3BiTGxlREN2ditza25yYW0r?=
 =?utf-8?B?QmNLMmEydkFmT0RKVjlzZ1ljdzFXcVZiNEFrblFCNWhtMkkySlRzVW5SNWtz?=
 =?utf-8?B?UTNNL0o1ckxRbjJLZkpMdVJaOUowS3dpNUlQSWlRbk5DeEZXc1QxU1NsbU8v?=
 =?utf-8?B?QUhuMy9CalVZN21tTXgzSkp3ck9meWpVYTFTMnpQVVA1MHFlVk9xUmRjOGRE?=
 =?utf-8?B?NlExU2oyWGNSdHA2WnZ0N2lnVkw0bTR2VGtPSjc1U0FJbjZFS3FsMVM3UTd6?=
 =?utf-8?B?Mm5ZblBXWlBzWDRCMUFuYjhHcm1CbnpQSDVlWCtFaUJVc1oyY1Z5S1BaY0tM?=
 =?utf-8?B?RG1kZ3VXNWxoZDB4V0ZjQ0lsMDAyMDV2cDF0MkluM2xXZjN0VnlxWXYzRndh?=
 =?utf-8?B?WklUZlUrbWZLQ0IzbTU0RUpIaEo1TktpQkR2TmYxTGp2dHYwOEFpaG1GVGo0?=
 =?utf-8?B?Wk03VXR1WlRoQjh6d0t4K0F3ME9lSGRnTHAySE5SY2sxdStYV0FleGE4WnBV?=
 =?utf-8?B?TmczNUVZSkpBek9zT1NiN0F4ajlpektRb2FoM2VzcjN4NEJCbFdrVldrZTFu?=
 =?utf-8?Q?DWNF16cWEWYKPef5vN1YjQQxw?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: fb022abf-5b92-41c9-dc7d-08da8f44b2ac
X-MS-Exchange-CrossTenant-AuthSource: PH7PR12MB6000.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Sep 2022 13:44:04.8004
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: fKHDNm/l1qKe0cdS98ujoIJf5cyhgdhrPgf2fneRWJ66otueqohj3DuRDHXt6RfBDueldcEzedixb6znC4BzqQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN0PR12MB6079
X-Spam-Status: No, score=-3.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,T_SCC_BODY_TEXT_LINE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 9/5/2022 4:51 PM, Christian König wrote:
> Am 05.09.22 um 12:56 schrieb Arvind Yadav:
>> The core DMA-buf framework needs to enable signaling
>> before the fence is signaled. The core DMA-buf framework
>> can forget to enable signaling before the fence is signaled.
>> To avoid this scenario on the debug kernel, check the
>> DMA_FENCE_FLAG_ENABLE_SIGNAL_BIT status bit before checking
>> the signaling bit status to confirm that enable_signaling
>> is enabled.
>
> You might want to put this patch at the end of the series to avoid 
> breaking the kernel in between.
>
sure, I will add this patch at end.
>>
>> Signed-off-by: Arvind Yadav <Arvind.Yadav@amd.com>
>> ---
>>   include/linux/dma-fence.h | 5 +++++
>>   1 file changed, 5 insertions(+)
>>
>> diff --git a/include/linux/dma-fence.h b/include/linux/dma-fence.h
>> index 775cdc0b4f24..60c0e935c0b5 100644
>> --- a/include/linux/dma-fence.h
>> +++ b/include/linux/dma-fence.h
>> @@ -428,6 +428,11 @@ dma_fence_is_signaled_locked(struct dma_fence 
>> *fence)
>>   static inline bool
>>   dma_fence_is_signaled(struct dma_fence *fence)
>>   {
>> +#ifdef CONFIG_DEBUG_FS
>
> CONFIG_DEBUG_FS is certainly wrong, probably better to check for 
> CONFIG_DEBUG_WW_MUTEX_SLOWPATH here.
>
> Apart from that looks good to me,
> Christian.
>
I will use CONFIG_DEBUG_WW_MUTEX_SLOWPATH instead of CONFIG_DEBUG_FS

~arvind

>> +    if (!test_bit(DMA_FENCE_FLAG_ENABLE_SIGNAL_BIT, &fence->flags))
>> +        return false;
>> +#endif
>> +
>>       if (test_bit(DMA_FENCE_FLAG_SIGNALED_BIT, &fence->flags))
>>           return true;
>