Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <0ce528c5-dbeb-4bad-9bfb-68decb46a1a8@amd.com>
Date:   Mon, 5 Sep 2022 19:20:03 +0530
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.2.1
Subject: Re: [PATCH 3/4] dma-buf: Add callback and enable signaling on debug
Content-Language: en-US
To:     =?UTF-8?Q?Christian_K=c3=b6nig?= <christian.koenig@amd.com>,
        Arvind Yadav <Arvind.Yadav@amd.com>, andrey.grodzovsky@amd.com,
        shashank.sharma@amd.com, amaranath.somalapuram@amd.com,
        Arunpravin.PaneerSelvam@amd.com, sumit.semwal@linaro.org,
        gustavo@padovan.org, airlied@linux.ie, daniel@ffwll.ch,
        linux-media@vger.kernel.org, dri-devel@lists.freedesktop.org,
        linaro-mm-sig@lists.linaro.org, linux-kernel@vger.kernel.org
References: <20220905105653.13670-1-Arvind.Yadav@amd.com>
 <20220905105653.13670-4-Arvind.Yadav@amd.com>
 <47d30adc-00ac-75ad-106b-18010d8083c5@amd.com>
From:   "Yadav, Arvind" <arvyadav@amd.com>
In-Reply-To: <47d30adc-00ac-75ad-106b-18010d8083c5@amd.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?Tmp3RUIrK1Y3a1dodU4rVzFWMGJrTnEzamxwK2JlMDgxYnNXMEE5ZnNTdytq?=
 =?utf-8?B?czNMbnUvVlBPeHdLdjNIdER6aytjMW9LK3laZmR3bnVFVkx3cm5jU2dsaURp?=
 =?utf-8?B?Qzg3alBFNVlnYnBtM0c4b2R4ak50U3E0bDhFQ0Fwd3FqRW9iREsyZytZdnhJ?=
 =?utf-8?B?NzJhdzBkbEhYZFhvSDN0THNEMXFQTHFiOFBjS3NzNHJJbFlCanVRbVB2RzZk?=
 =?utf-8?B?b0JIcFRRcWJXSDQ2Vyt1VFNmTUhEL3MyQ2pibkRKMkttMlBPZHlmNm90QUNo?=
 =?utf-8?B?RWlUbEUzYXVlaGxiNjVDMndxNUlqcms3M1RLOUlRVW9BMVUrQmhpb2VMTG1I?=
 =?utf-8?B?b1E1WSt1b0twTEV4MGFCa3B4Y05yc25lOXE3amNHYUdJaDdPeWFZOVB0cmNz?=
 =?utf-8?B?c3ZYRzkxRnFwdTVmaW42MzJlRlZ4L29RYm5zWjc2Zlh5Vi9mT0c1dTlibVlR?=
 =?utf-8?B?L2V1QndiMzFkM2hkN0toT2toK1NxMkFqRWxuRGZQSXdNcGtuemxRVSt1VDl1?=
 =?utf-8?B?bDVjbFkzRk1mRUJoaUdicDU5OWluVllVWjN6dnFVVFUxUERJSk1zZ1ZyN3Fp?=
 =?utf-8?B?TkJOUkVLc3hxVzhTUHFYVC8rMmhibjhaWFVSelFGaG1XaFpzTXdDbk9MZmw2?=
 =?utf-8?B?VkYyK1A0SklHOVdLN0FjRm10alJzRytIbW84WHZVakdIMDNUT3IxSk5ndkQ5?=
 =?utf-8?B?N1J2K0lkeDRLRElDQUZPejV0WmNjZmk1SENKSUNNVXVqQ2dhSGZ5ZXBmamRQ?=
 =?utf-8?B?WE1UUFE5MU9seXJlUU9uSFliQUdiQkhmU2lkZHAvRVlCWEl3bU02ZGhFaUQz?=
 =?utf-8?B?cHZWZnRucU5oZEhVYk1BS1o0NnRUclcwcVBkc2UxZ05wMld5MXdLSi9zTENG?=
 =?utf-8?B?aHA2cnNLd0xzRmtkMjdaTUpncG93TElST3Y0Y1R4UnhqN0lhbkphb283Tllt?=
 =?utf-8?B?V28rU0V5ZUNxWkdPb1RKc0xXcHFhR3NoeEFtS2hJZGxFTHYrcDFoRkZTdlhS?=
 =?utf-8?B?anNpSTV6N0M4dC85WTR5NzZSSFRmK3p2WUk5VExBL0x1czRnbnVHZTU0R3NH?=
 =?utf-8?B?UERQa3VBNFpKWkpTa2Q4cjlSb2x1VEhTODA0Wk1kc2hTUEJVeENqZGlXZ1ZB?=
 =?utf-8?B?bFgvUTA2Nkp1QjYrYVV1ei81b1RTdFJwczVEUG1oR0RQYWhTMTFGYmMwRFM3?=
 =?utf-8?B?VlRYaVhrdGlXVFhiQVJya0VlYStyeE1zUU5tbk5IUjJYSkhkUDkyT3B5VHE1?=
 =?utf-8?B?MHhSVm1HcDluelRtWDB3TnVpUHhiazAyUFZuTmRLemtZQWVmMVl0cDNvSDBR?=
 =?utf-8?B?a1R1OGFxZ1JOWUQyemVlVkFUOEhmZGdpUmlmTTYzQ0pINmRnNVZFL3RHVmdr?=
 =?utf-8?B?M2kwUWhEbkJSTGZqOEphdmJYcWo5UUhnZDNCMTBjZ21DeTZ1UW9NRnFxS21s?=
 =?utf-8?B?ZGR2SGRmaDgzWGlCOUFGM0Ric3JmVzh1aEtGaG5NS01ZS1llemx2eW9nU1dz?=
 =?utf-8?B?UVA2RWtFeWdvRmZ5ektNaE11UUw3NXQ4eVd1QlJKWnJIODYyR1F5UlAyTThJ?=
 =?utf-8?B?TGw1NDB1U0t1SVo1K25VY3lDbTdFMVI3Q2lYWEd1dytUOHpBcUNoUUQ1dHlZ?=
 =?utf-8?B?S2RNcTB1L01mc0Zyc2lNKzc4dWsxT2V0d09wK0J1MjVWYkJZM0xuYlRyMC9K?=
 =?utf-8?B?WFlZYjlBMEZwMFR1SGhSTUlQNTR3TU5DYlJuMWdzeUZBd0NKcWJCVFVxOUw2?=
 =?utf-8?B?b2lEYjVnWnFXQ215Sk80Sm1xOUxQQVFFUzZZeWtpVFRFZWNDS1JoTnRQdjdV?=
 =?utf-8?B?TjZCTklYVUozcEtRSTdTdWJFdnBwMTArVlBPSytBL0VPUmRiN2didlZDaDUy?=
 =?utf-8?B?S2RWOUhUanpWTEFVdmZ6Q09WMXoxQUNiTVhCOTd4bVRQOVZYbWppV2ZzdjNy?=
 =?utf-8?B?Q0FTUGFlcW5VN1ZiOFdWTWFXQlY2QkFEM1NySUhmVXFFQUJJditQUEZuY3dB?=
 =?utf-8?B?N3E5elE3eDFLTUlmeTgxcnYybVdVMkxBdmR1QkpMRUxhU1A3UU01T3Y5Rzc1?=
 =?utf-8?B?QmhUdzJqanlNcjY5QW1FTWJYQmRGdm1iVFJMa1dicHBzakdBS0tVVEd2NlBi?=
 =?utf-8?Q?lOETh3Xb5PNuQmPYHAZ6BTibr?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: a50b0c58-149c-4541-a4d5-08da8f458fba
X-MS-Exchange-CrossTenant-AuthSource: PH7PR12MB6000.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Sep 2022 13:50:15.6360
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: dwMHNPo3Iy9CKGTi21aP9ZYdFdfwSdh83i/pSWl4ORifGpXLjR35ymKTIKhKifkDHYepU+8w3sFVdtv37hVLzg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL3PR12MB6474
X-Spam-Status: No, score=-3.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,T_SCC_BODY_TEXT_LINE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 9/5/2022 4:56 PM, Christian König wrote:
>
>
> Am 05.09.22 um 12:56 schrieb Arvind Yadav:
>> Here's on debug adding an enable_signaling callback for the stub
>> fences and enabling software signaling for the stub fence which
>> is always signaled. This fence should enable software signaling
>> otherwise the AMD GPU scheduler will cause a GPU reset due to a
>> GPU scheduler cleanup activity timeout.
>>
>> Signed-off-by: Arvind Yadav <Arvind.Yadav@amd.com>
>> ---
>>   drivers/dma-buf/dma-fence.c | 17 +++++++++++++++++
>>   1 file changed, 17 insertions(+)
>>
>> diff --git a/drivers/dma-buf/dma-fence.c b/drivers/dma-buf/dma-fence.c
>> index 066400ed8841..0a67af945ef8 100644
>> --- a/drivers/dma-buf/dma-fence.c
>> +++ b/drivers/dma-buf/dma-fence.c
>> @@ -27,6 +27,10 @@ EXPORT_TRACEPOINT_SYMBOL(dma_fence_signaled);
>>   static DEFINE_SPINLOCK(dma_fence_stub_lock);
>>   static struct dma_fence dma_fence_stub;
>>   +#ifdef CONFIG_DEBUG_FS
>> +static bool __dma_fence_enable_signaling(struct dma_fence *fence);
>> +#endif
>> +
>>   /*
>>    * fence context counter: each execution context should have its own
>>    * fence context, this allows checking if fences belong to the same
>> @@ -116,9 +120,19 @@ static const char 
>> *dma_fence_stub_get_name(struct dma_fence *fence)
>>           return "stub";
>>   }
>>   +#ifdef CONFIG_DEBUG_FS
>> +static bool dma_fence_stub_enable_signaling(struct dma_fence *f)
>> +{
>> +    return true;
>> +}
>> +#endif
>
> Again, adding the callback is unnecessary.

sure, I will remove callback from here and other patch also.

~arvind

>
>> +
>>   static const struct dma_fence_ops dma_fence_stub_ops = {
>>       .get_driver_name = dma_fence_stub_get_name,
>>       .get_timeline_name = dma_fence_stub_get_name,
>> +#ifdef CONFIG_DEBUG_FS
>> +    .enable_signaling =  dma_fence_stub_enable_signaling,
>> +#endif
>>   };
>>     /**
>> @@ -136,6 +150,9 @@ struct dma_fence *dma_fence_get_stub(void)
>>                      &dma_fence_stub_ops,
>>                      &dma_fence_stub_lock,
>>                      0, 0);
>> +#ifdef CONFIG_DEBUG_FS
>> +        __dma_fence_enable_signaling(&dma_fence_stub);
>> +#endif
>>           dma_fence_signal_locked(&dma_fence_stub);
>>       }
>>       spin_unlock(&dma_fence_stub_lock);
>