Received: by 2002:a05:6358:bb9e:b0:b9:5105:a5b4 with SMTP id df30csp3233558rwb; Mon, 5 Sep 2022 08:21:04 -0700 (PDT) X-Google-Smtp-Source: AA6agR7fbboiGcnwjrVHgwRevJZBGipGwGx8vcCc5Ofe2mKIQSBol1BhLe80cWNTSRAqnB+xLL0c X-Received: by 2002:a17:907:2c5b:b0:741:6b8f:d3ab with SMTP id hf27-20020a1709072c5b00b007416b8fd3abmr27342246ejc.447.1662391264274; Mon, 05 Sep 2022 08:21:04 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1662391264; cv=none; d=google.com; s=arc-20160816; b=w+K3cawwMTRUMzeaE/vVQpCUXbMWW2EWqHWI7HTvM5dHVj1dDJKUZmo/fdLT3bpAW2 udUM0xDCJzOAQJX1GW2X3V7F3l2KB/ftIDrhF7UniDc10FTFSV3dhGWAZ13o8/bVVawy CcRhhnEoUdoTnH9fDcPW5yfuWNtnE4hxfS+2YrsK6VrhAb4nVrvPYm2hZb+2VpXBaJ0X v8C6VsRqhWFb8HCZfxYDsurmsODyLKZh7PN3E47gp/obdkgFpfMREOUyQ2EBU87q/VkZ BYMzFElMLV4wDYK3nMvZC39o8uHwBhEuyuSQ/H4wh5kZ734Po0siLQ+pXhgIXLXK0pJq Abdg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:in-reply-to:from :references:cc:to:content-language:subject:user-agent:mime-version :date:message-id:dkim-signature; bh=ZZQ9GYfaJkQB+/Kn5Z6HguQjwjTLgiTI72bIuD4h2cU=; b=OeOH5h0toJRr9OG1rZ/rSBJ5wG5i6oTLV0uoboeO7lQKbYcY4cS6xt36+qEGXDZ4/3 2i8J2ppITC3pTqpF3HGdKv0ShveN5BiSyQZnhprm61MXnT5mMW4vfxMzlnfy2EFYbnb3 bhQH6OQX55DN9Lo0NA7WMEJ8DVUQbmk6vAIwzpD1zB8yi4IMPlUlxUouJ/raUbbQiMpt MwCy4Kk/rZQbsW2t3yNvhtx/2I+woSAhOOQ2hQfGpQkc5eVyjP5UdrY/tvG8sH6hWfbH dreh6fMxTYwGbD9+CiG2FY/mOyHwtxhDAANX2M8kyzowc9yCxPDy83r2eV7UBrKOLs5C dTsA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=Sk2YEw3p; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id nd23-20020a170907629700b0073f2c8b20a6si4513760ejc.852.2022.09.05.08.20.36; Mon, 05 Sep 2022 08:21:04 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=Sk2YEw3p; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238404AbiIEPNn (ORCPT + 99 others); Mon, 5 Sep 2022 11:13:43 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37306 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236405AbiIEPNj (ORCPT ); Mon, 5 Sep 2022 11:13:39 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5394838B7 for ; Mon, 5 Sep 2022 08:13:37 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id E50E16131F for ; Mon, 5 Sep 2022 15:13:36 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 011AAC433C1; Mon, 5 Sep 2022 15:13:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1662390816; bh=i3QTbdMoweBqG6ifb88wDs67D5ImR67NR/mA5Nf1DUc=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=Sk2YEw3ptxgITGaaQsmqB9Yi0q7EhFfJvrGJgy75VonToOTi0hcz68F0YBcOzrVeI DCwl0HsDH6fXkXb18p1pJJ+YFukFnBkxDKyMB6XMPysw5n6X1A+gvmaKV1j9VN/uKt VyKMY4BO4j+pGHVBxSPv9+ss/tRbueCWNz8rTbEF1vhDYfsHkiksT6UbhokgamrkVy +6ZUYvyIE2ygAN5Rl1c8gn5pZ+Qe14K1ZG+73dp7jWZp0dTsrK2pWZlf/pJ5NGCqsf ImCBDdeXDedHzQkEMtZ9pP7EyzIzhrtMK4AV6TFTkjnRKZDBBIw1c1jiPa2/TsycPn TuePZeAYdvaoQ== Message-ID: <14ed6455-9678-fa32-aaf1-cc34f492d4ce@kernel.org> Date: Mon, 5 Sep 2022 23:13:36 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.13.0 Subject: Re: [PATCH] erofs: avoid the potentially wrong m_plen for big pcluster Content-Language: en-US To: Yue Hu , xiang@kernel.org Cc: linux-erofs@lists.ozlabs.org, linux-kernel@vger.kernel.org, huyue2@coolpad.com, zhangwen@coolpad.com References: <20220812060150.8510-1-huyue2@coolpad.com> From: Chao Yu In-Reply-To: <20220812060150.8510-1-huyue2@coolpad.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-8.8 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A, RCVD_IN_DNSWL_HI,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2022/8/12 14:01, Yue Hu wrote: > Actually, 'compressedlcs' stores compressed block count rather than > lcluster count. Therefore, the number of bits for shifting the count > should be 'LOG_BLOCK_SIZE' rather than 'lclusterbits' although current > lcluster size is 4K. The value of 'm_plen' will be wrong once we enable > the non 4K-sized lcluster. > > Signed-off-by: Yue Hu Reviewed-by: Chao Yu Thanks,