Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <66a173c5-553e-8788-7e9a-153382f1f9a5@nokia.com>
Date:   Mon, 5 Sep 2022 17:28:35 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.7.0
Subject: Re: [PATCH v2] ARM: kasan: Only map modules if CONFIG_KASAN_VMALLOC=n
Content-Language: en-US
To:     Linus Walleij <linus.walleij@linaro.org>
Cc:     kasan-dev@googlegroups.com,
        Lecopzer Chen <lecopzer.chen@mediatek.com>,
        Andrey Ryabinin <ryabinin.a.a@gmail.com>,
        Alexander Potapenko <glider@google.com>,
        Andrey Konovalov <andreyknvl@gmail.com>,
        Dmitry Vyukov <dvyukov@google.com>,
        Vincenzo Frascino <vincenzo.frascino@arm.com>,
        Russell King <linux@armlinux.org.uk>,
        linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org
References: <20220905122754.32590-1-alexander.sverdlin@nokia.com>
 <CACRpkdbdKAWfvpG2n-eJPagV3Sx1faaxC9cEFs3PTyDaxETwyQ@mail.gmail.com>
From:   Alexander Sverdlin <alexander.sverdlin@nokia.com>
In-Reply-To: <CACRpkdbdKAWfvpG2n-eJPagV3Sx1faaxC9cEFs3PTyDaxETwyQ@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?WktYQWhneG5tTWpBY3E2U1RwVjVac1E0L2JubmhrV3lNV3BzdFBjU0hwQ0Z5?=
 =?utf-8?B?TGdZODllUnRReW1Ddk04TlpCNjJIRWc5SkcyYkJKV1RLbU9UemxPbHUzVHdI?=
 =?utf-8?B?T3QxN0VTRUhrQ3RHRDR1RVZWODdSZS9pK0JBMnl0MG95OGkrbGxDeUZpZ0pF?=
 =?utf-8?B?TnpoUjQ4MjJLUCt3VEc0MXVIMUczRENldm9oVHVNUkpHclR5MC9yQ2xDYVUv?=
 =?utf-8?B?blErNkljQzVpRGVKRWtJc3QrZnVvWWZBY0lsVXV1eUVhVE9VVDlrMzZnSHc5?=
 =?utf-8?B?UGRHOTFpcEZMbzhUT3ZNbEdDZ053c1pqSmNlSXd1dXpCWis0UDRrSUQ2V3Zl?=
 =?utf-8?B?cHdISkJRaERsdlBWR1JUOGU2RFNXY1MxZzJYR0U1TWFSVUhJWDFENWplci81?=
 =?utf-8?B?UmhYbXZ1T3Rpb0d3SVNpUUJteE9rUk9OeGtKcUt3ZnpjbUtSYm1KV1Z4TlNv?=
 =?utf-8?B?Z1puVHNrbjBEZXVBUHVicjFuTXNHbTRqclZZQldQQ215T2dZWjBjQ1BsUGZ0?=
 =?utf-8?B?OEpZYUcvamVtZWMydHNPT2ZJNTNaTVdhaDZLRTdkSGs2dXVtbDdPczJEMTVa?=
 =?utf-8?B?bnRxL0JFZUd2WG9IbDVtYmZmZU5XbDNJNWpoc2MxYkhiTXNhWXF0WmdGOWlP?=
 =?utf-8?B?QitxSlI2OWRtcmpVa0RvQVZCV0hMZldDaDZPWW8waURlWlZUSENmVVpja0hN?=
 =?utf-8?B?cFByK0wyZzBQc1p6eVJUMnduV0FzM2NEdVYyN1BwTkx3OFpFUEVLNnFGZ1J2?=
 =?utf-8?B?UzlrTEZWdDg4TDc5ZmpQNndMdXM3bmdSUmdycThobUdIT2F3ZXVpU0Y2T05O?=
 =?utf-8?B?ZWEzbTV2UXY2ckNGYWdJWWNvTnRjRGFjdWZBODJ1STdZbk8zWk9pZUR0TFFU?=
 =?utf-8?B?amFNVEpjRHozRCt0aTU5QW51a2RlbCtnV28zZURDYkt0MGRxZGZGRFRLVE5l?=
 =?utf-8?B?d1pLUC9Va1BCT2dhMW1JQjNOVDVpaFQrWUY3dUwyL0ZrMlZWZXRHbmttOStt?=
 =?utf-8?B?NDBIV1pTSE1iN0VnelRSaU5ENWlBYk5RTEh3MXg3YUtZZmN3TDlzVWx0cGRx?=
 =?utf-8?B?ejAyeEN1RVdZTXUvN01WWExJSUc4c2lCUW41V2Ric1dtTkh6NFNUR0gyRG50?=
 =?utf-8?B?Z01YTU1wcEFCMWx0SSs5T0dFRU8rYnBEb2JjREZYVWw3cjFxVTU5SlRjSEw5?=
 =?utf-8?B?OUZNWDdxK1hlWHF5R1h6MEtPcjFhRkN3bE1JQS9mZGNROU9VWHAwcGltTUtN?=
 =?utf-8?B?V2dORzRhTkpKYTFWOEVmQ3pDM0wrcXo0Q1NFRkJvRDZBRThYL1FodkpyRGdx?=
 =?utf-8?B?TWVQd2pzZmlWRXR5L3FDT01UOVluN0lLRFgwTFl1b3c2YVpHamd3NlFSMzVy?=
 =?utf-8?B?am1RTnpWTDhRdEN0ZDN6MWs1NnZRM0N4dFpXZFFiN0I4d0xubFBoWHNrT3hn?=
 =?utf-8?B?OGkzWjBiejJya1BJaTVIRzlvZ04xUUxOQ0Q5bkFPN0lwaFRHc0tjYkdNWGdn?=
 =?utf-8?B?Y000eEVCVVdnbkNhZ0ZqL0ZESjFjQ2lhQzNGclZVbW4wYVczeVl3dlBKSElS?=
 =?utf-8?B?clpqemsweE5VWTZyc2lwcXVIL0ZNZDFTdG5zK2c3NWwwVk1PZ0l1K3lnM2x6?=
 =?utf-8?B?c2lsVXpjdis4SEdkQmt1dTYwVnJIbEc1WmNVakwwUi9tR056MVFVbGJnQktT?=
 =?utf-8?B?WUNvRzVYbkxlaXB4TDNSb1ZpUEZpKytkY2RuQ2dKV1VRTm9oMlpHdklsTDU5?=
 =?utf-8?B?cEdUMEo3MDRpRHFHczlIUnQyVStySjEyVnNHWXFBN1JGc0FPWHNJSEx0RHMr?=
 =?utf-8?B?ZWJ1ZHQyemVyZkF3OVBNeG9xOFRxUFIrK2hoWEFLem1XanduQXFrdUVWcVFi?=
 =?utf-8?B?TTNBQUdpc3hyWmpiYlI2ZlJsSVNhc3UxeklNTTVlQUtCa3hvYlkwanFBZ3ds?=
 =?utf-8?B?clJrVDJjY0FnbUVBczh6UXpoQ21XdWdGY1llZFVBUWNPQjJyL1JkclkzTXZI?=
 =?utf-8?B?OEYzMVplay9EQjhwSE9lR1NOWFNNNDhCTThoNkJJUUxxMnRLVElpRXVob01t?=
 =?utf-8?B?OFJWb25Mb0psbFg5YlZnSEtZT2gzUHV4OGRVbUxEQnZKWUhpWW02WnBxUGNa?=
 =?utf-8?B?Q095Y2NVRHg2OVZ0RCswQW1iVlk2clJHNks2SWZrNm0vTzMzRWFtWVg2Q0lo?=
 =?utf-8?B?Ync9PQ==?=
X-OriginatorOrg: nokia.com
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU0PR07MB9161
X-Spam-Status: No, score=-2.6 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,FORGED_SPF_HELO,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_NONE,T_SCC_BODY_TEXT_LINE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hello Linus,

On 05/09/2022 15:38, Linus Walleij wrote:
>> In case CONFIG_KASAN_VMALLOC=y kasan_populate_vmalloc() allocates the
>> shadow pages dynamically. But even worse is that kasan_release_vmalloc()
>> releases them, which is not compatible with create_mapping() of
>> MODULES_VADDR..MODULES_END range:
>>
>> BUG: Bad page state in process kworker/9:1  pfn:2068b

[...]

>>
>> Reviewed-by: Linus Walleij <linus.walleij@linaro.org>
>> Signed-off-by: Alexander Sverdlin <alexander.sverdlin@nokia.com>
> Thanks Alexander, will you submit this to Russell's patch tracker please?

done!

https://www.arm.linux.org.uk/developer/patches/viewpatch.php?id=9242/1

Thank you for the quick review!

-- 
Best regards,
Alexander Sverdlin.