Received: by 2002:a05:6358:bb9e:b0:b9:5105:a5b4 with SMTP id df30csp3306654rwb; Mon, 5 Sep 2022 09:23:47 -0700 (PDT) X-Google-Smtp-Source: AA6agR667s6nEXNpwLx2sFDrXTlPAIbdxUKWr1/a7CjSqm0WVy/bfCcxzdbf0tf/n5oqUWNcl858 X-Received: by 2002:a17:90b:3ec1:b0:1f5:15a6:aaf5 with SMTP id rm1-20020a17090b3ec100b001f515a6aaf5mr20456702pjb.123.1662395027603; Mon, 05 Sep 2022 09:23:47 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1662395027; cv=none; d=google.com; s=arc-20160816; b=ZULNlYHqf1cmIABWVXoeK/RMcgLyHlG47aea+UpXW5pntSxNLnwmALjoK/t9aTIzkt T+7nVsE2oQbsmLBcKyuR1MKtu10Xj2FStG1IhxxVQzYYL9X6eMNtibLXqwNoQdH1nXAi IOauKLatgisSh9h9rI4dei4P5fVANy1E5jcsiF0i+2li5wtLLQ7Qh8ZhcitV4APGhaSB pOdWt8du/6DRR8VPpCnf9cvJWZ2Yr+6/me+VJMuRvXNMA9WP7BVXILXaSSnCJqiwygOR j5ZCacaULSlKdyW3nvomg0CQwvTZKoVrTl9gWvfLvy+gsvgssLWmtn+TABvvQIrnkt1B OgcA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:in-reply-to:from :references:cc:to:content-language:subject:user-agent:mime-version :date:message-id:dkim-signature; bh=FPbrN98lR6/B+gtjfiEuygvrdAaJJ6vistTZKmQPgHw=; b=J6zS05e11iVyiWnBis41b8Xng9Pj+LwgIxrKbNGJOdr9uhrku3HNDZ0f11JuHSLUxI SnY6WEIpTapIX4SlSaG280QtP6F3iknSecIo+RjQTlSzU9zugTZCuUInAipM5pWQQbko dIqiey615MG4ZxWiMkfaBXRobj0HL/3qMyaYWh04jEtMskN6QQ2irlQxkSL3I+Hhu5By pll7vTu7tPEgsUzmufoSuWiFsuwVIVDzUhRn8g5cu8+9JiMw0wZ8JgCqtpBGFan24njs 3ii8NY2NWaSrMCPti+B2rRSznOvlWqptAc1KgWCuC1ADSSd+MmRwdixQdPvH62tIoYnq 9EZA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=exYKUhxT; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id a129-20020a624d87000000b0052ad5a71033si10737403pfb.91.2022.09.05.09.23.36; Mon, 05 Sep 2022 09:23:47 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=exYKUhxT; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238848AbiIEPMB (ORCPT + 99 others); Mon, 5 Sep 2022 11:12:01 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60030 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237542AbiIEPLi (ORCPT ); Mon, 5 Sep 2022 11:11:38 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E817B5E57A; Mon, 5 Sep 2022 08:10:41 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id DE367B811F5; Mon, 5 Sep 2022 15:10:39 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 494AAC433D7; Mon, 5 Sep 2022 15:10:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1662390638; bh=pmChB25I0/xOioQuvfxS4anHlEB/iWlW/oPqp/l37GY=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=exYKUhxTTuUxLlAx8IzrxsRZycm6/RCghmfrKnf2Y+jgggnhvGFRKOfDw938k0eN7 Ka4/6j2Tuj9Zt3Y7X48mHrSvXPQT9guosY4ssOdTs8TzsrlYLI3Nv0vyGfXCiff25g oGcKLVvtoTelM/rTwKUu8ympPdTQ2bUDucZKu/lUv0CpFG/t96Bpd0eBgBtqg4gCAO e9FM9ZW6Nw0N97ZcWZGujwsngRoxOZE4XkM26Vr7u4r1qfaD/sKHzGCn3D9ay7+Kck qjp+hPfCYI/J9b5M4VtpggZ4OO68EL+fS0AvERDajOWIHN2BUedv9uXH9fFqY8X3Ty rErhw2shs1pLw== Message-ID: Date: Mon, 5 Sep 2022 23:10:35 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.13.0 Subject: Re: [PATCH] erofs: fix error return code in erofs_fscache_meta_read_folio and erofs_fscache_read_folio Content-Language: en-US To: Sun Ke , xiang@kernel.org Cc: linux-erofs@lists.ozlabs.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org, yinxin.x@bytedance.com References: <20220815034829.3940803-1-sunke32@huawei.com> From: Chao Yu In-Reply-To: <20220815034829.3940803-1-sunke32@huawei.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-8.8 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A, RCVD_IN_DNSWL_HI,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2022/8/15 11:48, Sun Ke wrote: > If erofs_fscache_alloc_request fail and then goto out, it will return 0. > it should return a negative error code instead of 0. > > Fixes: d435d53228dd ("erofs: change to use asynchronous io for fscache readpage/readahead") > Signed-off-by: Sun Ke Reviewed-by: Chao Yu Thanks,