Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Mon, 5 Sep 2022 16:56:33 +0000
From:   Wei Liu <wei.liu@kernel.org>
To:     "Michael Kelley (LINUX)" <mikelley@microsoft.com>
Cc:     Zhou jie <zhoujie@nfschina.com>, KY Srinivasan <kys@microsoft.com>,
        Haiyang Zhang <haiyangz@microsoft.com>,
        Stephen Hemminger <sthemmin@microsoft.com>,
        "wei.liu@kernel.org" <wei.liu@kernel.org>,
        Dexuan Cui <decui@microsoft.com>,
        "linux-hyperv@vger.kernel.org" <linux-hyperv@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] hv/hv_kvp_daemon: remove unnecessary (void*) conversions
Message-ID: <20220905165633.ciwh7toc3ynd3n5i@liuwe-devbox-debian-v2>
References: <20220823034552.8596-1-zhoujie@nfschina.com>
 <SN6PR2101MB16931A789DA8673E9607F761D7729@SN6PR2101MB1693.namprd21.prod.outlook.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <SN6PR2101MB16931A789DA8673E9607F761D7729@SN6PR2101MB1693.namprd21.prod.outlook.com>
Precedence: bulk

On Thu, Aug 25, 2022 at 05:14:55PM +0000, Michael Kelley (LINUX) wrote:
> From: Zhou jie <zhoujie@nfschina.com> Sent: Monday, August 22, 2022 8:46 PM
> > 
> > remove unnecessary void* type casting.
> > 
> > Signed-off-by: Zhou jie <zhoujie@nfschina.com>
> > ---
> >  tools/hv/hv_kvp_daemon.c | 4 ++--
> >  1 file changed, 2 insertions(+), 2 deletions(-)
> > 
> > diff --git a/tools/hv/hv_kvp_daemon.c b/tools/hv/hv_kvp_daemon.c
> > index 1e6fd6ca513b..445abb53bf0d 100644
> > --- a/tools/hv/hv_kvp_daemon.c
> > +++ b/tools/hv/hv_kvp_daemon.c
> > @@ -772,11 +772,11 @@ static int kvp_process_ip_address(void *addrp,
> >  	const char *str;
> > 
> >  	if (family == AF_INET) {
> > -		addr = (struct sockaddr_in *)addrp;
> > +		addr = addrp;
> >  		str = inet_ntop(family, &addr->sin_addr, tmp, 50);
> >  		addr_length = INET_ADDRSTRLEN;
> >  	} else {
> > -		addr6 = (struct sockaddr_in6 *)addrp;
> > +		addr6 = addrp;
> >  		str = inet_ntop(family, &addr6->sin6_addr.s6_addr, tmp, 50);
> >  		addr_length = INET6_ADDRSTRLEN;
> >  	}
> > --
> > 2.18.2
> 
> The patch subject prefix for changes to this module is usually "tools: hv:"
> or "tools: hv: kvp:" and this patch should be consistent.  Check the commit
> log for tools/hv/hv_kvp_daemon.c for historical examples.
> 
> Modulo this tweak,
> 
> Reviewed-by: Michael Kelley <mikelley@microsoft.com>

I fixed the prefix and pushed this to hyperv-fixes.

Thanks,
Wei.