Received: by 2002:a05:6358:bb9e:b0:b9:5105:a5b4 with SMTP id df30csp3400843rwb; Mon, 5 Sep 2022 10:59:30 -0700 (PDT) X-Google-Smtp-Source: AA6agR70mDIaWHToR9zLA6ChXYziCcz72b7kN+w+MAKnWgFrvifFZnd7tJmpzZpQLmwHqZAvVKJ1 X-Received: by 2002:a05:6402:3509:b0:43e:d80b:44a8 with SMTP id b9-20020a056402350900b0043ed80b44a8mr45286138edd.255.1662400769630; Mon, 05 Sep 2022 10:59:29 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1662400769; cv=none; d=google.com; s=arc-20160816; b=CxnmMlkrucf8vfGPzpG6qY0gRXrNbU0Q8BX3ZjwGRTXbnhw3/7RiKrqU9CNYULUpqG bl4dXkImVloi3UrPjN2VwDXXyAHtZQYBex9+QyCceRI4UtgIIgR/DrPocWnMoqX9krJv I97EfCg4CxRbx/ZcP14Qr3MRFQh2Qrn9ig+8QrQXfKnLF1wiLzVhMX+hpPXAwP2hrgSS 51twzlMpojBEIfgKIwusBIVxor58M4MVq5LDxdrOXe0b7gT7kWEpQ/JmUz10sMnjmV+T cJ2uUz6AWPgcgxumTjXk6+rEAGtkTlvwRRDlmcLPKdReWOYqDxZZtBv/1jmjVOfRTeOC yjkQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version:date :message-id:subject:references:in-reply-to:cc:to:from:dkim-signature; bh=l5WWx8RZyWcG+xZCObFfX9BisZiIWLOPeZAIXutQksw=; b=JjUQsKLWC16bl/bwuUlyXUs1GsvZsxdJELsODxnZb/RN7K8l4MZePLH1adnV7NntUq RX17dmxihljux2+ujZenUBunVabupKrKjr4KaAhsmh+iC0/4RJH5W9Sa4eHVa7XFV1NW JFa4cm/of4LwoTs5l3glj+qQGUFb6ZRkHYNEdzbXeZzN4c7oMMRCxVy5+grOzfdHKMzU 4uz2itpIymP26kcNt9WI/KIdke9yHEwQAWruHiPxmkl8UlSxdDEvyxBQyb+T7rjZT9cv pO+SE+nvcuW4tPXHJrhuYIDaw+NvzJFX4jA2qhph/UhYpuTiN1v5F/DnZ+b63Jn4Cm3f Db3A== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=aY934ob2; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id y11-20020a056402358b00b0043df9ca3ff8si8963222edc.50.2022.09.05.10.58.46; Mon, 05 Sep 2022 10:59:29 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=aY934ob2; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231733AbiIERoa (ORCPT + 99 others); Mon, 5 Sep 2022 13:44:30 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48132 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231289AbiIERo1 (ORCPT ); Mon, 5 Sep 2022 13:44:27 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CFFE7302 for ; Mon, 5 Sep 2022 10:44:21 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 7884461451 for ; Mon, 5 Sep 2022 17:44:21 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id C19E8C433D6; Mon, 5 Sep 2022 17:44:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1662399860; bh=S0siCZf1fplDVdZQaH2EOINhg0VPl81P6I2vcDAk3Jw=; h=From:To:Cc:In-Reply-To:References:Subject:Date:From; b=aY934ob2giC8uRrh3q7gcCs6uiRCzelK43Kh8urk1UZFHy6f5hmf7NXs363jM4evY lj0trfKLu+AD91b2lNpA3p1/if9QhmI61LO2IDfDDMv8AYicDIqAIGCZ8KgZ2a+sqT 7xKq4RLfEmwauWev+UXVMMNez/cqgcTnl+TKyt3dk9aOnuPwhZzAAziSaAElAURpt3 ScNNXJs/IJUdNBuUkQ6nAwtq+f1yUc3etByvIqv6C/0P6xh/q0HlDYu/9k2QuJFh+s rEzKw6QdlewOCwZCcar2fnG00sKmXz07NxUjHPBSfm/v+H7Ellz/wBiIeMyjwLFr87 9bOD7+qfzXBgA== From: Mark Brown To: linux-kernel@vger.kernel.org, Dmitry Rokosov , Andy Shevchenko Cc: "Rafael J. Wysocki" , Greg Kroah-Hartman In-Reply-To: <20220901132336.33234-1-andriy.shevchenko@linux.intel.com> References: <20220901132336.33234-1-andriy.shevchenko@linux.intel.com> Subject: Re: [PATCH v1 1/3] regmap: trace: Remove useless check for NULL for bulk ops Message-Id: <166239985949.822508.8248374962835676727.b4-ty@kernel.org> Date: Mon, 05 Sep 2022 18:44:19 +0100 MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit X-Mailer: b4 0.10.0-dev-fc921 X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 1 Sep 2022 16:23:34 +0300, Andy Shevchenko wrote: > If the buffer pointer is NULL we already are in troubles since > regmap bulk API expects caller to provide valid parameters, > it dereferences that without any checks before we call for > traces. > > Moreover, the current code will print garbage in the case of > buffer is NULL and length is not 0. > > [...] Applied to https://git.kernel.org/pub/scm/linux/kernel/git/broonie/regmap.git for-next Thanks! [1/3] regmap: trace: Remove useless check for NULL for bulk ops commit: f78d5e1168e08429bc948d09b6dc11fec5e019f7 [2/3] regmap: trace: Remove explicit castings commit: d10268a50bdbc03ebb6d340d63bf78c44d7c66a8 [3/3] regmap: trace: Remove unneeded blank lines commit: 6ed406ef9f74372282c3b515e64986120823f769 All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted. You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed. If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced. Please add any relevant lists and maintainers to the CCs when replying to this mail. Thanks, Mark