Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <f550b468064c61e3550b50da37138802d7e9415a.camel@perches.com>
Subject: Re: [PATCH] checkpatch: warn for non-standard fixes tag style
From:   Joe Perches <joe@perches.com>
To:     Niklas =?ISO-8859-1?Q?S=F6derlund?= 
        <niklas.soderlund@corigine.com>
Cc:     Dwaipayan Ray <dwaipayanray1@gmail.com>,
        Lukas Bulwahn <lukas.bulwahn@gmail.com>,
        Jonathan Corbet <corbet@lwn.net>,
        Andy Whitcroft <apw@canonical.com>, linux-doc@vger.kernel.org,
        linux-kernel@vger.kernel.org, oss-drivers@corigine.com,
        Simon Horman <simon.horman@corigine.com>,
        Louis Peens <louis.peens@corigine.com>
Date:   Mon, 05 Sep 2022 11:00:35 -0700
In-Reply-To: <YxXUHPWtyrt6kNI1@sleipner.dyn.berto.se>
References: <20220829155358.2546732-1-niklas.soderlund@corigine.com>
         <dc45a7021bb765ea34c5b9228454f255764c7bc9.camel@perches.com>
         <YxXUHPWtyrt6kNI1@sleipner.dyn.berto.se>
Content-Type: text/plain; charset="ISO-8859-1"
Content-Transfer-Encoding: 8BIT
User-Agent: Evolution 3.44.4 (3.44.4-1.fc36) 
MIME-Version: 1.0
Precedence: bulk

On Mon, 2022-09-05 at 12:49 +0200, Niklas S?derlund wrote:
> Hi Joe,
> 
> Thanks for your feedback.
> 
> On 2022-08-29 23:06:43 -0400, Joe Perches wrote:
> > > +			if ($line =~ 
> > > /(fixes:)\s+([0-9a-f]{5,})\s+($balanced_parens)/i) {
> > 
> > Maybe use fixes:? so the colon is not required in poorly formed uses
> 
> I tried that but I think it brings more problems then it is worth. With 
> that change the check would run for each line of the commit message that 
> begins with the string 'fixes', not just in the tags section of the 
> message. So it would warn for the commit message,

I think it's not a problem.
Look at the results of:

$ git log -100000 --no-merges --format=email --grep="^fixes" -i | \
  grep -i -P -oh '^fixes:?\s*[0-9a-f]{5,}\s*..' | \
  sed -r -e 's/^(fixes:?\s*)[0-9a-f]+/\1/i' | \
  sort | uniq -c | sort -rn | head -20
  73974 Fixes:  ("
   1345 Fixes:  ('
    399 Fixes: 
    246 Fixes:  (A
    215 Fixes: ("
    172 Fixes:  (c
    121 Fixes:  (s
    114 Fixes:  (d
    110 Fixes:  (P
     98 Fixes:  (i
     90 Fixes:  (m
     86 Fixes:  (n
     78 Fixes: : 
     57 Fixes  ("
     51 Fixes:  "n
     47 Fixes:  (a
     46 Fixes:  (t
     43 fixes:  ("
     42 Fixes:  (p
     41 Fixes: ('