Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Mon, 5 Sep 2022 11:13:34 -0700
From:   Cong Wang <xiyou.wangcong@gmail.com>
To:     Zhengchao Shao <shaozhengchao@huawei.com>
Cc:     netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
        davem@davemloft.net, edumazet@google.com, kuba@kernel.org,
        pabeni@redhat.com, jhs@mojatatu.com, jiri@resnulli.us,
        vladbu@mellanox.com, weiyongjun1@huawei.com, yuehaibing@huawei.com
Subject: Re: [PATCH net,v2] net: sched: tbf: don't call qdisc_put() while
 holding tree lock
Message-ID: <YxY8ToCVWFSV6VqQ@pop-os.localdomain>
References: <20220826013930.340121-1-shaozhengchao@huawei.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20220826013930.340121-1-shaozhengchao@huawei.com>
Precedence: bulk

On Fri, Aug 26, 2022 at 09:39:30AM +0800, Zhengchao Shao wrote:
> The issue is the same to commit c2999f7fb05b ("net: sched: multiq: don't
> call qdisc_put() while holding tree lock"). Qdiscs call qdisc_put() while
> holding sch tree spinlock, which results sleeping-while-atomic BUG.
> 

Hm, did you see an actual warning here??

The commit you mentioned above is a classful Qdisc which accepts
user-specified child Qdisc, but TBF technically does not, I don't think
you can change its default fifo.

Thanks.