Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Mon, 5 Sep 2022 19:31:59 +0000
In-Reply-To: <20220905193516.846647-3-jiebin.sun@intel.com>
Mime-Version: 1.0
References: <20220902152243.479592-1-jiebin.sun@intel.com> <20220905193516.846647-1-jiebin.sun@intel.com>
 <20220905193516.846647-3-jiebin.sun@intel.com>
Message-ID: <20220905193159.eeu2xmqj6743kzxv@google.com>
Subject: Re: [PATCH v2 1/2] percpu: Add percpu_counter_add_local
From:   Shakeel Butt <shakeelb@google.com>
To:     Jiebin Sun <jiebin.sun@intel.com>
Cc:     akpm@linux-foundation.org, vasily.averin@linux.dev,
        dennis@kernel.org, tj@kernel.org, cl@linux.com,
        ebiederm@xmission.com, legion@kernel.org, manfred@colorfullife.com,
        alexander.mikhalitsyn@virtuozzo.com, linux-mm@kvack.org,
        linux-kernel@vger.kernel.org, tim.c.chen@intel.com,
        feng.tang@intel.com, ying.huang@intel.com, tianyou.li@intel.com,
        wangyang.guo@intel.com
Content-Type: text/plain; charset="us-ascii"
Precedence: bulk

On Tue, Sep 06, 2022 at 03:35:16AM +0800, Jiebin Sun wrote:
> Add percpu_counter_add_local for only updating local counter
> without aggregating to global counter.

Please add why do we need this. Who should use this and who shouldn't.

> 
> Signed-off-by: Jiebin Sun <jiebin.sun@intel.com>

[...]

> diff --git a/lib/percpu_counter.c b/lib/percpu_counter.c
> index ed610b75dc32..d33cb750962a 100644
> --- a/lib/percpu_counter.c
> +++ b/lib/percpu_counter.c
> @@ -72,6 +72,12 @@ void percpu_counter_set(struct percpu_counter *fbc, s64 amount)
>  }
>  EXPORT_SYMBOL(percpu_counter_set);
>

Add a doc comment here on why someone want to use this?

> +void percpu_counter_add_local(struct percpu_counter *fbc, s64 amount)
> +{
> +	this_cpu_add(*fbc->counters, amount);
> +}
> +EXPORT_SYMBOL(percpu_counter_add_local);
> +
>  /*
>   * This function is both preempt and irq safe. The former is due to explicit
>   * preemption disable. The latter is guaranteed by the fact that the slow path
> -- 
> 2.31.1
>