Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Sender: Guenter Roeck <groeck7@gmail.com>
Date:   Mon, 5 Sep 2022 15:10:37 -0700
From:   Guenter Roeck <linux@roeck-us.net>
To:     Alexandru Gagniuc <mr.nuke.me@gmail.com>
Cc:     linux-hwmon@vger.kernel.org, robert.marko@sartura.hr,
        luka.perkov@sartura.hr, jdelvare@suse.com, dev@aboehler.at,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/3] hwmon: (tps23861) fix byte order in resistance
 register
Message-ID: <20220905221037.GA3694440@roeck-us.net>
References: <20220905142806.110598-1-mr.nuke.me@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20220905142806.110598-1-mr.nuke.me@gmail.com>
Precedence: bulk

On Mon, Sep 05, 2022 at 09:28:04AM -0500, Alexandru Gagniuc wrote:
> The tps23861 registers are little-endian, and regmap_read_bulk() does
> not do byte order conversion. On BE machines, the bytes were swapped,
> and the interpretation of the resistance value was incorrect.
> 
> To make it work on both big and little-endian machines, use
> le16_to_cpu() to convert the resitance register to host byte order.
> 
> Signed-off-by: Alexandru Gagniuc <mr.nuke.me@gmail.com>

Applied.

Thanks,
Guenter

> ---
>  drivers/hwmon/tps23861.c | 10 ++++++----
>  1 file changed, 6 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/hwmon/tps23861.c b/drivers/hwmon/tps23861.c
> index 42762e87b014..f7c59ff7ae8e 100644
> --- a/drivers/hwmon/tps23861.c
> +++ b/drivers/hwmon/tps23861.c
> @@ -493,18 +493,20 @@ static char *tps23861_port_poe_plus_status(struct tps23861_data *data, int port)
>  
>  static int tps23861_port_resistance(struct tps23861_data *data, int port)
>  {
> -	u16 regval;
> +	unsigned int raw_val;
> +	__le16 regval;
>  
>  	regmap_bulk_read(data->regmap,
>  			 PORT_1_RESISTANCE_LSB + PORT_N_RESISTANCE_LSB_OFFSET * (port - 1),
>  			 &regval,
>  			 2);
>  
> -	switch (FIELD_GET(PORT_RESISTANCE_RSN_MASK, regval)) {
> +	raw_val = le16_to_cpu(regval);
> +	switch (FIELD_GET(PORT_RESISTANCE_RSN_MASK, raw_val)) {
>  	case PORT_RESISTANCE_RSN_OTHER:
> -		return (FIELD_GET(PORT_RESISTANCE_MASK, regval) * RESISTANCE_LSB) / 10000;
> +		return (FIELD_GET(PORT_RESISTANCE_MASK, raw_val) * RESISTANCE_LSB) / 10000;
>  	case PORT_RESISTANCE_RSN_LOW:
> -		return (FIELD_GET(PORT_RESISTANCE_MASK, regval) * RESISTANCE_LSB_LOW) / 10000;
> +		return (FIELD_GET(PORT_RESISTANCE_MASK, raw_val) * RESISTANCE_LSB_LOW) / 10000;
>  	case PORT_RESISTANCE_RSN_SHORT:
>  	case PORT_RESISTANCE_RSN_OPEN:
>  	default: