Received: by 2002:a05:6358:bb9e:b0:b9:5105:a5b4 with SMTP id df30csp3636152rwb; Mon, 5 Sep 2022 15:52:31 -0700 (PDT) X-Google-Smtp-Source: AA6agR6bSJ/bo++0m6NYhOJReH1orQKEtfRpvdXySIzIUQT65enJ+b7HV0D/vttPTax2Ldd6amG/ X-Received: by 2002:a17:907:3f98:b0:730:cfce:9c0f with SMTP id hr24-20020a1709073f9800b00730cfce9c0fmr37968581ejc.475.1662418351264; Mon, 05 Sep 2022 15:52:31 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1662418351; cv=none; d=google.com; s=arc-20160816; b=fPHYxyN7U0aLVAJNlFHRGHqQMQ70Gj01u1kNI2VwUmJFOKFB0J7ulh3fPYWZYaDpid 0K6aeq1Mrl0NziVJ1Zfcbf+KQNk3KwKZ//HEG6TpeXYM+Sgan5sB4pZS7jV6D1ZsDn0k fddDOPPQNraeKfzANtPMEpd/oounRls718GYBf6dk7AInww4cQ5HBCzmcXhAN0R4CRXm +KPhKBct5KS17kAgpnSumFWA+2r45dgNLu1Z2/unzwmdvHBy0B3DGwkgj/DKPjcw6s/K TpfIKKLBa0YdGq4RA1uRW/wEBx3Gr9g92/rCu1uT256fdK+jHS41SlSAPQV84+4G93jf deUA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:message-id:user-agent :references:in-reply-to:subject:cc:to:from:date:mime-version :dkim-signature; bh=dOe8jPTKzzR6NB+CPpTCTcs7fzAc/wUD0hvNTkIAjx4=; b=BFxvotywgYyME66ou4APMut+9EZAPl3mm0FOTC1P0ZATSpG/0u7MPm1paw0CU39LKj Po7GgrU6dvU9janMC3gQA305v2YW/sTHl1LL2XD4e0rE30p597imQqf9456cERrSJ8lM bAd27k8SmDzOuIIlj8W9mcs6VdISYoFBifphZ6PNH24sj32J1/T/3sW6ERUIquPIItdv ++1aNzqHxsFgkbSINUfUlhic52jB8hPBKAqdk1DKuAk9FcP2PIFdzeN7pQwUXN2caoIm v9U6Q+BjNRKtvCOUPm/33NZ4/SL16f0fWV0z+JHBQbctqN3zFLxVLAdamTRtOC6hpGBl bsug== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@walle.cc header.s=mail2022082101 header.b=l0wd3KRn; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=walle.cc Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id hr28-20020a1709073f9c00b00730c1868d6bsi619156ejc.90.2022.09.05.15.52.05; Mon, 05 Sep 2022 15:52:31 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@walle.cc header.s=mail2022082101 header.b=l0wd3KRn; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=walle.cc Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231682AbiIEWYs (ORCPT + 99 others); Mon, 5 Sep 2022 18:24:48 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46436 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229453AbiIEWYq (ORCPT ); Mon, 5 Sep 2022 18:24:46 -0400 Received: from mail.3ffe.de (0001.3ffe.de [159.69.201.130]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D762D12638 for ; Mon, 5 Sep 2022 15:24:45 -0700 (PDT) Received: from 3ffe.de (0001.3ffe.de [IPv6:2a01:4f8:c0c:9d57::1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mail.3ffe.de (Postfix) with ESMTPSA id A29BA1272; Tue, 6 Sep 2022 00:24:43 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=walle.cc; s=mail2022082101; t=1662416683; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=dOe8jPTKzzR6NB+CPpTCTcs7fzAc/wUD0hvNTkIAjx4=; b=l0wd3KRnAaq/djXMKKkNH0O5+fxVQbAM6isQbfJx02bKb6H0WWeNycly19Qra7IDqGGXSo 5rpDuiHuzKsJdHvJ9h4c/0MPrOh+0X9JjDSeh9FR6MvufA1Fujt9J47vmKi5wmpClqGd6b VXCRDtAXZdlYgHzWwkj0KspGAJsPrlR6zg1iDdWifJHtPcITABg/aXwsA4OCDGjkVr9PFh uAN0qQ8zIqhPne35J5lLounzVAwPD6QGg7G2/vm61AqAzYOco8nQapVgcMm/xqJwVaj+Lw aoKhNlGJBP+YYv790DyaB3gL9jmtwkUtfc41T4YYey+na7PkHmKH2GD5ueu5wQ== MIME-Version: 1.0 Date: Tue, 06 Sep 2022 00:24:43 +0200 From: Michael Walle To: Andy Shevchenko Cc: Linus Walleij , linux-arm-kernel@lists.infradead.org, linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, Lars Povlsen , Steen Hegelund , UNGLinuxDriver@microchip.com Subject: Re: [PATCH v1 1/1] pinctr: microchip-sgpio: Correct the fwnode_irq_get() return value check In-Reply-To: <20220905190849.73194-1-andriy.shevchenko@linux.intel.com> References: <20220905190849.73194-1-andriy.shevchenko@linux.intel.com> User-Agent: Roundcube Webmail/1.4.13 Message-ID: <21f2241f19003a1210bd475883ee077b@walle.cc> X-Sender: michael@walle.cc Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE,SPF_PASS, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Am 2022-09-05 21:08, schrieb Andy Shevchenko: > fwnode_irq_get() may return all possible signed values, such as Linux > error code. Fix the code to handle this properly. > > Fixes: be2dc859abd4 ("pinctrl: pinctrl-microchip-sgpio: Add irq > support (for sparx5)") > Signed-off-by: Andy Shevchenko Reviewed-by: Michael Walle Btw. do we care about EPROBE_DEFER? -michael