Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <4f265843-bac1-944c-8119-aa4c1689c8e5@intel.com>
Date:   Tue, 6 Sep 2022 08:24:16 +0800
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Firefox/91.0 Thunderbird/91.13.0
Subject: Re: [PATCH] mm: Check writable zero page in page table check
Content-Language: en-US
To:     "Edgecombe, Rick P" <rick.p.edgecombe@intel.com>,
        "akpm@linux-foundation.org" <akpm@linux-foundation.org>,
        "linux-mm@kvack.org" <linux-mm@kvack.org>,
        "pasha.tatashin@soleen.com" <pasha.tatashin@soleen.com>
CC:     "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
References: <20220902232732.12358-1-rick.p.edgecombe@intel.com>
 <3d82deb6-357d-0b54-ffd1-dce157674aad@intel.com>
 <467b0cdb4f876b87b50d1cd7229a8e6e02a19a41.camel@intel.com>
From:   "Huang, Shaoqin" <shaoqin.huang@intel.com>
In-Reply-To: <467b0cdb4f876b87b50d1cd7229a8e6e02a19a41.camel@intel.com>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?dGJCQkRCTlVXU0JiMnIwclBFY1l5RHpYcmFVSys1cVBhSFlQdUQ0N001OTRY?=
 =?utf-8?B?dzVhdlNJQlhsWnpCV1g5bkhjN2FOQUtvUDQ4V2laNjdaV25DSjNmdEs3SlRJ?=
 =?utf-8?B?TEpwcnpCc3ZOWC9HS1E5L1pleFBvaDlGaFk0WUdqQjAvSkV0MCtWQXNFcHBk?=
 =?utf-8?B?RXI4QXVvYm1DSXJzKzEzZkNrVzQza1BFSHY4MzFWRjY2U1RWT2JDeWxkazNi?=
 =?utf-8?B?MHljNFBHRlBnVkhUQzUzcnFQUkM3d3lxUkhmbGM4YjNpWjFmQkdMWE8vS2hZ?=
 =?utf-8?B?L2wwcStGMk05NUdBTnUzVmphWGpQV3kxbHZNVUNFcE5nNkd4a2dnL0hvc3Vz?=
 =?utf-8?B?aHNmMzRQNm5MdE1ORmVRdHc5NDVhQVdqOGhrL1dJWXR3VFdwS1dqd0o3bjhP?=
 =?utf-8?B?bjRVc09WelFRelVGU2pYNnUyUWZWZ3FIeXpTcUJOczNiMmU2bENpT3pmakFa?=
 =?utf-8?B?WmJxSEFieVNSOTVSVnk1M0VocklTenJXQ1p1R1QvNEZFMGZZdFdJY1Q0L1hw?=
 =?utf-8?B?RVBBMkloV3p4bkkzWVZ2V0I5ajVoT1BKekthaEJFbGg0ZG9Ga1ByMk9DVnA5?=
 =?utf-8?B?OU1yNjIyNjl1SytvcWJpSlZxZnFleHRLME9INkZiNkZVNzU4NDRFcGkxSmsw?=
 =?utf-8?B?QTFxeWZXcFdCZjViS0hiNnhXTW1IUFBWQ0lqOXJPZXBCWkNqUTZsK0Zxa0hQ?=
 =?utf-8?B?dVh4RnJpcm4reW1ZUWJSM0pSMXlKL3A0TGdkNVlteUtCdmQzQWxvRk03UVo1?=
 =?utf-8?B?MkVNbHFyekoxTnlBcWU4WURYMnVFUzJnajJzZnY0T2tIMXpmVGxrYmt5a1dW?=
 =?utf-8?B?c3J6YTNaTm5NUnpBbU1hdDVsWXpmQ2dPampUVTlxU1V3OXBIejlDNmNIQlFF?=
 =?utf-8?B?QWs5RUd5bDBTcW5GQURGVUxRQUdqcUE5MmY0VlZhLzRYSHV1RlVpeitLOWN6?=
 =?utf-8?B?SzZRMXp2cHBrWlpZMk1laFBkbktINnB6ZVhGU2N4UnpZVmdDdjBMd0JVa0lu?=
 =?utf-8?B?TjJGMW81aGlLRm02UXBaQjBIOEVzV1V1RlArd09PMWdTVUpCbVZSa0ZXS0di?=
 =?utf-8?B?Ny9QSEl0dWk0THdMdEQ2ZnhRaWlHYmJTMFM4ZzlZZExRL3JGTmRrWTc3T3Bt?=
 =?utf-8?B?cXNsTkdlczU1bWJYUW1HVytVbEU2SEIzY0F5QzF0WVg0eTJLWEMxUWhtTHlv?=
 =?utf-8?B?MndTbnY3TmNGNU9SSE9zN2l4OW0yR1V6MzIvK0tQV3FSb2huWHhKckFXYkdF?=
 =?utf-8?B?UnA1bXllNkZoeGpjKzZFZnRCbEtwZ3QxaGJDWUkreWp0MFhCQnhNM3lNdmh4?=
 =?utf-8?B?RVpOR0NDVG03RmlKbHlKWitQekFJVWtxQ2Y4MDQvOVM2bkVGbVZPajlZQ1N0?=
 =?utf-8?B?STJFT1l1Qy8yQ0NwNUJVb0p4MjBBc3dFTTBveEFRMmIrVW5GYUJpYXhNdTRs?=
 =?utf-8?B?ajBSSWg1L3JBTE1QSmFmQmJPNnpoRXdLeGFFRjZyVEhxOUdUWU90T28weEpU?=
 =?utf-8?B?NjFzWGhpTGVhTVp1L1ZLRk9FTGVGMlJRZnJPL1JoclRzS2RYdXNRSFdqcldr?=
 =?utf-8?B?aC91Z1Rkc2hYalhYY0V3MThWU1o3MTgyc3R4MUZqZ1VqUkYwWUZublBnMkZT?=
 =?utf-8?B?Ykt0bHR6anJUd0Q4cnh5cUpYRmEyZDdGeDhxd0RzemVxOFNtcjk3WmQvNVA1?=
 =?utf-8?B?SzV1UDY0c3p3aGQ2cGhva29nQXdEUWIxMG1DMmpnWllnS2t6OC9wNWNyeDZo?=
 =?utf-8?B?TXd2bE81T0lyMFhIYVQ1RndOY2pNWDV6cEtudERaM2cwUVE5U0gvb0xCVnMv?=
 =?utf-8?B?TGswRFI3Z2lJQjZYZ1Mrai8yK2JOV0lUbEQwb0NmQ2hpQWxNV3BGb0Z4WjNs?=
 =?utf-8?B?ZXhIZ3Y4cWFQWmw5UllyejhCSE9ZMVRHQXVwK2ZNZTZQQ01CV2tSRFZYeGxZ?=
 =?utf-8?B?ZGlXWmQvMjdzelpCMllrWUpVQUFLNlNad0lSQjN4LzVKcXorUzA4UXVrYTgz?=
 =?utf-8?B?YnRLcGo5ZzhmRG5oUkVkbnBsQmFjNHZIQmwya1htUlhWa2l4L0p5UjZJQ0NB?=
 =?utf-8?B?YlpiR013SE1HZFl3Q1FCc2VTeGxIZGxuOVdRcW1oVHMzalJjMTFqQnNDeVd1?=
 =?utf-8?B?QU9UYXdhVytzZ1Rmand1Z2Q3dWtNUmtKeXRsSTNla1UyRytsb1k1eXFXWFk0?=
 =?utf-8?B?c2c9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: ef83d06e-5c19-4f9e-17e5-08da8f9e27d4
X-MS-Exchange-CrossTenant-AuthSource: MN2PR11MB3870.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Sep 2022 00:24:26.3724
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: i0DjaPBhF7K1ADjRWhEZObLEiMojij93VuJLdWJj4Zlpi9lWBt83zI2PZX7grng6pZxuv1G3rnvG4s0SUv54rw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL1PR11MB5463
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-6.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,
        RCVD_IN_DNSWL_MED,RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,
        SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no
        version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 9/6/2022 2:50 AM, Edgecombe, Rick P wrote:
> On Sat, 2022-09-03 at 10:13 +0800, Huang, Shaoqin wrote:
>>> +     BUG_ON(is_zero_pfn(pfn) && rw);
>>> +
>>
>> Why we need use BUG_ON() here? Based on [1], we should avoid to use
>> the
>> BUG_ON() due to it will panic the machine.
>>
>> [1]:
>> https://lore.kernel.org/lkml/20220824163100.224449-1-david@redhat.com/
> 
> Yea, you are probably right. All the rest of this checker uses BUG_ON()
> though. Maybe they should all be something else? Just felt weird to
> have this be the only check that is different.
> 
> I don't have any objections to changing it to WARN_ON(). Should I
> switch the rest of the checks here while I'm at it?

Yes. I think in most situation, WARN_ON() or WARN_ON_ONCE() is ok.