Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <1c05b986-e8bb-2ec1-7c81-06b7cfe50f94@nvidia.com>
Date:   Mon, 5 Sep 2022 17:49:23 -0700
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.2.0
Subject: Re: [PATCH] mm: Check writable zero page in page table check
Content-Language: en-US
To:     "Huang, Shaoqin" <shaoqin.huang@intel.com>,
        "Edgecombe, Rick P" <rick.p.edgecombe@intel.com>,
        "akpm@linux-foundation.org" <akpm@linux-foundation.org>,
        "linux-mm@kvack.org" <linux-mm@kvack.org>,
        "pasha.tatashin@soleen.com" <pasha.tatashin@soleen.com>
Cc:     "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
References: <20220902232732.12358-1-rick.p.edgecombe@intel.com>
 <3d82deb6-357d-0b54-ffd1-dce157674aad@intel.com>
 <467b0cdb4f876b87b50d1cd7229a8e6e02a19a41.camel@intel.com>
 <4f265843-bac1-944c-8119-aa4c1689c8e5@intel.com>
From:   John Hubbard <jhubbard@nvidia.com>
In-Reply-To: <4f265843-bac1-944c-8119-aa4c1689c8e5@intel.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?TjNLdEM2c0FvMGJ6eiszNVZwaXl2MFZWSTRwR3RRbEFLQXdJak1acThyL1Bj?=
 =?utf-8?B?akFodm5mbFBCT1A0U0Z4cGRzTjNsZHhTT1o5bWtuYWxQNERtL05lRE9wWjE3?=
 =?utf-8?B?ZjZjRjd5OGthcmlzQTF5NEQ5YXpFZmw1SUZpOHQ1ZFI5dEdwaHdvU3M4NUdG?=
 =?utf-8?B?VkhIOVNkMWY4NTBvZWFVMS9SaENQR2R4R2tUNlBTVk5vR0N4QXpidDRvTnk1?=
 =?utf-8?B?Um45OGcrNVVhZ3hCM2VSb1ZWek9PVFJlTHQvZVVKbEFkUHZlZk1McnN4K0dU?=
 =?utf-8?B?RzZJdWV0VERWNHNkNkYzWGJWKzZ2RW9GcE1TRmpiQnJGb1pQa09RVVdTMXNR?=
 =?utf-8?B?Q0JiclUxUThJSnA4d2NjMlZrdHBpUmYwNVhZYlBUSEdaRG9tNE9jek8yN1oy?=
 =?utf-8?B?UnlPaTgrbmtUVGQ3dUhXZXgyTDhBSThQalFqQTlFNldMNEIwdk1GTTRhTmRi?=
 =?utf-8?B?TTF1WVJLaWNSSlViUGtpTjdXQjcxRmhOZUxac2RSV3drZTFoWVhSZDY0dU5a?=
 =?utf-8?B?LzhQeHFQQ2t5aCtFNEl6UmFnWjhaOW95WTBmWVFqWVp2eFMrQm1LQnQ3cy8x?=
 =?utf-8?B?c0hnYlBBVHd1ekkyOCtxa05HVlJqRElkc2M5ODhUTU0yK0tMVnlKSy9WN3Yw?=
 =?utf-8?B?cFAzeXFUT04rVUxyNklYeEQzdGlOZlgrOTloTFZaby9ScmNJODVtVlhaNXph?=
 =?utf-8?B?b0xEY09CZTlLTlJzT3I4RSt6aVZpdkU1b25mWllxZWRId3pyeEhYL05zSFpH?=
 =?utf-8?B?QWtsVHdaYUlSS2UxNk41OFUzQUltMkVydjQzNnlsd0ljemRlTDM4N3BYWWxN?=
 =?utf-8?B?UkpBTTFjL0lDdHJvSTQxY0NZWVBIN3JFUHZMUUxlMktjRytqNkVWNGlXVFlx?=
 =?utf-8?B?RWY4S25xcU9Ma29lVExQS2Z5amRMOXFpVzJjY0o4TXg3ZGFRZVFPR2JYZzA4?=
 =?utf-8?B?VVo2Mi9nYTFnTkQ1ejV5SWJoTmw3cGdSNHJmTXJwTC9QSEp3VWlDbWE4RUdp?=
 =?utf-8?B?THI3bkV5czJYeXczQ1MwVUt0RjA1YWsrZDVKWU40SkpEaXJjTCthbHV2VjZw?=
 =?utf-8?B?ZUpjSTJ5ckVVQjJVNVQyd24vY2VhSzM5SlcxYzEycy81Um5YeForZEtmNDNx?=
 =?utf-8?B?d0o5RWV2MnNvY3pMcjFnc1p2TFNtY1J0RVRTdDlOS0hGdTVLUHE0NWZPQ3Z6?=
 =?utf-8?B?d2xXb1VYU0YvMXc0YlJBdkUrRVJLaGNxOVBQdmdzcmlnS3I1T2wvbkUxU21Y?=
 =?utf-8?B?OEdidThZbDRyUWxQM0REdURkekM2SEV3eXRKaGUxTUNIR1laZ0xzM0FmU2dw?=
 =?utf-8?B?b1VVb1VRMjVjYnJITjkxUWJLUktYL09taXB6eFpQQ2RxQXdOTzV1Um43aXUw?=
 =?utf-8?B?aDNOTkFHWlJjK0FocW82aU1NNUJWYmZPejJWTm1qK3hVYnNoN1pPM0s2bHJY?=
 =?utf-8?B?UGl1Tm5sNEkxZmQ0Q2VIQS9PbitSQXBNR01JODNQVjVKdFBkSGx0MkVmVU5j?=
 =?utf-8?B?QmtFVDR0MldJNXNIU1N5M2pXU2pVbVZZa3VES0UzWU9TUGdqNjNmcGRoSkUw?=
 =?utf-8?B?c1RLNTVROVhCOGc1Y2dpd25UMGZ4ZnVRQWVlbndzL2o1VjlDdHlBUzlKaXJZ?=
 =?utf-8?B?QUpPVHFCWXA5NGlVbUplc2hseHI0ZmJzZnVObzhwTlNKZkFoV2dTSTZ0QjJW?=
 =?utf-8?B?bldVR3lQSW16emZleVhycFIya2hKZk9KK0gyVXZqMW9KNHNJeFBZSUpoOUhY?=
 =?utf-8?B?Q2R2emljbHFFc0l1REtkM2ZkWm9Dbk9DMzZ5SkU2TVYwQS96UEJDTTFlRUYv?=
 =?utf-8?B?ODhxWmt0U1RnNm90UldJck04ck5tc1JhZXFaNnRSNWFiZXYyMk15TjVtQ1JU?=
 =?utf-8?B?Qzhoa04rN2hFVFN4OWhheHhoT3FGZENpbHZmZjcybE9NNUJMcnVUWW10SE9a?=
 =?utf-8?B?UU13Q044dHJDOC9wTzI3NlpqSlhFNzA4TUxVc3dvQVQ0UHF5VTNuUDRUS01k?=
 =?utf-8?B?ZSt5ejZmRmNLL3gzZ3praWpqeU9Lc0ZEMlR2VWtSQkZpTjQwZmdva2ZqQy9l?=
 =?utf-8?B?Y0J2WGp4ZVFtYXUzaGd6RWJEV0kwYVJZUjN1Y1ZvYmx6NTNlaWVaeHY3OVlI?=
 =?utf-8?B?NGV5QWQxekhmSytLTWw0QWxlOWdHd3FPV1A2dnJ4VzdvTFJDVGM5bTc3UG84?=
 =?utf-8?B?NUE9PQ==?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: bfb65178-bcb8-41ae-c5f0-08da8fa1a56f
X-MS-Exchange-CrossTenant-AuthSource: BY5PR12MB4130.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Sep 2022 00:49:25.5668
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 2wiFtYBI36Mpmp+VYCBhkdtVftbIVu5ORcR6Olz6AwV2vSeUCJUMfioCDjzQxQsSF1XxyTxw6eWjOQS+AnoZjg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY5PR12MB5015
X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FORGED_SPF_HELO,
        NICE_REPLY_A,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,
        SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no
        version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 9/5/22 17:24, Huang, Shaoqin wrote:
> 
> 
> On 9/6/2022 2:50 AM, Edgecombe, Rick P wrote:
>> On Sat, 2022-09-03 at 10:13 +0800, Huang, Shaoqin wrote:
>>>> +     BUG_ON(is_zero_pfn(pfn) && rw);
>>>> +
>>>
>>> Why we need use BUG_ON() here? Based on [1], we should avoid to use
>>> the
>>> BUG_ON() due to it will panic the machine.
>>>
>>> [1]:
>>> https://lore.kernel.org/lkml/20220824163100.224449-1-david@redhat.com/
>>
>> Yea, you are probably right. All the rest of this checker uses BUG_ON()
>> though. Maybe they should all be something else? Just felt weird to
>> have this be the only check that is different.
>>
>> I don't have any objections to changing it to WARN_ON(). Should I
>> switch the rest of the checks here while I'm at it?
> 
> Yes. I think in most situation, WARN_ON() or WARN_ON_ONCE() is ok.
> 

+1 for WARN_ON_ONCE(), and also for changing the other cases as you find
them, yes.


thanks,

-- 
John Hubbard
NVIDIA