Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Jacky Bai <ping.bai@nxp.com>
To:     Francesco Dolcini <francesco.dolcini@toradex.com>,
        "linux-gpio@vger.kernel.org" <linux-gpio@vger.kernel.org>
CC:     Francesco Dolcini <francesco.dolcini@toradex.com>,
        Aisheng Dong <aisheng.dong@nxp.com>,
        Fabio Estevam <festevam@gmail.com>,
        Shawn Guo <shawnguo@kernel.org>,
        Pengutronix Kernel Team <kernel@pengutronix.de>,
        Linus Walleij <linus.walleij@linaro.org>,
        Peng Fan <peng.fan@nxp.com>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        Arnd Bergmann <arnd@arndb.de>,
        kernel test robot <lkp@intel.com>
Subject: RE: [PATCH] pinctrl: imx8m: kconfig: Fix build error on test compile
Thread-Topic: [PATCH] pinctrl: imx8m: kconfig: Fix build error on test compile
Thread-Index: AQHYwXkGSXqbDG3mdkqwLumVr+JmKa3RlgEQ
Date:   Tue, 6 Sep 2022 01:16:30 +0000
Message-ID: <DB9PR04MB8412C5E5640C8119FC5FD742877E9@DB9PR04MB8412.eurprd04.prod.outlook.com>
References: <20220905224408.346425-1-francesco.dolcini@toradex.com>
In-Reply-To: <20220905224408.346425-1-francesco.dolcini@toradex.com>
Accept-Language: zh-CN, en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?pZeNHvRm6qOKKC5f0M1Di/kS3b7oPoyi4IYB13nEpEjbv0JJpfOGxmAVRXwv?=
 =?us-ascii?Q?jCj92X5glQcBdNQuMejsBAIaFVn/H93X5CDRggd8YGpnE2QJDeSki7/J6eoe?=
 =?us-ascii?Q?vz0cJaeYGkE1P2CZPcokejDC6P5HCQZR3opinC/4U/lENjTZL5l0km+7nQ7c?=
 =?us-ascii?Q?qI9LCHj8V8UU/l/w1Rfint2X6cFonA2JlXEGUb1RLQJJZwcKcHrabJVrLysq?=
 =?us-ascii?Q?3FC0CqzOXxUyXYIoBNKiVx5QQ4z4lgyD2X63218W/vylE4yU7dVBTGwSSKJc?=
 =?us-ascii?Q?tUZNcJDopfVJRmBLfzaQdFcl3nmvaeYpIaApnPoVrOGcXIu6edjy2uHLKESw?=
 =?us-ascii?Q?urSdXnOMvAj0YHwkmdZ7IQg/JnIUo9xJddxy+wwTp1FZ2u+ROUqg05tno1MI?=
 =?us-ascii?Q?XxAK8Z5lfTdKye0RCPKat5TGi7mM1qlvte94tYS/QXApnVA1amhj2FGzFuCp?=
 =?us-ascii?Q?5/X05sUtq6hOdaFbZyetTIO64ljP+kWi5EohQg95KieJiL7vKNfm2BvsuGBN?=
 =?us-ascii?Q?U5lCldM9/edLuHUfJhsDlCbdRZ1L/tRTqoTLGP5tHCm7zJK5sYcvAXAZPeiz?=
 =?us-ascii?Q?urJSFA0yxE/ghlW9TOUV0QncQ0LZZkY0Ik9euK/Pccwbto+toCAnEGEvWVMK?=
 =?us-ascii?Q?0VYqdMf5g66qA3wHVtMDlOMX4kULS0v4/KsM5SrnojqNhb2RFk623KgKhwNj?=
 =?us-ascii?Q?4Aa1JmfWhq6KJtsPZ8McjXybKyJh/ROLH84BiIuYbJ6mADnX+lIzBJJ1sS85?=
 =?us-ascii?Q?p/yMoK3gl1P2kQCsGWWAkTNCUnUG/h4zhkoRpNhOICFucizaDLCtVyLjdjW0?=
 =?us-ascii?Q?DCGMcbSdi8iNSQQh1QX/58/X34fDBhVoEAoTl2xUd+FdZGV3UGGdB/ZgpOGf?=
 =?us-ascii?Q?0ICzupQIuW95I6lRj20jZCB5TY32VSNMNQwPPlFjiDTCFo5CitqopZkTAgK2?=
 =?us-ascii?Q?txffgAdGq84o3qk7k6irP5BEvhuGfAQeoaVCdm8ITAOQNMOOIdPHsmNbl0+J?=
 =?us-ascii?Q?P25tm6X8Al8ZZf1KC4WR0pUHNcmmmS3s17B/PgP5XC1Kn2Oc52LZJ9stpJaA?=
 =?us-ascii?Q?hEgPXBVKFGMmxtEin2WuOdKrecSUkBZBbeZwX13obRgy11RejuW3+ECy221j?=
 =?us-ascii?Q?Loexto1ushF00ElHJPseTTez9AoUWvGIvXJ/nx/iSGD7msZmWqmoGszLERQ1?=
 =?us-ascii?Q?sqbLiQW0YWnu1Ohpj0IVoO5/lPpCwuTVLswlc2kGbZA0rzQ2VCBkkYzuG/ol?=
 =?us-ascii?Q?A+2bfSvCdbK7xEehAZjPUXdllaT6WaRdXeoBkUQ4wQTMq06KW/k9MApT1H7L?=
 =?us-ascii?Q?9QuAyryVImZiWFKD6xk8J+sXAwCev2/IfZ521T+g0/ChTk2EEj+M5VTPKy08?=
 =?us-ascii?Q?FnOE2lbuSLytl7dUeZVgkW4IlUJZNdYLubfMvqM+8JhsunK+BBrevtholPoU?=
 =?us-ascii?Q?ziKsUZBU7qY7S4gcgdUoKKE0FSJgsvUMrZSmdLMOos8Rcixhf/V/w4dz5V3O?=
 =?us-ascii?Q?lcuqX3sIPDiDo9Seugxzi0JOVW15Iz4HOmpdhXC2CFIeaIBLGLXxaHQGHHOr?=
 =?us-ascii?Q?PgFJDRmyNvKCl+IABrc=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: DB9PR04MB8412.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 1b07e790-9f33-46fa-d87c-08da8fa56e0c
X-MS-Exchange-CrossTenant-originalarrivaltime: 06 Sep 2022 01:16:30.4433
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: c6xMH+Mno+t2iT22b5vVFdrc3S6w0x1pPpTN0n2i6oYX6ehIJFB+bDH2JR5kzA+ZPVGtGEw5fVCxXYn5QoDSnQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXPR04MB8526
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,T_SCC_BODY_TEXT_LINE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

> Subject: [PATCH] pinctrl: imx8m: kconfig: Fix build error on test compile
>=20
> PINCTRL_IMX depends on OF, however the dependency is missed when
> selected by PINCTRL_IMX8M* (it does not follow the indirect 'select'
> statements), select it explicitly.
>=20
> Cc: Arnd Bergmann <arnd@arndb.de>
> Cc: Linus Walleij <linus.walleij@linaro.org>
> Reported-by: kernel test robot <lkp@intel.com>
...
> Fixes: 87c2a29a6bf1 ("pinctrl: imx8m: kconfig: Depends on SOC_IMX8M")
> Signed-off-by: Francesco Dolcini <francesco.dolcini@toradex.com>

Reviewed-by: Jacky Bai <ping.bai@nxp.com>

BR

> ---
> Linus: I did test on s390 and it's fine, but the topic is tricky for me .=
..
> ---
>  drivers/pinctrl/freescale/Kconfig | 4 ++++
>  1 file changed, 4 insertions(+)
>=20
> diff --git a/drivers/pinctrl/freescale/Kconfig b/drivers/pinctrl/freescal=
e/Kconfig
> index 365fcff8e470..7a32f77792d9 100644
> --- a/drivers/pinctrl/freescale/Kconfig
> +++ b/drivers/pinctrl/freescale/Kconfig
> @@ -119,6 +119,7 @@ config PINCTRL_IMX7ULP
>=20
>  config PINCTRL_IMX8MM
>  	tristate "IMX8MM pinctrl driver"
> +	depends on OF
>  	depends on SOC_IMX8M
>  	select PINCTRL_IMX
>  	help
> @@ -126,6 +127,7 @@ config PINCTRL_IMX8MM
>=20
>  config PINCTRL_IMX8MN
>  	tristate "IMX8MN pinctrl driver"
> +	depends on OF
>  	depends on SOC_IMX8M
>  	select PINCTRL_IMX
>  	help
> @@ -133,6 +135,7 @@ config PINCTRL_IMX8MN
>=20
>  config PINCTRL_IMX8MP
>  	tristate "IMX8MP pinctrl driver"
> +	depends on OF
>  	depends on SOC_IMX8M
>  	select PINCTRL_IMX
>  	help
> @@ -140,6 +143,7 @@ config PINCTRL_IMX8MP
>=20
>  config PINCTRL_IMX8MQ
>  	tristate "IMX8MQ pinctrl driver"
> +	depends on OF
>  	depends on SOC_IMX8M
>  	select PINCTRL_IMX
>  	help
> --
> 2.25.1