Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20220905083125.29426-1-zong.li@sifive.com> <20220905083125.29426-3-zong.li@sifive.com>
 <26246d03-a0dc-8f36-2ac1-daa60d47a057@microchip.com>
In-Reply-To: <26246d03-a0dc-8f36-2ac1-daa60d47a057@microchip.com>
From:   Zong Li <zongbox@gmail.com>
Date:   Tue, 6 Sep 2022 09:52:05 +0800
Message-ID: <CA+ZOyaip+HFQiyHmX5fF+aMWtUK-kKnjhN-1VMk96DiXaQjQrA@mail.gmail.com>
Subject: Re: [PATCH v2 2/6] soc: sifive: ccache: Rename SiFive L2 cache to
 Composable cache.
To:     Conor.Dooley@microchip.com
Cc:     zong.li@sifive.com, robh+dt@kernel.org,
        krzysztof.kozlowski+dt@linaro.org, palmer@dabbelt.com,
        paul.walmsley@sifive.com, aou@eecs.berkeley.edu,
        greentime.hu@sifive.com, ben.dooks@sifive.com, bp@alien8.de,
        devicetree@vger.kernel.org, linux-riscv@lists.infradead.org,
        linux-edac@vger.kernel.org, linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

<Conor.Dooley@microchip.com> =E6=96=BC 2022=E5=B9=B49=E6=9C=886=E6=97=A5 =
=E9=80=B1=E4=BA=8C =E5=87=8C=E6=99=A82:46=E5=AF=AB=E9=81=93=EF=BC=9A
>
> Hey Zong Li,
> Couple comments on this patch.
>
> On 05/09/2022 09:31, Zong Li wrote:
> > EXTERNAL EMAIL: Do not click links or open attachments unless you know =
the content is safe
> >
> > From: Greentime Hu <greentime.hu@sifive.com>
> >
> > Since composable cache may be L3 cache if pL2 cache exists, we should u=
se
>
> What is a pL2 cache?

The pL2 is stand for private L2 cache, it is a L2 cache in our system.
Perhaps I should change the pL2 to L2 in the description for more
generic.

>
> > its original name composable cache to prevent confusion.
> >
> > Apart from renaming, we also add the compatible "sifive,ccache0" into I=
D
> > table.
> >
> > Signed-off-by: Greentime Hu <greentime.hu@sifive.com>
> > Signed-off-by: Zong Li <zong.li@sifive.com>
> > ---
> >  drivers/soc/sifive/Kconfig                    |   6 +-
> >  drivers/soc/sifive/Makefile                   |   2 +-
> >  .../{sifive_l2_cache.c =3D> sifive_ccache.c}    | 163 +++++++++-------=
--
> >  .../{sifive_l2_cache.h =3D> sifive_ccache.h}    |  16 +-
> >  4 files changed, 94 insertions(+), 93 deletions(-)
> >  rename drivers/soc/sifive/{sifive_l2_cache.c =3D> sifive_ccache.c} (35=
%)
> >  rename include/soc/sifive/{sifive_l2_cache.h =3D> sifive_ccache.h} (12=
%)
>
> If you're going to rename the header, you need to update all references t=
o
> it too, otherwise the other user (the EDAC) is going to have build issues=
,
> i.e. patch 6 needs to get squashed into this one.
>

Ok, let me merge these two patches, as you mentioned, we probably
don't want to see the build is broken in git bisect as well.

>
> > diff --git a/drivers/soc/sifive/sifive_l2_cache.c b/drivers/soc/sifive/=
sifive_ccache.c
> > similarity index 35%
> > rename from drivers/soc/sifive/sifive_l2_cache.c
> > rename to drivers/soc/sifive/sifive_ccache.c
> > index 59640a1d0b28..1b16a196547f 100644
> > --- a/drivers/soc/sifive/sifive_l2_cache.c
> > +++ b/drivers/soc/sifive/sifive_ccache.c
>
> > -static const struct of_device_id sifive_l2_ids[] =3D {
> > +static const struct of_device_id sifive_ccache_ids[] =3D {
> >         { .compatible =3D "sifive,fu540-c000-ccache" },
> >         { .compatible =3D "sifive,fu740-c000-ccache" },
> > +       { .compatible =3D "sifive,ccache0" },
> >         { /* end of table */ },
>
> For v3, I think you should drop the , from the end of the table while
> we are already editing it.

Thanks, I will remove it.

> Thanks,
> Conor.
>
> >  };
> >
>