Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Tue, 6 Sep 2022 10:09:17 +0800
From:   Shawn Guo <shawnguo@kernel.org>
To:     Peng Fan <peng.fan@oss.nxp.com>
Cc:     robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org,
        s.hauer@pengutronix.de, kernel@pengutronix.de, festevam@gmail.com,
        linux-imx@nxp.com, aisheng.dong@nxp.com,
        devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
        linux-kernel@vger.kernel.org, Peng Fan <peng.fan@nxp.com>,
        kernel test robot <lkp@intel.com>
Subject: Re: [PATCH V8 4/6] soc: imx: add i.MX93 media blk ctrl driver
Message-ID: <20220906020917.GM1728671@dragon>
References: <20220823055215.1139197-1-peng.fan@oss.nxp.com>
 <20220823055215.1139197-5-peng.fan@oss.nxp.com>
 <20220904104403.GJ1728671@dragon>
 <26552553-b598-3179-40f8-170e766e3809@oss.nxp.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <26552553-b598-3179-40f8-170e766e3809@oss.nxp.com>
Precedence: bulk

On Mon, Sep 05, 2022 at 02:47:16PM +0800, Peng Fan wrote:
[...]
> > > +struct imx93_blk_ctrl_data {
> > > +	const struct imx93_blk_ctrl_domain_data *domains;
> > > +	const struct imx93_blk_ctrl_domain_data *bus;
> > 
> > It looks confusing to claim 'bus' as an imx93_blk_ctrl_domain_data.  I
> > would suggest you have 'related' fields directly defined in
> > imx93_blk_ctrl_data.
> 
> This would implies a bit large change to this driver.
> 
> Should I use a new V1 for the patchset or continue V9 for next version?

I think v9 is fine.

Shawn