Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Tue, 6 Sep 2022 11:19:35 +0800
From:   Huang Rui <ray.huang@amd.com>
To:     "Meng, Li (Jassmine)" <Li.Meng@amd.com>
Cc:     Shuah Khan <skhan@linuxfoundation.org>,
        "linux-pm@vger.kernel.org" <linux-pm@vger.kernel.org>,
        "Rafael J . Wysocki" <rafael.j.wysocki@intel.com>,
        "Fontenot, Nathan" <Nathan.Fontenot@amd.com>,
        "Sharma, Deepak" <Deepak.Sharma@amd.com>,
        "Deucher, Alexander" <Alexander.Deucher@amd.com>,
        "Limonciello, Mario" <Mario.Limonciello@amd.com>,
        "Su, Jinzhou (Joe)" <Jinzhou.Su@amd.com>,
        "Yuan, Perry" <Perry.Yuan@amd.com>,
        "Du, Xiaojian" <Xiaojian.Du@amd.com>,
        Viresh Kumar <viresh.kumar@linaro.org>,
        Borislav Petkov <bp@alien8.de>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        kernel test robot <lkp@intel.com>
Subject: Re: [Patch] cpufreq: amd-pstate: modify type in argument 2 for
 filp_open
Message-ID: <Yxa8R7NfcA3EFD5Y@amd.com>
References: <20220906024826.1560949-1-li.meng@amd.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20220906024826.1560949-1-li.meng@amd.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?qJ8nudTt4LDFI4dhw7BR45Wu4MZIP8mDKsIztXn3DtqTGVujrCdiuQRyfdtK?=
 =?us-ascii?Q?cBfC4DhbR6ZZuaMltk+vy3mpQVuHwN4z9kXPj1Wl8Q86nCBGjhuOf2JMdZwI?=
 =?us-ascii?Q?4F6EIldVlDUHp5VF9Np+nlCHzyU2lJrd1kqRpsMdhaALJ5VNBkElGGWAely3?=
 =?us-ascii?Q?aoM0Bijo/lAKM8u4PGGTwbG0IsvnGCX1P4ldeRhbgcWLTmrQhSN6ZZJEBZ/W?=
 =?us-ascii?Q?NHL7OzC9GbBTaOp8x+5FSkBPNlD1ibY2r6y8jmPLxJvPge9/SEvVlnjttVSN?=
 =?us-ascii?Q?wxH9od5dx3/WLGANk/XXD5yCJ4EcTFWTZKSujo6Effmrh9NcKygWiB+YgN0G?=
 =?us-ascii?Q?3eIQozzw0Bg5Bp2Wzh4XWdpoH78EuR35m8zdqnVDEw9rprHqsOQhyaPSkreB?=
 =?us-ascii?Q?cMbk6J4mrDDDIzmWt1D9yFH9V+5sQ48kOzfGs0dyzX63RwUZker0JFVvJINk?=
 =?us-ascii?Q?mCxjrFacDgYennDX/IUAAb9l5vVXtG1aXn3PSoNzXNAgl94E746GgihmLqFQ?=
 =?us-ascii?Q?vrJEkkITDUpb+R2orO39IOo5rYDiKzcWZQZBJbzZpeZcQg85rmPanJ6dDyTl?=
 =?us-ascii?Q?tczJyTkyvVxlqLio2ixv5q/zEsopMQyJP0GKLPZPsErcwVP2PpE8vlan0ZSo?=
 =?us-ascii?Q?YH1134nTTfGtUvacsjdbi4rpLw4keNDg/8Jrw+kNYsP3wCpU28qDofldgrVn?=
 =?us-ascii?Q?D0AZ0+FQrpKf786rWuokqlVkD/BlNKhpPhVjKGvcoNPR3gJ3bWLYmlLf4wHB?=
 =?us-ascii?Q?j5llukiMTGc/ZjfNMM4LXZ3mevRyFixvKMDSL8m/g0b1O3wxGcuZDzi/I4Ok?=
 =?us-ascii?Q?/tZ/wV2iwliaD65pkvmD+nTESDHQ8t8F21WTZccHszi43VhHDzochJBjI8cd?=
 =?us-ascii?Q?HJ5IZiAnq7RWomQeUUTCKtL/iOa1lMX+uNj1jD2M238FcjRAPTrtWoaUTJCP?=
 =?us-ascii?Q?i2vtvU2jEeVjmiXxFgFRticUACP77BAKyHikRRIie7ygKAsJh1ZO70UpLrj6?=
 =?us-ascii?Q?gnLzGyFQyJChsNF5SQ6TN/koyXH2EKAnexUgFyg+tLO3Z4ajgvqmj7G1DAM2?=
 =?us-ascii?Q?XhyVut8O9cU55fquQQYQcdqCjUotq3Doh+TG7Trb7rdh1JHPIvRaw7VlmwET?=
 =?us-ascii?Q?9Blz7J2Nf4t5ab4Ra+rhoYbgCVud1yFuti2jWiw6kFtfHI0WJRDGTWVl4aKA?=
 =?us-ascii?Q?+mDwnKDAmM+V6EXqzmS5QLnkHpqivneDP8HR93hT36KpJBssCuQjyNZmb+n+?=
 =?us-ascii?Q?uZKjDtWMyjpgKNhpOLHcb0YRuaHngIAE++254lXARvF+SsmT838LkEbQCvrY?=
 =?us-ascii?Q?BJALIsv5eX0KeRUojfT4ohUP/LCmHvhnJf1Qs/C2KpQ79nXsi06Dq9PvC1QV?=
 =?us-ascii?Q?f/CrrpM3gRUe/YEfTJ5LfkN3cD7Q66MC/wgRh9sAv9aQuDg1+CiN2Oqg1ai3?=
 =?us-ascii?Q?hntZdFgi0NZnSN7jJK8fPLU8f2t8/YWNzJ4p2HlEFyv26NbkIs3Oqt2vZMGz?=
 =?us-ascii?Q?J1aqyB23ejDhjxJjg5PZcx8PwNkvysFfNwqpqdVX8Bfwp0cjRjksyA2kNO+C?=
 =?us-ascii?Q?RcG+f7Gh+Zv8Ij1CcdWIdUBZKXk0mr9uLqlr862i?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 1c153c3d-e3c0-4fa4-03d2-08da8fb6aea9
X-MS-Exchange-CrossTenant-AuthSource: DM5PR12MB2504.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Sep 2022 03:20:00.6759
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: if7JCq7iK2rdFUNMX19/Z4NjP2cHPupMmQ0cq7betdp7QXQRRV3KW5aLv/6TkXl1BQNMGaSRiSPaCUUpsiJ+lQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR12MB6664
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,T_SCC_BODY_TEXT_LINE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Tue, Sep 06, 2022 at 10:48:26AM +0800, Meng, Li (Jassmine) wrote:
> Modify restricted FMODE_PREAD to experted int O_RDONLY to
> fix the sparse warnings below:
> sparse warnings: (new ones prefixed by >>)
> >> drivers/cpufreq/amd-pstate-ut.c:74:40: sparse: sparse: incorrect type
> >> in argument 2 (different base types) @@     expected int @@     got
> >> restricted fmode_t [usertype] @@
>    drivers/cpufreq/amd-pstate-ut.c:74:40: sparse:     expected int
>    drivers/cpufreq/amd-pstate-ut.c:74:40: sparse:     got restricted
> fmode_t [usertype]
> 
> Signed-off-by: Meng Li <li.meng@amd.com>
> Reported-by: kernel test robot <lkp@intel.com>

Acked-by: Huang Rui <ray.huang@amd.com>

> ---
>  drivers/cpufreq/amd-pstate-ut.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/cpufreq/amd-pstate-ut.c b/drivers/cpufreq/amd-pstate-ut.c
> index 3947b7138184..e4a5b4d90f83 100644
> --- a/drivers/cpufreq/amd-pstate-ut.c
> +++ b/drivers/cpufreq/amd-pstate-ut.c
> @@ -71,7 +71,7 @@ static bool get_shared_mem(void)
>  	ssize_t ret;
>  
>  	if (!boot_cpu_has(X86_FEATURE_CPPC)) {
> -		filp = filp_open(path, FMODE_PREAD, 0);
> +		filp = filp_open(path, O_RDONLY, 0);
>  		if (IS_ERR(filp))
>  			pr_err("%s unable to open %s file!\n", __func__, path);
>  		else {
> -- 
> 2.34.1
>