Received: by 2002:a05:6358:bb9e:b0:b9:5105:a5b4 with SMTP id df30csp4001133rwb; Tue, 6 Sep 2022 00:29:07 -0700 (PDT) X-Google-Smtp-Source: AA6agR6eqx8F0d8AR3ll3Q/qYiu0xUvOqsxfODv1ltM2FKDoYAo4BqTLRpzF/yeLBAZ14AZ21oYg X-Received: by 2002:a17:90b:17c4:b0:200:a2c6:f34 with SMTP id me4-20020a17090b17c400b00200a2c60f34mr1400966pjb.71.1662449347417; Tue, 06 Sep 2022 00:29:07 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1662449347; cv=none; d=google.com; s=arc-20160816; b=eWo7aD0AGgTtVWec8CtRb9z1unQgPrYdIzkhRX/UVFPw2AA7Rskzr9MteZdOLdJmcN s0/kACZa2F9S2wRb9X+Jvtmq7iPKz5CAiMHR1KZSXa5EXHQBbcEq6mpA8ucOfM0Zxjzl zbw4i+8KPpJDN10yIr8HAJXFA054rawI1bA3DDE6Ijep6JHyP723NpmY2q/pzIv4NEMc TAVdiAGpsmS6/vqx+0hYq2M9e2HfNMcIgH6kSQQqi1pIlM7Y2VS2iEv1QbcSBDMwgaYb fDsQak2ceocsRL0gB16uTwis0xQisLlFn93iMz2GPlmRlNiLs48Q7Rv4ZLZcJg67TS7B Lh7w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:cc:to:subject :message-id:date:from:in-reply-to:references:mime-version :dkim-signature; bh=pg/k2BKeuoUb9BSQqMtaRqCPumr70GT5UhAxF2oEgQM=; b=DW5P1nJz9z92xIoCoVWVllA008diFuaLX0/zfbJqJB5aQsdyYvs28KGdHUk2LgNeGO Qdq1g18padqf4rBZ9h9QHp8eNYUGbV80wMSl3inYD7unrWAvHfrd5wgz4/sG27IRi/vI EFa2HPTJ4uV+sK6ieOmad/dlB2ORbcjsKTQRWHfW0ocHhvNyIl2sO9dMvTTiP7dTci8U ftgGMT0wtDPvm6MQ1gVDcrl7lYrhFCTtOaHZV2cmHYeVVl33dxxO4ivdLgIMRMTyIvH0 1ORg0xOfZJPDw1Pwpwm7uMTLCrlr0VUqGkXUR0xwmTCylKzTF7P0nZHJWyoqMh/FBugQ Sx4w== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@sifive.com header.s=google header.b=Hktmtzse; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id ot11-20020a17090b3b4b00b0020082484d32si3608864pjb.112.2022.09.06.00.28.52; Tue, 06 Sep 2022 00:29:07 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@sifive.com header.s=google header.b=Hktmtzse; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238725AbiIFGwS (ORCPT + 99 others); Tue, 6 Sep 2022 02:52:18 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54572 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S238714AbiIFGwO (ORCPT ); Tue, 6 Sep 2022 02:52:14 -0400 Received: from mail-lj1-x233.google.com (mail-lj1-x233.google.com [IPv6:2a00:1450:4864:20::233]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 100A972EC6 for ; Mon, 5 Sep 2022 23:52:10 -0700 (PDT) Received: by mail-lj1-x233.google.com with SMTP id k18so11188331lji.13 for ; Mon, 05 Sep 2022 23:52:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sifive.com; s=google; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date; bh=pg/k2BKeuoUb9BSQqMtaRqCPumr70GT5UhAxF2oEgQM=; b=HktmtzseBu9APk/Y/0Enxh3WilmA1qFkbnVK6HrsFvBI/HALpUtAkYwHtx1e7KFdPQ CiTKoCDCTqznqfPoHCO8+XHDjN1Ls11iNAR+BgyxUwha3cDk+lhoYnnsFKqxI6IdDdkg ZkLfVNZoG+ej2R9DEI3nVjBEkVZoN1FyOOYpuThHUFlBbGpvXxmTaNNzf6f+ONeIrLwO yQN0miPVnzPMZvNpEveAgbZMHtZnXxAaATZDMXI3PtJEljUS71gnCywFBYB0u7r7xlYP VbWMSFEAgJdONFa/du8UGDM1XUT+WYICUb0DeGauyMd/lcoeS8bHzT/Cvm4o3/ZqbUhc 4frQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date; bh=pg/k2BKeuoUb9BSQqMtaRqCPumr70GT5UhAxF2oEgQM=; b=b3PPcoCV1VDVeVjcrlGlx9y2YsZKI8s+iMVsWstjAsk428aPSyZygurE2CbLtqEkOU r4RslPwQo0mAFy2oB0Pkdf3uGOXON3fLF4VLZdhrbqLCke3bYfAgOkQyFLssiTwP9abk q0LPWnLVid6s9gDexfSm8tvqh95vYt7dqKChCWAIal5C9u1C+NFsOjmMdePXtgWJSnEg 2bxYYPWkZ7ENeMq6hQAUoClISmmkUcpb632E0AZ8XU0bzqhNFAuz1XAnTFV2v2OLMvN6 lPgq6uLE31PiY6VfnvPOhQBcOzT4LZUd+POliqaf6A1njBT/5xxhXuWJhOewkoH7+jkH HBPQ== X-Gm-Message-State: ACgBeo0piWK0pfo1h0HkVB0It2Dyi+T2Gcn7wjp6zbA4WSE9YBn8ciSP lm4ZIsBYZPdp5b9jAn25aO2VKu8jF/1X/PN1+Nc1Zw== X-Received: by 2002:a05:651c:1047:b0:264:f7bb:7b6 with SMTP id x7-20020a05651c104700b00264f7bb07b6mr12695077ljm.275.1662447129027; Mon, 05 Sep 2022 23:52:09 -0700 (PDT) MIME-Version: 1.0 References: <20220905083125.29426-1-zong.li@sifive.com> <20220905083125.29426-3-zong.li@sifive.com> <2a22c6ac-dc0e-7066-8f5f-04c428c77ee2@microchip.com> <048bb217-e91e-b727-fcd1-e55755a87d0d@microchip.com> In-Reply-To: <048bb217-e91e-b727-fcd1-e55755a87d0d@microchip.com> From: Zong Li Date: Tue, 6 Sep 2022 14:51:57 +0800 Message-ID: Subject: Re: [PATCH v2 2/6] soc: sifive: ccache: Rename SiFive L2 cache to Composable cache. To: Conor Dooley Cc: Zong Li , Rob Herring , krzysztof.kozlowski+dt@linaro.org, Palmer Dabbelt , Paul Walmsley , Albert Ou , Greentime Hu , Ben Dooks , bp@alien8.de, "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , linux-riscv , linux-edac@vger.kernel.org, "linux-kernel@vger.kernel.org List" Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Sep 6, 2022 at 2:23 PM wrote: > > On 06/09/2022 02:44, Zong Li wrote: > > EXTERNAL EMAIL: Do not click links or open attachments unless you know = the content is safe > > > > =E6=96=BC 2022=E5=B9=B49=E6=9C=886=E6=97= =A5 =E9=80=B1=E4=BA=8C =E5=87=8C=E6=99=A82:48=E5=AF=AB=E9=81=93=EF=BC=9A > >> > >> Noticed a another thing, sorry.. > >> > >> On 05/09/2022 09:31, Zong Li wrote: > >>> EXTERNAL EMAIL: Do not click links or open attachments unless you kno= w the content is safe > >>> > >>> From: Greentime Hu > >>> > >>> Since composable cache may be L3 cache if pL2 cache exists, we should= use > >>> its original name composable cache to prevent confusion. > >>> > >>> Apart from renaming, we also add the compatible "sifive,ccache0" into= ID > >>> table. > >>> > >>> Signed-off-by: Greentime Hu > >>> Signed-off-by: Zong Li > >>> --- > >>> drivers/soc/sifive/Kconfig | 6 +- > >>> drivers/soc/sifive/Makefile | 2 +- > >>> .../{sifive_l2_cache.c =3D> sifive_ccache.c} | 163 +++++++++----= ----- > >>> .../{sifive_l2_cache.h =3D> sifive_ccache.h} | 16 +- > >>> 4 files changed, 94 insertions(+), 93 deletions(-) > >>> rename drivers/soc/sifive/{sifive_l2_cache.c =3D> sifive_ccache.c} = (35%) > >>> rename include/soc/sifive/{sifive_l2_cache.h =3D> sifive_ccache.h} = (12%) > >>> > >> > >>> -static ssize_t l2_write(struct file *file, const char __user *data, > >>> +static ssize_t ccache_write(struct file *file, const char __user *da= ta, > >>> size_t count, loff_t *ppos) > >> > >> You need to fix the alignment here as per checkpatch: > >> CHECK: Alignment should match open parenthesis > >> #112: FILE: drivers/soc/sifive/sifive_ccache.c:53: > >> +static ssize_t ccache_write(struct file *file, const char __user *dat= a, > >> + size_t count, loff_t *ppos) > >> > > > > I'm not sure why I don't see that by checkpatch, but it looks that it > > is actually misalignment there, I would re-check all indents in > > source. Thanks. > > You need to pass --strict to checkpatch to see it. Many thanks for the tip, I can see the message after applying the option. > > > > >>> { > >>> unsigned int val; > >>> @@ -57,75 +57,76 @@ static ssize_t l2_write(struct file *file, const = char __user *data, > >>> if (kstrtouint_from_user(data, count, 0, &val)) > >>> return -EINVAL; > >>> if ((val < 0xFF) || (val >=3D 0x10000 && val < 0x100FF)) > >>> - writel(val, l2_base + SIFIVE_L2_ECCINJECTERR); > >>> + writel(val, ccache_base + SIFIVE_CCACHE_ECCINJECTERR)= ; > >>> else > >>> return -EINVAL; > >>> return count; > >>> } > >>> >