Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   wei.fang@nxp.com
To:     davem@davemloft.net, edumazet@google.com, kuba@kernel.org,
        pabeni@redhat.com
Cc:     netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH net-next] net: fec: add pm runtime force suspend and resume support
Date:   Tue,  6 Sep 2022 16:39:23 +0800
Message-Id: <20220906083923.3074354-1-wei.fang@nxp.com>
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?m79iDEjW6qIsU5UldOiDJRERSkvVQnCAeHY7/whbDqP33hTROSarxTLII9PU?=
 =?us-ascii?Q?fcxb+W8PyMf/k0BC4GOqt3A7fskYaUM+H2X+F07GEkvxp0IMeL8AHKwrpiBM?=
 =?us-ascii?Q?hkWQz6oxDt8q5aJorUUlpxem9nXNvLd+v5DJYtRXHW4KpBZiTD/6oQXZQNnY?=
 =?us-ascii?Q?nyoQRtG7jRmbJxx7I+DXRIbJQiewdGI0/owdGabHLjxlvjidQKzNcXhcvxkH?=
 =?us-ascii?Q?wLz8auuu3iWR5GbCufizAanj1N2vOy3x5vEH2Eal/kW5mgK08cT56OlyVEDk?=
 =?us-ascii?Q?gtmbkXDZtq6XdjVOiBqId4JZWnFnIG70axDbqy9XZ0+J8ensN4iKVg06Kkcw?=
 =?us-ascii?Q?Wu6AGg3qwAhUIGeq8rwXJvt6G1IiYTeQb/5wOQr7yUrcslbU61wrEdANU9v7?=
 =?us-ascii?Q?jls6pEcV8hsfevTwR/l2Hy2QPnao0si9ThJQNu6XxTIUdz8wlpvVsCn0O1Vk?=
 =?us-ascii?Q?iogWPNZ3dFXjGfhOBOh5xNNyBUgWjV1TmzMBd/vfZlso9TYymWKyd2wsb19V?=
 =?us-ascii?Q?qGHEIuYdUn550kKgyJgAEZIx1ouhdaKLHAWTSt41X60qd8zn9FOW2iNWNxRz?=
 =?us-ascii?Q?YDkOMW3AtFesE8Q1VQ2ZdVxktS2bPznF8Aw96EcRnIJnpYLMTQhKIgEy3YYy?=
 =?us-ascii?Q?+qHijnpv3y1lDYfhU52d2JOyWILQAFmIjIuvWcZbVvmFnItVKq5QjEHbCwGt?=
 =?us-ascii?Q?JRJPwXkKfnBphBVon4p4jd//lN7a7HEw/bJYiuOmlbJHEn/Jxqe7ulH7tC5y?=
 =?us-ascii?Q?SAVaTVLvhwzC7NMbuDO8DvZr6fOZdLEVU1V6iNP61mMVUA2L7cyrmHIDdisu?=
 =?us-ascii?Q?4P+ZYKlN1F/jjqaYRzrjCfVb10avo6n8Qg75vLUAXn+e4HTddhXBpFMVyPY3?=
 =?us-ascii?Q?bNkUwG3NJvFb27N0cgy7W1mTeDxXwBmjDEhHJ9PNvba8+kX02pQ7CIBTJZsp?=
 =?us-ascii?Q?rVP6/fyAf7vMAM/a/2XMNWUzj08tiAvCWd9bgWMB+wohUWF5e1kNMtrJb8PM?=
 =?us-ascii?Q?3GGrkt8HYnHGXbHDQ7hSb/meEM2gaaRovMJqWIUML1J+CKPkshqUW08iuDLb?=
 =?us-ascii?Q?y7aIWZS/fNdn750JgyWYg3RA462BDnkGIvlF3KvqDUxU8yJ/wKbhCIsRkyzD?=
 =?us-ascii?Q?vNI0R01Q9XXCjxAjdCD9s+TRjwVF5bvfSEFTdEd2/mPVmBXBCzMY4LZ8x5oJ?=
 =?us-ascii?Q?N7Rdlw/0HJGaV9WC8eDxp8i3YM/Mj71lT02QQjOayc3g42m52Y+BSguI3k0U?=
 =?us-ascii?Q?8myxaLHR16luLfxZ6i+wV09l03oLdPc53BTtPDEcYd+A5QcBuMReFRqduxxm?=
 =?us-ascii?Q?E4aHcRZ2/5RkEE1LIA1ee5mKp0fmYbjDDkjp7un6hMYkFaCNMKtWZHNlPgTo?=
 =?us-ascii?Q?J4a6B6Hbpv7xZBgyUiEU+aleNUcQnrkliIYE83pIlHXnqh4dT8T1n6bJc8o9?=
 =?us-ascii?Q?XfbdGIyvOB5DWNzTw6CQjuw2iVJd0+lFKpf9OD+gXq7f1zWzNX0RWv7HCVob?=
 =?us-ascii?Q?PbjGjIb2xm3ZhAaFHiRTgGMHX7r69oVBD9/1AskxqaCzPtudiN213Omd/Hx4?=
 =?us-ascii?Q?Fb3E0CEON2Zo7m2hXPa7O/Vii5W2hEFfQqB5cSfd?=
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 60a8e558-5a6f-4f2b-92f5-08da8fe35ac3
X-MS-Exchange-CrossTenant-AuthSource: DB9PR04MB8106.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Sep 2022 08:39:47.1804
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: CCOSuwToEYDpNKkIybFheerUI7ce2lecTe0J8VfRGfFzutSWlDd/6V+apsf2XVgmE3YfAeERojN+9j/6X8eJWQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXPR04MB9373
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,T_SCC_BODY_TEXT_LINE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

From: Wei Fang <wei.fang@nxp.com>

Force mii bus into runtime pm suspend state during device suspends,
since phydev state is already PHY_HALTED, and there is no need to
access mii bus during device suspend state. Then force mii bus into
runtime pm resume state when device resumes.

Signed-off-by: Wei Fang <wei.fang@nxp.com>
---
 drivers/net/ethernet/freescale/fec.h      |  1 +
 drivers/net/ethernet/freescale/fec_main.c | 13 +++++++++++++
 2 files changed, 14 insertions(+)

diff --git a/drivers/net/ethernet/freescale/fec.h b/drivers/net/ethernet/freescale/fec.h
index 0cebe4b63adb..521f60c7f2e0 100644
--- a/drivers/net/ethernet/freescale/fec.h
+++ b/drivers/net/ethernet/freescale/fec.h
@@ -579,6 +579,7 @@ struct fec_enet_private {
 	struct device_node *phy_node;
 	bool	rgmii_txc_dly;
 	bool	rgmii_rxc_dly;
+	bool	rpm_active;
 	int	link;
 	int	full_duplex;
 	int	speed;
diff --git a/drivers/net/ethernet/freescale/fec_main.c b/drivers/net/ethernet/freescale/fec_main.c
index 7211597d323d..13210b216ee4 100644
--- a/drivers/net/ethernet/freescale/fec_main.c
+++ b/drivers/net/ethernet/freescale/fec_main.c
@@ -4092,6 +4092,7 @@ static int __maybe_unused fec_suspend(struct device *dev)
 {
 	struct net_device *ndev = dev_get_drvdata(dev);
 	struct fec_enet_private *fep = netdev_priv(ndev);
+	int ret;
 
 	rtnl_lock();
 	if (netif_running(ndev)) {
@@ -4116,6 +4117,15 @@ static int __maybe_unused fec_suspend(struct device *dev)
 		}
 		/* It's safe to disable clocks since interrupts are masked */
 		fec_enet_clk_enable(ndev, false);
+
+		fep->rpm_active = !pm_runtime_status_suspended(dev);
+		if (fep->rpm_active) {
+			ret = pm_runtime_force_suspend(dev);
+			if (ret < 0) {
+				rtnl_unlock();
+				return ret;
+			}
+		}
 	}
 	rtnl_unlock();
 
@@ -4146,6 +4156,9 @@ static int __maybe_unused fec_resume(struct device *dev)
 
 	rtnl_lock();
 	if (netif_running(ndev)) {
+		if (fep->rpm_active)
+			pm_runtime_force_resume(dev);
+
 		ret = fec_enet_clk_enable(ndev, true);
 		if (ret) {
 			rtnl_unlock();
-- 
2.25.1