Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Tue, 6 Sep 2022 11:19:30 +0200
From:   Niklas =?iso-8859-1?Q?S=F6derlund?= 
        <niklas.soderlund@corigine.com>
To:     Joe Perches <joe@perches.com>
Cc:     Dwaipayan Ray <dwaipayanray1@gmail.com>,
        Lukas Bulwahn <lukas.bulwahn@gmail.com>,
        Jonathan Corbet <corbet@lwn.net>,
        Andy Whitcroft <apw@canonical.com>, linux-doc@vger.kernel.org,
        linux-kernel@vger.kernel.org, oss-drivers@corigine.com,
        Simon Horman <simon.horman@corigine.com>,
        Louis Peens <louis.peens@corigine.com>
Subject: Re: [PATCH] checkpatch: warn for non-standard fixes tag style
Message-ID: <YxcQou32EAGWwNhM@oden.dyn.berto.se>
References: <20220829155358.2546732-1-niklas.soderlund@corigine.com>
 <dc45a7021bb765ea34c5b9228454f255764c7bc9.camel@perches.com>
 <YxXUHPWtyrt6kNI1@sleipner.dyn.berto.se>
 <f550b468064c61e3550b50da37138802d7e9415a.camel@perches.com>
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <f550b468064c61e3550b50da37138802d7e9415a.camel@perches.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?iso-8859-1?Q?37VJ8z+ssh9Thp+Q50+8tOtl36eBcH6ZhWZV0gjiGyrW1BuVG5Lua+yzlu?=
 =?iso-8859-1?Q?KTYxq2o5wiElKl0i55BNxEcrmZhL2KbEVjKh6tAapLLK3bo7dwM17vA8yv?=
 =?iso-8859-1?Q?bzYLb8GavAir+wqYIRT9sx8ljZA38M/YMXh1oMsuS4IdJA3XLP9Pw9n/PC?=
 =?iso-8859-1?Q?YcF2MRAi8K7uzFcmD5jTsKFgIs4zFIqF9US2IIpvNgG+V42UPT4CjI1ND3?=
 =?iso-8859-1?Q?skR3tekEFQxv/kWbqXFfWjPxlQM8EauxxFjIq4z5zOMrw+fJKt+mT1g1vG?=
 =?iso-8859-1?Q?Sm9FDjbGtXWZE+AqOf2mgXj8NWQtVtZDuINHZ8gvHhp+mBOXVUyVbk03B2?=
 =?iso-8859-1?Q?vClNeWzQefUeshSWUV2JNmg3ewa2JoubjI3juPAWOdxxPUBK2NBpkTz7I5?=
 =?iso-8859-1?Q?letPf+UdQMRMevAPmoeJGoQocIPMAPt06/KQDAUVXZZhObSdXhABGJHwky?=
 =?iso-8859-1?Q?HfR7bQftP5nWJrwmqXLTX3S7TMlW7B14chrjUnRWACrJpKNUsh5vEuc6pv?=
 =?iso-8859-1?Q?sCxuGqc8KzxWIFwuVu1T/zR6Wm+3TXdLuLdGKTV4ew9Xb5YjpFdNehe2IP?=
 =?iso-8859-1?Q?k0LUNGFdGIrhfuUbjiRcav4v4X3OfCzMJa7foOsDV0GKrCH3Tn9qP23Rc/?=
 =?iso-8859-1?Q?biOIWZjvyQjp9FhGwoiNXeM2+kA14z0yeZ1aBFYnKJklycZv7Y9XStqjnv?=
 =?iso-8859-1?Q?C99mfcqAufso90KTUCV9Z8kMBTHv+uP6mmZfoVX25rNCPoKiwXHapyuW9A?=
 =?iso-8859-1?Q?UONQ6+lehX+S7S/ntqshxbZ6qdTTqCrySHaheIJL3u3ZTDWE2yd7mJnkaH?=
 =?iso-8859-1?Q?sczt+WhQbAEpHFVFi93eGmLM3Xo00B2lL6LyQr4OBzjkYdPaxWgHI3MEBv?=
 =?iso-8859-1?Q?LBENLJbJiqojHOPet5HkLkJ4lLBvvRowV+GiziCJ9eFy2i0tmZgIFK3YOo?=
 =?iso-8859-1?Q?BiHSsJgIaxry/GQuylVgnSKC5gl+LphkFieaUd2R8vMtFvM/8C5kP/tz+i?=
 =?iso-8859-1?Q?DGI2B8cgdKj//jq8LOs08Npn5/CXXNnR8iIg9AbLS+WRyEDnYQ9i/Irsz8?=
 =?iso-8859-1?Q?/N6n1WKMWxAHJKcZQo33CYriNT69qCiofXGh54+qHUCnUO5/LJ8IUDoQut?=
 =?iso-8859-1?Q?3gcSJbEkMb5IPHnjH1tSgRcMDQwnIC66RCqLjVBAry9Q6NMdZkvDd6vQ+O?=
 =?iso-8859-1?Q?cb7PWrwlVB5TZ66F3KX5EpYBleU2fbRfJMp8TRGW5PkUHFvRtgSUhtiIoX?=
 =?iso-8859-1?Q?dsCTRUH1jaQz4HQXMYwJxIwGk7O7yymeOTDSxh/ZpyYOSw/QPFbnhPRdui?=
 =?iso-8859-1?Q?iNd8w+1IEGCCCMzUa5kyJVn73Q7teZaotLKL2ZYBqkxamXzev/OzlRPzQ5?=
 =?iso-8859-1?Q?fHZBJ1UOj8yGpp+loMDeLpBiPJ3+MhtYP+WlxWN9ZA/7pqqg7jdI6wBq0N?=
 =?iso-8859-1?Q?pcY3nDWbADRWXQWUk0t5IG7SOzSWAB+gVCUrtDC4Fj969HkQIXL8FB9f8u?=
 =?iso-8859-1?Q?/dKoDQZjJcOeoHvhuB4NePBhQ6snHkO2Z7nB8gBuRPhd1YPRBYIMnvv6ar?=
 =?iso-8859-1?Q?etih2J1L0jJu8VyYm376Y6+v3bYLkq9aHz9fPt8KjtlTD6gzmvW5a9gyxS?=
 =?iso-8859-1?Q?5Qlkm3dLCSjrhHUvPbh1ymKs6i7VIaeDGzzgZRUhAfLk2ATVPl0NjYdw?=
 =?iso-8859-1?Q?=3D=3D?=
X-OriginatorOrg: corigine.com
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN4PR13MB5277
X-Spam-Status: No, score=-1.7 required=5.0 tests=BAYES_00,DKIM_INVALID,
        DKIM_SIGNED,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,
        SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no
        version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hello Joe,

On 2022-09-05 11:00:35 -0700, Joe Perches wrote:
> On Mon, 2022-09-05 at 12:49 +0200, Niklas S?derlund wrote:
> > Hi Joe,
> > 
> > Thanks for your feedback.
> > 
> > On 2022-08-29 23:06:43 -0400, Joe Perches wrote:
> > > > +			if ($line =~ 
> > > > /(fixes:)\s+([0-9a-f]{5,})\s+($balanced_parens)/i) {
> > > 
> > > Maybe use fixes:? so the colon is not required in poorly formed uses
> > 
> > I tried that but I think it brings more problems then it is worth. With 
> > that change the check would run for each line of the commit message that 
> > begins with the string 'fixes', not just in the tags section of the 
> > message. So it would warn for the commit message,
> 
> I think it's not a problem.
> Look at the results of:
> 
> $ git log -100000 --no-merges --format=email --grep="^fixes" -i | \
>   grep -i -P -oh '^fixes:?\s*[0-9a-f]{5,}\s*..' | \
>   sed -r -e 's/^(fixes:?\s*)[0-9a-f]+/\1/i' | \
>   sort | uniq -c | sort -rn | head -20
>   73974 Fixes:  ("
>    1345 Fixes:  ('
>     399 Fixes: 
>     246 Fixes:  (A
>     215 Fixes: ("
>     172 Fixes:  (c
>     121 Fixes:  (s
>     114 Fixes:  (d
>     110 Fixes:  (P
>      98 Fixes:  (i
>      90 Fixes:  (m
>      86 Fixes:  (n
>      78 Fixes: : 
>      57 Fixes  ("
>      51 Fixes:  "n
>      47 Fixes:  (a
>      46 Fixes:  (t
>      43 fixes:  ("
>      42 Fixes:  (p
>      41 Fixes: ('

Thanks for checking this. With this background I agree with you, there 
is no problem here. I will spin a v3 with your suggestion.
> 

-- 
Kind Regards,
Niklas S?derlund