Received: by 2002:a05:6358:bb9e:b0:b9:5105:a5b4 with SMTP id df30csp4114100rwb; Tue, 6 Sep 2022 02:46:24 -0700 (PDT) X-Google-Smtp-Source: AA6agR4tuiCeDfr5yO8ZrcJyAcvzXDFpfABeO1VHCcLD6HLHkZEoXzrn5HOuBjHfSQuuzNp/cnv5 X-Received: by 2002:a17:906:9754:b0:76e:d46e:4422 with SMTP id o20-20020a170906975400b0076ed46e4422mr3029407ejy.617.1662457584046; Tue, 06 Sep 2022 02:46:24 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1662457584; cv=none; d=google.com; s=arc-20160816; b=fy2385OyEFRPZBjinAaiD9rFLqe2KsxfSOVy9fY16oEZYBrHIfdjjx3CvQspiS+KCR g5qH/FRNOJyQGss8FqlzJZzOy7bQUgpUwg54BMFJyj7Z4HsmI/ApfB/A3DfIpuMlJ9oT 7guFKnBlktndaSrwbIQko3nKmfMkxilEQpBx19yv+nn/dRu+PrZuieq5TuHFYVzChGbu cETQi+Gq8AkeOH+EEtKcWh6AxBYvkfOHWO8oQXDR0sZ9CO+AgoulRlhdhpkydhR8IAOE dVpPiuzX3/qrpkdRZcyHEpuhljufpC9EK/xknBw2PN7uMq2Xc2cCqtIF1Ul1Nyp66Ihq 96UA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=2qDYpHuHfXVn75WEqJsFoiIv26+1ntYwgiyVPU2xfns=; b=H4fbUFJWkoKnlq6gcVTU/SVX1D4ZGJ5AMKwFy4mxgFDYRFcK5uSPAvVFsL9AY5I4v2 qIqumjyj+5f06CoNp0V5Ptu5m1rAwkdrE9GOFR5m/9sKelmolzbHP0nqrYWn8KYUnf7E Eh6ZGJiuGD0rN6qC5FZ9545Ut/IVVi1i3/wvVZztnNCZ1eJB/Z9rQSpGVJ0DxsDGbOu9 QNg0md9gAZXP1PK4th4/OZT15tR87kHdG58Aw87vVMsrN5H51PSG4bNPns98fvKN0BO1 iFS6A9u1rGDUQX/Eds3wX8YkxpX+SlyEai3zo0oSfmzw18WkjLkmPQ8ctzRdq7ewpBsQ 7ZHA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@infradead.org header.s=bombadil.20210309 header.b=g9OAK4Ew; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id hc32-20020a17090716a000b00741a186e545si8846344ejc.47.2022.09.06.02.45.59; Tue, 06 Sep 2022 02:46:24 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@infradead.org header.s=bombadil.20210309 header.b=g9OAK4Ew; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239075AbiIFJnP (ORCPT + 99 others); Tue, 6 Sep 2022 05:43:15 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58810 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S239537AbiIFJmq (ORCPT ); Tue, 6 Sep 2022 05:42:46 -0400 Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:3::133]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3211A76469; Tue, 6 Sep 2022 02:42:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=2qDYpHuHfXVn75WEqJsFoiIv26+1ntYwgiyVPU2xfns=; b=g9OAK4Ewx/kpJOsybV0tqVyLKC fXPe1N0g2PyjPi7YcykxQf3qHou7W6XeCXvzfhB1MKz+1xoMQo/1B69aqyYsEgCJdPJ4eFoyRapu9 4v9cxK2KLCj31WbbiVWNS75ziRNFuWcExlAlF60lghK5noBzEQUTEPiiBR/K6doR56BNUARdEHX/t bHk7W2vMBxX3WGJTnC4vmOkwDkES390sWShqj1MVD2/8IkX09iKEa+jwg4Bh7oSMumi3IWxyCIoST rIptoxF8mPudqsREDfFfqylMfpjsg/nakCMCF0YnUahVDGaHM96GY+aVM6/A1ZnWFp48uTpo/Z2tU 4pj77kKQ==; Received: from hch by bombadil.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1oVV5P-00Bz2h-AF; Tue, 06 Sep 2022 09:41:39 +0000 Date: Tue, 6 Sep 2022 02:41:39 -0700 From: Christoph Hellwig To: Kevin Tian Cc: Zhenyu Wang , Zhi Wang , Jani Nikula , Joonas Lahtinen , Rodrigo Vivi , Tvrtko Ursulin , David Airlie , Daniel Vetter , Eric Farman , Matthew Rosato , Halil Pasic , Vineeth Vijayan , Peter Oberparleiter , Heiko Carstens , Vasily Gorbik , Alexander Gordeev , Christian Borntraeger , Sven Schnelle , Tony Krowiak , Jason Herne , Harald Freudenberger , Diana Craciun , Alex Williamson , Cornelia Huck , Longfang Liu , Shameer Kolothum , Jason Gunthorpe , Yishai Hadas , Eric Auger , Kirti Wankhede , Leon Romanovsky , Abhishek Sahu , intel-gvt-dev@lists.freedesktop.org, intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, linux-s390@vger.kernel.org, kvm@vger.kernel.org, Yi Liu Subject: Re: [PATCH v2 01/15] vfio: Add helpers for unifying vfio_device life cycle Message-ID: References: <20220901143747.32858-1-kevin.tian@intel.com> <20220901143747.32858-2-kevin.tian@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220901143747.32858-2-kevin.tian@intel.com> X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW,SPF_HELO_NONE, SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org What is the point? This adds indirect calls, and actually creates more boilerplate code in the drivers. i.g. when using this code there is more, and harder to read code.