Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Tue, 6 Sep 2022 10:07:35 +0000
From:   Marek Bykowski <marek.bykowski@gmail.com>
To:     Rob Herring <robh+dt@kernel.org>
Cc:     Frank Rowand <frowand.list@gmail.com>, devicetree@vger.kernel.org,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] of/fdt: Don't calculate initrd_start from the DT if
 'linux,initrd-end' is 0
Message-ID: <20220906100735.7a226942@ubuntu.armcompdev.pub.tds.tieto.com>
In-Reply-To: <20220830153500.49206b5a@ubuntu.armcompdev.pub.tds.tieto.com>
References: <20220826220017.188066-1-marek.bykowski@gmail.com>
        <CAL_JsqKGgZOSdWQ2ithipvrRAYwt-vOL1z9-RM++-_h6pA=C_Q@mail.gmail.com>
        <20220830153500.49206b5a@ubuntu.armcompdev.pub.tds.tieto.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Precedence: bulk

On Tue, 30 Aug 2022 15:35:00 +0000
Marek Bykowski <marek.bykowski@gmail.com> wrote:

> On Sun, 28 Aug 2022 20:12:41 -0500
> Rob Herring <robh+dt@kernel.org> wrote:
> 
> > 
> > Shouldn't we just check that start < end?
> > 
> > Can we check this somewhere not DT specific (and also not arch
> > specific)? Then we don't have to worry if any other method of
> > setting initrd could have the same error.
> 
> Yes, we can switch from checking on the end being 0 to that proposed:
> - if (!end)
> -     return;
> + if (start >= end)
> +     return;
> 
> Then the check would even go further as would also catch cases where
> end < start.
> 
> My taking is early_init_dt_scan_chosen() that sets initrd size
> incorrectly is DT specific but generic/arch agnostic. So that if
> the error got introduced by a bootloader/U-Boot through the DT
> chosen node, we should catch it in DT and react.
> 
> ARM64, for example, before going down for mapping for the incorrect
> address (some extra large address resulting from the negative to
> positive value conversion), has a check after DT parsing if
> phys_initrd_size is other than 0 to proceed, and it is so that it
> passes or in other words it doesn't catch the error.
> 
> Marek

Hello Rob and others,

Any updates on it?

Marek