Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <cover.1662454215.git.cmo@melexis.com> <61da82560512fbbda5f4124a1c907375da822b15.1662454215.git.cmo@melexis.com>
In-Reply-To: <61da82560512fbbda5f4124a1c907375da822b15.1662454215.git.cmo@melexis.com>
From:   Andy Shevchenko <andy.shevchenko@gmail.com>
Date:   Tue, 6 Sep 2022 13:23:19 +0300
Message-ID: <CAHp75VeUN3apcuauOSy6+jEP94vinuT8vdR7=B6yRC5mx2B2Dw@mail.gmail.com>
Subject: Re: [PATCH v3 3/3] iio: temperature: mlx90632 Change return value of
 sensor measurement channel
To:     Crt Mori <cmo@melexis.com>
Cc:     Jonathan Cameron <jic23@kernel.org>,
        linux-iio <linux-iio@vger.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Tue, Sep 6, 2022 at 12:05 PM <cmo@melexis.com> wrote:
>
> From: Crt Mori <cmo@melexis.com>
>
> The current EINVAL value is more applicable to embedded library, where

an embedded
  ...or...
libraries

> user can actually put the fixed value to the sensor. In case of the
> driver if the value of the channel is invalid it is better in inform
> userspace that Channel was out of range as that implies more to internal
> driver error than invalid input. It also makes for easier debugging of
> where the error comes from during the development.

As I said earlier I'm in favour of this change to at least make good
use of this error code since it is confirmed to help debugging.
Reviewed-by: Andy Shevchenko <andy.shevchenko@gmail.com>

> Signed-off-by: Crt Mori <cmo@melexis.com>
> ---
>  drivers/iio/temperature/mlx90632.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/iio/temperature/mlx90632.c b/drivers/iio/temperature/mlx90632.c
> index 6b33284eb0b6..aee065a38772 100644
> --- a/drivers/iio/temperature/mlx90632.c
> +++ b/drivers/iio/temperature/mlx90632.c
> @@ -436,7 +436,7 @@ static int mlx90632_channel_new_select(int perform_ret, uint8_t *channel_new,
>                 *channel_old = 1;
>                 break;
>         default:
> -               return -EINVAL;
> +               return -ECHRNG;
>         }
>
>         return 0;
> --
> 2.34.1
>


-- 
With Best Regards,
Andy Shevchenko