Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Tue, 6 Sep 2022 13:20:01 +0300
From:   Mika Westerberg <mika.westerberg@linux.intel.com>
To:     Szuying Chen <chensiying21@gmail.com>
Cc:     YehezkelShB@gmail.com, gregkh@linuxfoundation.org,
        mario.limonciello@amd.com, andreas.noever@gmail.com,
        michael.jamet@intel.com, linux-usb@vger.kernel.org,
        linux-kernel@vger.kernel.org, Yd_Tseng@asmedia.com.tw,
        Chloe_Chen@asmedia.com.tw, Richard_Hsu@asmedia.com.tw
Subject: Re: [PATCH v9 6/6] thunderbolt: Add support for ASMedia image format
Message-ID: <Yxce0WshoIgS7zBz@black.fi.intel.com>
References: <20220906101128.6504-1-chensiying21@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20220906101128.6504-1-chensiying21@gmail.com>
Precedence: bulk

On Tue, Sep 06, 2022 at 06:11:28PM +0800, Szuying Chen wrote:
> From: Szuying Chen <Chloe_Chen@asmedia.com.tw>
> 
> Hi,
> 
> >  
> > +static int asmedia_switch_nvm_version(struct tb_nvm *nvm) {
> > +	struct tb_switch *sw = tb_to_switch(nvm->dev);
> > +	u32 val;
> > +	int ret;
> > +
> > +	ret = tb_switch_nvm_read(sw, ASMEDIA_NVM_VERSION, &val, sizeof(val));
> > +	if (ret)
> > +		return ret;
> > +
> > +	nvm->major = (val << 16) & 0xff0000;
> > +	nvm->minor |= val & 0x00ff00;
> 
> 	nvm->major

Heh, that one was clearly a copy paste error ;-)

I will fix it up when applying. Thanks for checking.