Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <cover.1662454215.git.cmo@melexis.com> <32c4b72624e4a3480b202f24f506ca91029e47f7.1662454215.git.cmo@melexis.com>
 <CAHp75VezNufWGW6sC+ALmX9H4yavWRCmpHuv9ZVoRycQxZ-uQg@mail.gmail.com>
In-Reply-To: <CAHp75VezNufWGW6sC+ALmX9H4yavWRCmpHuv9ZVoRycQxZ-uQg@mail.gmail.com>
From:   Crt Mori <cmo@melexis.com>
Date:   Tue, 6 Sep 2022 12:51:46 +0200
Message-ID: <CAKv63utD2NzbUYR2=rrmZtkdtwOzoQBW7dZ5yzNa-r8uKmqXaw@mail.gmail.com>
Subject: Re: [PATCH v3 1/3] iio: temperature: mlx90632 Add runtime
 powermanagement modes
To:     Andy Shevchenko <andy.shevchenko@gmail.com>
Cc:     Jonathan Cameron <jic23@kernel.org>,
        linux-iio <linux-iio@vger.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Tue, 6 Sept 2022 at 12:21, Andy Shevchenko <andy.shevchenko@gmail.com> wrote:
>
> Very good and documented code, thanks!
> I believe you better to use DEFINE_.*_PM_OPS instead of legacy ones
> (due to pm_ptr() usage).
> Otherwise, with some nitpicks that wouldn't prevent a green light,
> Reviewed-by: Andy Shevchenko <andy.shevchenko@gmail.com>
>
I checked DEFINE_.*_PM_OPS usage around drivers and you either have
SIMPLE (where you define suspend/resume) or you have RUNTIME (for
runtime suspend/resume), but never are those two together. So I am a
bit puzzled how to get this working.