Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <edd6e329-7575-ffcb-7e93-0ae881dc71fa@suse.com>
Date:   Tue, 6 Sep 2022 12:53:44 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.1.2
Subject: Re: [PATCH v10 0/6] Raspberry Pi Sense HAT driver
Content-Language: en-US
To:     Bagas Sanjaya <bagasdotme@gmail.com>,
        Charles Mirabile <cmirabil@redhat.com>
Cc:     linux-kernel@vger.kernel.org,
        Peter Robinson <pbrobinson@gmail.com>,
        Serge Schneider <serge@raspberrypi.org>,
        Stefan Wahren <stefan.wahren@i2se.com>,
        Nicolas Saenz Julienne <nicolassaenzj@gmail.com>,
        linux-rpi-kernel@lists.infradead.org,
        linux-arm-kernel@lists.infradead.org, rh-kdlp@googlegroups.com,
        Joel Slebodnick <jslebodn@redhat.com>,
        Joel Savitz <jsavitz@redhat.com>
References: <20220823174158.45579-1-cmirabil@redhat.com>
 <Yxaul73DR7BVT7/C@debian.me>
From:   Matthias Brugger <mbrugger@suse.com>
In-Reply-To: <Yxaul73DR7BVT7/C@debian.me>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?L1ZqYzUya2YxQXZxb1hVYXZGdGk2emc5RjY1UlJlbm9mUXZ0bkNyTXJjeWZi?=
 =?utf-8?B?OW90Ulp1QmJaYzNyZ0dPOWYyZnN3OHB0UlArL0lTa3NScjFVU2MwZkZ2VXUr?=
 =?utf-8?B?Qzl3RWJLZFFFb2doWDc3aHpyMVN2OFY3Z3JOMElPYkE4YXJvNmxnOGxYM21P?=
 =?utf-8?B?UDJEUmVRaFV0QVYveXR5NU5tU2pDTjRDUFZLbHJBY3g2ck9GN2szTC9MSTQ5?=
 =?utf-8?B?Y0J3cjFIYWU2UkJLeGI3RXJ5WHJGWTRSTSsxUkwrZHlzUFFyZ2h1ekRQWTd4?=
 =?utf-8?B?K1dPb2xDelVwWmI0WHdvRzBsdnZnSEpPU2JxNWhwaVhkR01aUGFUNWdPUW1L?=
 =?utf-8?B?bnFYODV4d09kM2swRlJyaU53d0ttbEViZ2g4dEFBVXdhbHlJeStvRFNVUHoz?=
 =?utf-8?B?UVcyTjJhb0FhV0NyczlvTEMwRGh3VXpCaWFvOTRDQUNEZVZicU45dC93WXNq?=
 =?utf-8?B?TG9NTXlORUd6b2drVmExMWJRRmoyTEJidHpZbW1CUGJyVFlkeVpHdm0wdzdJ?=
 =?utf-8?B?dk80OFBZK24vdDl3ZVI3dXZpWDhBdkI1aU94WkQvd3dwbkRyUmpFTnY1WHNO?=
 =?utf-8?B?TGxtNTE5bnZmdWFmZGhTR21YWHBMRTNmbE1iQTJIazBxVkxVdkVmNk5QS2xr?=
 =?utf-8?B?b3h6bnBCTDdGZzQ2eUR2cTZqQ0xRWEUwZVBuOHRCc3dyRG05UXZ1VEFIMHpw?=
 =?utf-8?B?NVpYVnVBNlU1QXhyZkIybDJycTRGa25QWHJJM2dYbXVpU2ZqYXRIUHNtUklq?=
 =?utf-8?B?MXZBTFJ0YkVmWlFYUi8rNGE0bmwxY0NXOGRrcjBxV3B1MWZwbEFjamJzSnJi?=
 =?utf-8?B?UXAzM3Y4cUN5UFZTVUROL2N4anVMV2k1US9QZ3lWOUZFQlRYcXZoM2JLWkJH?=
 =?utf-8?B?Sy95T0xGRm81L1F3R2hBTkN3d3krbHEweUowQkllc3ZDcGQ0THRQd2pLK1FB?=
 =?utf-8?B?NWtYNTdmR293aXlDbWtOYkFSbXdyNGlnTjc5WXJlZjJ4SmEyazRzMGlRN1d2?=
 =?utf-8?B?aW5WQWc1UWdoKzYzYWsrQXZRQ2pDalU3QkhvcUhlckdCcjZlWDg3ZmJLWk44?=
 =?utf-8?B?NHNKNWdFVkVRc1NacGRsZk5ISmdleG1UdE05MW12UWNKTVlGbzhiRHBqaHFC?=
 =?utf-8?B?QjkycnVob2FLZ0NNaHEzNURMNVkzOU5yM3UvTnZuNmg1L2xvdzkzUUJHY2p6?=
 =?utf-8?B?K1czU25Wckg0SW1QTHhzbVNwSG94VngyNnlDekF6WWJxWmxtS2hkNWMrcEZz?=
 =?utf-8?B?Sk55MzJKYTZJVUpEcUlRMDgrZll4S2gzRFordEcvckpBVzEzNUs5OFJWekpl?=
 =?utf-8?B?NnJJOUFGZXgwZmZ3U3NieXMweHpQeENHaEJJcGp1SHkvYmJhdVpyc3VLQUln?=
 =?utf-8?B?WEhkVXRNekNQTGtFclFUOGYrbHk5TEJqeDZZM3BJdjBuQ2xwY09jSUIrQjdU?=
 =?utf-8?B?TlZqWGxsUm9Kc1VGenVydmVHYUErdmxXNHhZQXdBYWdtNFo0V251N2YxSFFu?=
 =?utf-8?B?MGRNL2cxUWtVeTdTQjlnMTJBRFUxcC90YnljQ3ovelJkNzl6cXl2UHRnaVNJ?=
 =?utf-8?B?NDE2Q3pnZCs3d01wbVRadGpDTFJJdEZJT0VCWjRNQjRJaVN1d2JFWlBveTgw?=
 =?utf-8?B?TGtEZ2tFMEIvbGJwL1VGd1lEZm05eDJFWGJudk03OTZiM09jQUN6bFVISW1F?=
 =?utf-8?B?Wk1UTURnYXVXWGlPQTdTUnJZak1jTWNJR1FqMGJxWE1tTWFnaXJqcmE3MStI?=
 =?utf-8?B?VG82RmZYTjhQVHFHalJadkpQYjFHMEp3aDc3WDNjN094KzFTazZQTGxNSkc3?=
 =?utf-8?B?dUp6cUg0RnFQc01mVVdxeitLZk41STlRei9HZElmN0YvSDFYUmFnTjN2dVNk?=
 =?utf-8?B?V2xtOEhiRkhTRzZyOUttNFdWWWJ5RHdvTVZYRzJMYUZaRTdZNEpoRGpxT2Zy?=
 =?utf-8?B?b2FvejRWWW1pTDY4dXNLVWxmQTErUzE0TXpGUm8vQmpCWGlUTmpRSzJiTEwx?=
 =?utf-8?B?K3ZLNFllNlcvQzhRM3BjeTVJWjVSTVdUcTRNNW05N0JRWkhCZ1NCUlA5cGxz?=
 =?utf-8?B?M0dKVzZZN0Y1YjRzRWtUTFJocGFhbmdRREtraUJkZlcwSmV3ejNhZTdXQzY0?=
 =?utf-8?Q?B4GAZpG2iqqAhwQH0634J4rM5?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: f3331458-bf80-4ddd-ac45-08da8ff612db
X-MS-Exchange-CrossTenant-AuthSource: AM6PR04MB5366.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Sep 2022 10:53:46.8865
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: nwrg0gNo+JvYYUrPd8pdfDY3R4KsYD5LyjywuMcKGPfBSetk4jsgyNpG73aOihOy8FgUzX0j834vM9N0YRaSCA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: GV1PR04MB9102
X-Spam-Status: No, score=-3.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,T_SCC_BODY_TEXT_LINE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 06/09/2022 04:21, Bagas Sanjaya wrote:
> On Tue, Aug 23, 2022 at 01:41:53PM -0400, Charles Mirabile wrote:
>> This patch series adds a set of drivers for operating the Sense HAT
>> peripheral device. This board is an add on for the Raspberry Pi that is
>> designed to connect using the GPIO connector and communicate via I2C.
>>
> 
> Better say "Add a set of drivers for Sense HAT peripheral add-on device
> for Raspberry Pi. The device is connected using GPIO connector and
> communicate via I2C".
> 

The cover letter won't be part of the git log, so as long as it's understandable 
it's OK. It makes no sense to review the wording...

Regards,
Matthias

>> This is a refactor of the work of Serge Schneider, the author of a
>> version of this driver that is currently in the Raspberry Pi downstream
>> kernel. We modified his code to make it suitable for upstream Linux.
>>
> 
> s/We modified his code/The driver code is modified/
> 
> Also, I see that description of individual patches is written in
> descriptive mood. However, it is preferable to write in imperative
> instead (see "Describe your changes" in
> Documentation/process/submitting-patches.rst). The specific suggested
> wordings are in reply to each patch.
> 
> Thanks.
>