Received: by 2002:a05:6358:bb9e:b0:b9:5105:a5b4 with SMTP id df30csp4233052rwb; Tue, 6 Sep 2022 04:49:00 -0700 (PDT) X-Google-Smtp-Source: AA6agR5oBrt/nvaj7ki4CHl6XfBbgZDwGxGlGCWMoH547QB76dj1Vsebtkce+hPwCa62hLD8KavE X-Received: by 2002:a63:6f0c:0:b0:42a:55fb:60c5 with SMTP id k12-20020a636f0c000000b0042a55fb60c5mr45583006pgc.192.1662464940584; Tue, 06 Sep 2022 04:49:00 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1662464940; cv=none; d=google.com; s=arc-20160816; b=K/ck6ZSJKHLg9qqostyvsOKcZP+eNoygikNjzVd9XeI7VjjNURa7PxKvfiDxO7R2Oj UNK9NUo1GaJT56zRgyF4Pv9RJI+zLNgbj6BnLpEOTi+msQY8U1efdfPA141hZ+iSOi+U cd1wbNkMlxWCkAAAvfNsPSsu5lzJmIRg7G8Tun5cHv9yVZ+wIdatT5U3nEoSSYcm0zs7 noHbFhoAGdqeXhlfwhqzM9kRB/qYMEE3ahwc374Nd2hVmsF/mcWXMq/0dQ3r/mzSpJtY THbQBlREn8+aKb3We3nCguIbAdZ1me3qjuaZvnC1keukxYYUuyCtj0DcLkyLlKw6Bsfp uBgg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:in-reply-to:from :references:cc:to:content-language:subject:user-agent:mime-version :date:message-id; bh=AglkV/77DULwQx+7aJp+lX2hru/tcuTY/HSCeAGkmp8=; b=E470WDwEt+iTVwXfykc/5sIPObc2MZVtSvI6M9aB++bU350OU0PsbdqDpwblVDfYqt ggnwlAlTETI7/oMuYFDbEowCOFvrrvNrE6pKlJ5b3QVgjHWg49BbzeFKmbxoXf/4yklS UwG8qg/HJI/OwPmcy4H2pAd9CMY/hjwDytrPCiv2dhop7IZlZKmYgjDLzXj0uZ6ovbaF EybZ8fU5r2tV9hxreM/Qgd7SeBVxvXYZrwgNHCeGjVTJRHGHVdarqpxNIgZ69gHo0SxN uWD2HFlGRiSUMe0V07R5MEBGmWedILbWAcfe5TtUMVoyKR0t3hpPuyUTObWLIpG5XRAz Dx4A== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=arm.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id g3-20020a1709026b4300b00171311470f7si1864960plt.3.2022.09.06.04.48.44; Tue, 06 Sep 2022 04:49:00 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=arm.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232447AbiIFLmq (ORCPT + 99 others); Tue, 6 Sep 2022 07:42:46 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34022 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232384AbiIFLmn (ORCPT ); Tue, 6 Sep 2022 07:42:43 -0400 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 29B123A4B5 for ; Tue, 6 Sep 2022 04:42:43 -0700 (PDT) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id E59AE139F; Tue, 6 Sep 2022 04:42:48 -0700 (PDT) Received: from [10.57.15.197] (unknown [10.57.15.197]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id ACCB33F534; Tue, 6 Sep 2022 04:42:37 -0700 (PDT) Message-ID: <5f4d77c3-ec58-659e-0b03-a799b3782a31@arm.com> Date: Tue, 6 Sep 2022 12:42:32 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; rv:102.0) Gecko/20100101 Thunderbird/102.2.1 Subject: Re: [PATCH] drm/amdgpu: cleanup coding style in amdgpu_drv.c Content-Language: en-GB To: Jingyu Wang , alexander.deucher@amd.com, christian.koenig@amd.com, Xinhui.Pan@amd.com, airlied@linux.ie, daniel@ffwll.ch, evan.quan@amd.com, mario.limonciello@amd.com, Felix.Kuehling@amd.com, andrey.grodzovsky@amd.com, olomon.chiu@amd.com Cc: dri-devel@lists.freedesktop.org, amd-gfx@lists.freedesktop.org, linux-kernel@vger.kernel.org References: <4362da59f466d8c41c9a3ea91348266280b6a594> <20220904191513.15159-1-jingyuwang_vip@163.com> From: Robin Murphy In-Reply-To: <20220904191513.15159-1-jingyuwang_vip@163.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-8.7 required=5.0 tests=BAYES_00,NICE_REPLY_A, RCVD_IN_DNSWL_HI,SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2022-09-04 20:15, Jingyu Wang wrote: [...] > @@ -565,8 +566,8 @@ module_param_named(timeout_period, amdgpu_watchdog_timer.period, uint, 0644); > */ > #ifdef CONFIG_DRM_AMDGPU_SI > > -#if defined(CONFIG_DRM_RADEON) || defined(CONFIG_DRM_RADEON_MODULE) > -int amdgpu_si_support = 0; > +#if IS_ENABLED(CONFIG_DRM_RADEON) || defined(CONFIG_DRM_RADEON_MODULE) Hint: read the checkpatch warning again more closely, and consider what IS_ENABLED() does and therefore why this is still not quite right. Robin. > +int amdgpu_si_support; > MODULE_PARM_DESC(si_support, "SI support (1 = enabled, 0 = disabled (default))"); > #else > int amdgpu_si_support = 1;