Received: by 2002:a05:6358:bb9e:b0:b9:5105:a5b4 with SMTP id df30csp4272013rwb; Tue, 6 Sep 2022 05:21:34 -0700 (PDT) X-Google-Smtp-Source: AA6agR62lJrvdt2O3Lhsh/1UIaRLeafhqxZU8kyfxZOmMvJL7ID2SMM3/5IMc9TxlvuKEfvVhYYI X-Received: by 2002:a05:6402:1f13:b0:44e:97dd:7b77 with SMTP id b19-20020a0564021f1300b0044e97dd7b77mr6727308edb.300.1662466894060; Tue, 06 Sep 2022 05:21:34 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1662466894; cv=none; d=google.com; s=arc-20160816; b=K2hf6jCJZfVul/0wFAu3Zggbu0JFWzR5wFk9mP06EfhrGCVR8fe/6zkEl4auJ4cEwp /3w6KxVaRfSbLUczOZ8Jyhs1h5wsjdCIVZ5wDG4fZdWDSvEJGGwx1UxPlR0TbnDtQYyM e9mGyqhjCliwmc2pv+nn70YkYJc+jOE5ubq3bgE7UzTFgdPtu6h0NWX4zsl5ZOMcqxuA xgKKjnhafWQ+/CQYqT9F/6mB0HBzQJEePZav/cWPDZqEl/hficC8RsMndmmvkLdsM647 mbgJvWK/WW968z835MT+s1lvi2ugMJRNkq7CUH37Q4xBo2BFmnKaZxZ7OqTyD4eJfbQ1 X4qw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:user-agent:references:in-reply-to :subject:cc:to:from:message-id:date:dkim-signature:dkim-signature; bh=VYd9KqtaGym9N3B6x/APXqGLrtikSgVt1GlBl0IGkU4=; b=A/pCmDZLoG8uX9EUSPM0yYibaGIXJV7IZ9wByQqj1WSBLUsG9phOBFBy3Hp1s92RRw YGngs+yt+nHR7tsJ5mkpKyY+OQn8Rj3AC59WtXDLxrgpcAoSAq8/o2nbIah/L1sl2D2Y jBE9MXUm6U05QUOqyT51CZ26g9UaOw7OuJ9tLNvwFcPYiT29+Gpg9A/3y0/++/ugf9MB re0265bY/JNZ1o254RYPViZUkY5G0P38nnHMemeL4brJxmw5P+B3IZ7u6aNlPEjFbCOa V/tHE2Cm/J1gSJ3RVWg4EQ8XqIThb7ct8f9zRPQ0kBHOl6+Wl8O7UsmFlgqUQoORVJM1 U+yQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@suse.de header.s=susede2_rsa header.b=DZ2b6xOZ; dkim=neutral (no key) header.i=@suse.de header.s=susede2_ed25519 header.b="pRLA/3gH"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=suse.de Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id sa24-20020a1709076d1800b0073d6dc47b12si9425227ejc.606.2022.09.06.05.21.07; Tue, 06 Sep 2022 05:21:34 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@suse.de header.s=susede2_rsa header.b=DZ2b6xOZ; dkim=neutral (no key) header.i=@suse.de header.s=susede2_ed25519 header.b="pRLA/3gH"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=suse.de Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234197AbiIFMBk (ORCPT + 99 others); Tue, 6 Sep 2022 08:01:40 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58736 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234355AbiIFMBd (ORCPT ); Tue, 6 Sep 2022 08:01:33 -0400 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BDFD2785A2 for ; Tue, 6 Sep 2022 05:01:29 -0700 (PDT) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 681171F9DD; Tue, 6 Sep 2022 12:01:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1662465688; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=VYd9KqtaGym9N3B6x/APXqGLrtikSgVt1GlBl0IGkU4=; b=DZ2b6xOZZtc4ZDcz/zCUSoe+wKo85hlzdMySiorZVds83DEyIn78jjZuhybxTgHfELxOZ5 d/DJPKSpYIVJaa7uPV5z+nFuRndO4K7D2Ew3qtd5IplVUHB2TIUrAYbIRwhRPgP+aosCfz Cjho+/vHn95mpkQVjl5LngRUf4Wh6nc= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1662465688; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=VYd9KqtaGym9N3B6x/APXqGLrtikSgVt1GlBl0IGkU4=; b=pRLA/3gHiN0EMikTKvqnBghBMpKB3/9Ilfax9dnMyTmxA/xZWzA7TZ/L6eEWF3QCe1lQXD QNlGwht7qrYJVVAA== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 3981D13A7A; Tue, 6 Sep 2022 12:01:28 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id 8pBBDZg2F2NnNgAAMHmgww (envelope-from ); Tue, 06 Sep 2022 12:01:28 +0000 Date: Tue, 06 Sep 2022 14:01:27 +0200 Message-ID: <875yi0hfu0.wl-tiwai@suse.de> From: Takashi Iwai To: Andy Shevchenko Cc: Lucas Tanure , alsa-devel@alsa-project.org, patches@opensource.cirrus.com, linux-kernel@vger.kernel.org, James Schulman , David Rhodes , Richard Fitzgerald , Jaroslav Kysela , Takashi Iwai Subject: Re: [PATCH v1 1/2] ALSA: hda: cs35l41: Call put_device() in the scope of get_device() In-Reply-To: <20220905165826.35979-1-andriy.shevchenko@linux.intel.com> References: <20220905165826.35979-1-andriy.shevchenko@linux.intel.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) Emacs/27.2 Mule/6.0 MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,SPF_HELO_NONE, SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 05 Sep 2022 18:58:25 +0200, Andy Shevchenko wrote: > > When put_device() is called in another function it's hard to realize > that and easy to "fix" the code in a wrong way. Instead, move > put_device() to be in the same scope as get_device(), so we prevent > appearance of any attempts to "fix" the code. > > Signed-off-by: Andy Shevchenko Applied both patches now. Thanks. Takashi