Received: by 2002:a05:6358:bb9e:b0:b9:5105:a5b4 with SMTP id df30csp4312865rwb; Tue, 6 Sep 2022 05:58:37 -0700 (PDT) X-Google-Smtp-Source: AA6agR47oGpkvE/3V3T15UcqOC7bwdt3UExZ3XmSa9A91qNoe9NAsL1fP0jFbi5S9kqDcyBdoZL9 X-Received: by 2002:a17:906:bc87:b0:73d:bacd:84e2 with SMTP id lv7-20020a170906bc8700b0073dbacd84e2mr37130239ejb.494.1662469117341; Tue, 06 Sep 2022 05:58:37 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1662469117; cv=none; d=google.com; s=arc-20160816; b=aU5Ph/O77yBsrePfitsyfUGHgOCKV9WNg/6c3H0DpU3tp1PWFc1+YyPV9MPiUby+oF oIyl3+XTYd7B/tE4ujpBTS4xdUEX2UdPyaL57cRUqYCpxlnua5jMyMYSQMmGR/fXRAuL WdzEv5LUwBlqZPkaetb3B/j+AJBlsz1M7Jal7dvnNX7b+YTxF+o9cFlrqCpJ92zh3TCX iO3CWv0lAeGhmGE2ExuXVu8KrEpsWvEQx+LMXjL3oDD1wX3Ao+A480Cx2ffrjvRbY1yQ y7lHpBOJ3r+ONvwKMXwoY9/r8yW4xS7CDVjhIvJpSCeWPYuvEQUYj9yXgYrtw3kF+ufF N2ng== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:user-agent:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :dkim-signature; bh=iD5vnnkH4UcJ90oIy206QULA38zABVCOVMqhL/iaAcU=; b=zxFQP7Aevh3kC6eDlekiqdYnqZInSXYCWwKgDyfa1cpe2wybRddrUcKfGBQ9ppNOT9 l3FErRsmReP6U/9FA2JaBU0wU5oe20TwJEX+5n6WuHIpSuldrFYwrwdjFWAGzRLjzoXV +P0WNP95PbZHFBTF3BadD4fTsksZMBNPym5nci2+cjw/gLj1F0LREhcwsL+WG9OZllwO +iYojY6BVvYle42pdvq5OJFp4Hemnnhih427HF/UsIbs4LCdS3WOjGLOlS898s2Y8riz mbbiJSQN0zXHm5o0cgNMqheFMdfciay4+kaavwmmmaN3aWwQljr9RrWef8auomjONG79 vPbg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=eMeqLAnA; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id dt2-20020a170907728200b0072a92eb16b7si10509105ejc.5.2022.09.06.05.58.05; Tue, 06 Sep 2022 05:58:37 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=eMeqLAnA; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234408AbiIFMLL (ORCPT + 99 others); Tue, 6 Sep 2022 08:11:11 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46116 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233086AbiIFMLK (ORCPT ); Tue, 6 Sep 2022 08:11:10 -0400 Received: from sin.source.kernel.org (sin.source.kernel.org [IPv6:2604:1380:40e1:4800::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 80DC7786C9 for ; Tue, 6 Sep 2022 05:11:09 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sin.source.kernel.org (Postfix) with ESMTPS id D016ECE1745 for ; Tue, 6 Sep 2022 12:11:07 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id A3A5BC433D6; Tue, 6 Sep 2022 12:11:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1662466266; bh=iD5vnnkH4UcJ90oIy206QULA38zABVCOVMqhL/iaAcU=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=eMeqLAnAERRjKsfVorqirrl1cjBNpOaYDKSYeI5jdk3XsQyzV7AKGDFVsMFo2vmmt 5ue4NXiAizrw+fLjqsrI7MQEJ5k3QUKn4r2znt1dtinORki7aJVpL/a2HU85MwexYv FonF0lg5+wn8TaSFae6gSK/+6QOgirMhHmzW3Ryop1RA1qiDcJ5ohpzY2Vn3CkeXvG wv4eqkf2ozhHGzqLave6TS67xvP/Oy53UpUQCXizDJirofRAUXDGzrPxRGnc9d/eTK qqKXMYseZy7WHQPMoQB/vpG5p7xX3F65W5Hom3i4Q+uaZVgD/pPLS5ZADXZH4lIF37 dmfa7pVei51wg== Date: Tue, 6 Sep 2022 13:11:01 +0100 From: Will Deacon To: wonder_rock@126.com Cc: catalin.marinas@arm.com, ardb@kernel.org, frederic@kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, mark.rutland@arm.com Subject: Re: [PATCH 1/1] arm64: preempt: Add NEED_RESCHED to the preempt_count() Message-ID: <20220906121100.GD29066@willie-the-truck> References: <20220905141829.28605-1-wonder_rock@126.com> <20220905155013.20118-1-wonder_rock@126.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220905155013.20118-1-wonder_rock@126.com> User-Agent: Mutt/1.10.1 (2018-07-13) X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Sep 05, 2022 at 11:50:13PM +0800, wonder_rock@126.com wrote: > I know it is wrong. I just want to say I think preempt_count() need include NEED_RESCHED Won't that break everybody expecting a count? I'm not sure what you're asking from us here. Will