Received: by 2002:a05:6358:bb9e:b0:b9:5105:a5b4 with SMTP id df30csp4357338rwb; Tue, 6 Sep 2022 06:30:30 -0700 (PDT) X-Google-Smtp-Source: AA6agR5basPrM9ELYVbZZqGaB+l+/qeuG5oFSKfSK0Yk8lSRceCOugaGsU/gBHzAk9f7g+BOBgiC X-Received: by 2002:a17:907:720b:b0:731:6e49:dc93 with SMTP id dr11-20020a170907720b00b007316e49dc93mr40291659ejc.421.1662471029838; Tue, 06 Sep 2022 06:30:29 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1662471029; cv=none; d=google.com; s=arc-20160816; b=COzhzzHThsETMr9IN9ahPNFrOpf4oRSHLMPMjYZiW9PXY/xKKYnrTI8CKGFd0mC/z3 SaieEzBHxvPQSpBqmzFsN+KmKf0R2ZRMtbb3d//+SP73zhK58EnVKaih2K05v54nwptO C+XzG3NOhUv1NyJGXhMbDDDprGK7atml8ZvjLcSmu2parnIZ2LRdZYrcHrRZRZv3uBDw k4EGTuLywRaEGWzVn++Z+N73d0tla8oBvArzMIf8WqSO3Lded/Uqtz7ySfbPScVkfeo1 7PGucLOUri7Y9Ylmi9HFasWfWwnwVcvyHfZoeYtL7//x30op1R7OgcvkMDI8v4yiiHBT Lt2g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-transfer-encoding :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=ltUEIByttK7ZC2ErH3yNigjAIFfS6yB/VrOe1oECD1w=; b=Hc51sY+Ybn2a+ZWEMTQEfPXaVRzpN7BTsa4jO1e+uY8HvefSZHggqA363O58PgJMdT Ll/EvlPeLE03facJeVuec09mvhK5NeHgjaFwzWKQI+NXJpBzhzy3is7EXB1TwwaI5dKi gFSCwG37djN41hiCR55FxtnawIqopMbejwI7UPj0N0/gPqua6N1CPU/4Kz+/q6/lhy9W 2I6PyKZTFEmNHh7YnnJoFGAnFR8Qdg04sfK0CiZ4ytHtkZvHYNYp3kxQjRqQxG+DWPQr jigQ3uCwhHDX/ZJlSCPeLr9YuyhBZWc4VvGwxWIsZr3nMpOLGvoLDmGhCtNKJgA6tQE1 BJRg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=ucylPzXr; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id wy1-20020a170906fe0100b0076f4466cde5si980865ejb.488.2022.09.06.06.30.02; Tue, 06 Sep 2022 06:30:29 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=ucylPzXr; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S240325AbiIFMyR (ORCPT + 99 others); Tue, 6 Sep 2022 08:54:17 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41048 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S240211AbiIFMyA (ORCPT ); Tue, 6 Sep 2022 08:54:00 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BD07D74E26; Tue, 6 Sep 2022 05:53:31 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 8E6B661500; Tue, 6 Sep 2022 12:53:30 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id C12C3C433C1; Tue, 6 Sep 2022 12:53:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1662468809; bh=fldsy+P2Q7PF4mFLFUGFtLZ/KojrACP13eE47+4QOLs=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=ucylPzXrD7R0fNl3OILAPn6lz+kQHL5B9dok/3TaEJwy3KnlDGitr9hTyiSekDiQh 5VuZvSYD6NEPcREhkN07Xkfvw0HQbuaPgKeDhKCHwiQjh8UuoDiSnESGR2yAe1FJVS o4oFsHDScad7GIEe0i0F57qOvna5Np7Yvr+4xSyVQYQJ5boQQ4bmqHWeRdkC8OCVu0 JooftswuuOGi01wdQBIrLio2pKEOvLixctayUf8XiiJ6sggHG8NICrHgPnPU7kSNNb K+9EKGKsWrcJ0KIDTw4F2umkPmJJQBjRygFfWt0yOIAdsMqw1OUG616hGKMu++Bu6m /OuUEKVFxY6sA== Received: by quaco.ghostprotocols.net (Postfix, from userid 1000) id 8253D404A1; Tue, 6 Sep 2022 09:53:27 -0300 (-03) Date: Tue, 6 Sep 2022 09:53:27 -0300 From: Arnaldo Carvalho de Melo To: Adrian Hunter Cc: Jiri Olsa , Namhyung Kim , Ian Rogers , linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org, Peter Zijlstra , Ingo Molnar Subject: Re: [PATCH V2] libperf evlist: Fix per-thread mmaps for multi-threaded targets Message-ID: References: <20220905114209.8389-1-adrian.hunter@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20220905114209.8389-1-adrian.hunter@intel.com> X-Url: http://acmel.wordpress.com X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Em Mon, Sep 05, 2022 at 02:42:09PM +0300, Adrian Hunter escreveu: > The offending commit removed mmap_per_thread(), which did not consider > the different set-output rules for per-thread mmaps i.e. in the per-thread > case set-output is used for file descriptors of the same thread not the > same cpu. > > Fixes: ae4f8ae16a07 ("libperf evlist: Allow mixing per-thread and per-cpu mmaps") > Signed-off-by: Adrian Hunter I added these: Reported-by: Tomáš Trnka Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=216441 Jiri made a comment, can you please reply? Applied locally for further tests, Thanks, - Arnaldo