Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Tue, 6 Sep 2022 09:30:43 -0400
From:   Stefan Hajnoczi <stefanha@redhat.com>
To:     Deming Wang <wangdeming@inspur.com>
Cc:     vgoyal@redhat.com, miklos@szeredi.hu,
        virtualization@lists.linux-foundation.org,
        linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] virtiofs: Drop unnecessary initialization in
 send_forget_request and virtio_fs_get_tree
Message-ID: <YxdLg8tI9OtVjbfe@fedora>
References: <20220906053848.2503-1-wangdeming@inspur.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
        protocol="application/pgp-signature"; boundary="S+kjWGQJm00xfWBG"
Content-Disposition: inline
In-Reply-To: <20220906053848.2503-1-wangdeming@inspur.com>
Precedence: bulk


--S+kjWGQJm00xfWBG
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Tue, Sep 06, 2022 at 01:38:48AM -0400, Deming Wang wrote:
> The variable is initialized but it is only used after its assignment.
>=20
> Signed-off-by: Deming Wang <wangdeming@inspur.com>
> ---
>  fs/fuse/virtio_fs.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
>=20
> diff --git a/fs/fuse/virtio_fs.c b/fs/fuse/virtio_fs.c
> index 4d8d4f16c..bffe74d44 100644
> --- a/fs/fuse/virtio_fs.c
> +++ b/fs/fuse/virtio_fs.c
> @@ -414,7 +414,7 @@ static int send_forget_request(struct virtio_fs_vq *f=
svq,
>  {
>  	struct scatterlist sg;
>  	struct virtqueue *vq;
> -	int ret =3D 0;
> +	int ret;
>  	bool notify;
>  	struct virtio_fs_forget_req *req =3D &forget->req;
> =20

That causes an uninitialized access in the source tree I'm looking at
(c5e4d5e99162ba8025d58a3af7ad103f155d2df7):

  static int send_forget_request(struct virtio_fs_vq *fsvq,
                     struct virtio_fs_forget *forget,
                     bool in_flight)
  {
      struct scatterlist sg;
      struct virtqueue *vq;
      int ret =3D 0;
      ^^^^^^^
      bool notify;
      struct virtio_fs_forget_req *req =3D &forget->req;
 =20
      spin_lock(&fsvq->lock);
      if (!fsvq->connected) {
          if (in_flight)
              dec_in_flight_req(fsvq);
          kfree(forget);
          goto out;
      ...
      out:
      spin_unlock(&fsvq->lock);
      return ret;
             ^^^
  }

What is the purpose of this patch? Is there a compiler warning (if so,
which compiler and version)? Do you have a static analysis tool that
reported this (if yes, then maybe it's broken)?

Stefan

--S+kjWGQJm00xfWBG
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAEBCAAdFiEEhpWov9P5fNqsNXdanKSrs4Grc8gFAmMXS4MACgkQnKSrs4Gr
c8hAnwgAr+QWzw860ulBE175xxGhGz+svhuLqPnyhkkQWyLQ+SsHglf6wgX8wyJo
3GImaRGa4ntB59O6CORrt1m7YIFLeCAob1b4AooxalOuXeP3st5ryPhMO81RovYL
L3hVXfFQQeDboa2r7KdH8EyT7sJSrzsOpLQpFfDXOrpDfQrdzZPwSRcU4DHr98QW
0ErLih20bpg/tptA1VY8+qfrXJMUYfFZkfcFgWo6F8GLFJGieGKKxEbAzOczz9IS
7mFLUtaRglCb9dDLItuOZwr40Uipgj1jqKx2JweQx2UYdt8hqZ6yRLbbOvxQH3R5
i+axLSVNdiXXrXNKkTGNKETbFwpEfw==
=3X2b
-----END PGP SIGNATURE-----

--S+kjWGQJm00xfWBG--