Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <18083c05-7636-2155-610b-2d1347f8585f@amd.com>
Date:   Tue, 6 Sep 2022 09:46:10 -0400
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.11.0
Subject: Re: [PATCH] drm/amdgpu: cleanup coding style in amdgpu_amdkfd_gpuvm.c
Content-Language: en-US
To:     Jingyu Wang <jingyuwang_vip@163.com>, alexander.deucher@amd.com,
        christian.koenig@amd.com, Xinhui.Pan@amd.com, airlied@linux.ie,
        daniel@ffwll.ch
Cc:     amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org,
        linux-kernel@vger.kernel.org
References: <20220905083825.23429-1-jingyuwang_vip@163.com>
From:   Felix Kuehling <felix.kuehling@amd.com>
In-Reply-To: <20220905083825.23429-1-jingyuwang_vip@163.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?TjYvaWRYbEFSQWFTTlJFeFJGOUdzMmtwRkF0YmU3U3BPY1czdlpER016UUtk?=
 =?utf-8?B?WnpEWkxRcGRKL3NCTWN4aXREeXI3VkdYREpaLzlZZmczRHQ3YjFOQlRkdkJQ?=
 =?utf-8?B?UXJTN2ZaUWFPUm1qSHp2dzBJQ0JrY1hkbVpEbzBTbDRaQ2lCMWc0RElOUWYz?=
 =?utf-8?B?SFlDdGEyaFUrM1ZUYjZ4YW5oelhhVTJMR3c1dGdIU0xnRzRNcTBFZDZZdVB6?=
 =?utf-8?B?OFJaVHBmb3RIUno2ZFhMK1RFU0p2SXpzaGZJRmNOVnRPVitZd2pEOWFhUWpm?=
 =?utf-8?B?elREWktxSE55L0VQL2dPK081TVJRTk4xNlcwbVRPRDNMckV5bHJUWEtDMVJ5?=
 =?utf-8?B?U3MrQkgzUUk5NDNDaDgzZ3RnR1JWWktCTGV4YUQ3ZUVkYi9nQkJQQTBqU09s?=
 =?utf-8?B?WU5YaGRsWWpuYmxiNDE1dUZMaXdTRmVkZXRUaUxCQnNCcmxRLzkwYlhjaEVV?=
 =?utf-8?B?d1dvR01PakEyNjBrdFdGT1JNQ1NBa0o3cGx6NXRpWTFubWtFUEIxRG9McHVj?=
 =?utf-8?B?czQvUCtuaTF0b1B5YUIzYmsxT2hFMWRhcWxxUHFWbWZUcmVhWkJoS2hCdVQ5?=
 =?utf-8?B?N0NWV1RVRGhnS2UyNDNqTGZYVlJvRHhOZm1Nb2prV0JXREFQdlU5ajBWS1NF?=
 =?utf-8?B?ME5yN2ZXTFZaRnFhZktqcVp0VEw1eUVEOTBZYjhVYXhlMTRWcHlHWDlJNjlE?=
 =?utf-8?B?WlR2RW42K2pIbzNvb3RnS0kzSzRVSW56NmdpQldwaWZGRHFjQ0d5L1RJczZY?=
 =?utf-8?B?VGNwUGNlSVZIY0lPMGRFVkZPTnRYWFJDbDNXcUNrS3B2QkhMaUJPRnFTazc1?=
 =?utf-8?B?OC80M01uSDlubTVwajdkM1ZlUi9WcHQ4bFZpWGhtRWhMYklYQU80ckNhNXdT?=
 =?utf-8?B?SzcyOUFkMXI4S3g3VUtrUG45OVpVRE11dnVBVW4wZlY5K3VyY2t4QTByT0ZP?=
 =?utf-8?B?VUVRZ29GSzFROVRSNUZNamlOUStSd0p5OWxiUXk2WVpWUG9zeGVQU29qeEJ1?=
 =?utf-8?B?YzBRbURpUytRNWlCNEZZMGlrZTZTV0JyZlFDTm8xUDRwSTVtb3ptYmY4b0pY?=
 =?utf-8?B?OGNTak1PSEUySDVqOU5qTURrSndxNjAwZ0wwL29IZVR0MG5Kdzd0VzBwbURn?=
 =?utf-8?B?bVBYdDgxS1dlT2F1N3Jtbm9rdXBQSTZOSjRrT1hLNy9EQ2FOWWJBdm9DcVdu?=
 =?utf-8?B?bTJ5dUpTdmJMeCtkVW1oRVRLREJ2RE82UFBUeFhYQnR5Y1UyM3BMUVljTzIr?=
 =?utf-8?B?K2lXS2QyY3dmL1JXWTVIc2g5SU5FWXVnKzdpeCtVNGtlc1BJMVhmV3RtZkNN?=
 =?utf-8?B?bnVnS0N6d3ZpT05pRFpVTTZIVE5IMlJZOUx0QUQ0QjhlOWVkS0NiZC80Tjhh?=
 =?utf-8?B?MFVyM0JVaXIzbnB1ckF0WDM0SHNRNUR5NlRpNEw4cU5LQ1hRdFp2b3NETXFr?=
 =?utf-8?B?cVRIOGZvVE9iSWlydzR5Y1RvNFBHMnFJWkErZVhQbTJHQllBakgxQUk5SzV1?=
 =?utf-8?B?R2xwK21Bd2ZrS3ZjTkxSZzF0WDVJck9aVUowaE0rd000b2QvR2taN2ZGNVQz?=
 =?utf-8?B?eFhmSU1WQ29xczZCODRCaFREcVJmV25KbHlMTDJGMElKOEk3SlBGekQ3bThU?=
 =?utf-8?B?akJ1WVkxcHdwenNnM2szMTVxQktGcDZiVFZad3k3ZmhBQ2EwWm5XRVNIOVgy?=
 =?utf-8?B?YzhqeGhEQm5tYS9kSE41T2ZYWlZhT01jR0VsZWNIZWZlZHUreVk2UjNhRmwz?=
 =?utf-8?B?UGZjNzl2ODVWV0E0VEwwRWRPeG5mOHlyL0g5eXZaSkppcU1TN2lnSzR6L2o1?=
 =?utf-8?B?a1JpanRGQllFRGRYaUlnTEJIOHVGcExTdGQxcHlhd0dOSXNFMWlGOWx0eXdN?=
 =?utf-8?B?dk9XMVFEUnFGelJ4OUNoNXVBa1BCSzltZThCbXFuNGFKK0RPdlRWNlFqd05a?=
 =?utf-8?B?aXg5RFVYWkFRSUhCUVV2UytXdjBiVnFXMHdvV3BFRFBEN3R2MkpaMnhYMXF5?=
 =?utf-8?B?L0I0YkNNZGppSXpTSUpsUGpPK0FteDViWkdRemUzTDNLMWFJN3pCQitIZHFk?=
 =?utf-8?B?ZUtyYXVHMWFsc0s1TWdKWW5aS1VVR3hDMFhQRlhxMXhzdk9WODNRUjQwU1Fs?=
 =?utf-8?Q?VHl+HD76eGcKRWeS0S5UrxCKL?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: ee4e760e-af8b-49a2-e6ad-08da900e2937
X-MS-Exchange-CrossTenant-AuthSource: BN9PR12MB5115.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Sep 2022 13:46:12.3848
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: FFwyCn+82YE+P/EKE0HtCA06B1feyWb4LqI+w4OpX8nCrJmULIuFiGooWpGGTW6QoPEtTSj0A8P63Zh5J9fzIg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY5PR12MB6226
X-Spam-Status: No, score=-3.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,SPF_HELO_PASS,
        SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no
        version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


Am 2022-09-05 um 04:38 schrieb Jingyu Wang:
> Fix everything checkpatch.pl complained about in amdgpu_amdkfd_gpuvm.c
>
> Signed-off-by: Jingyu Wang <jingyuwang_vip@163.com>
> ---
>   drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_gpuvm.c | 4 +++-
>   1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_gpuvm.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_gpuvm.c
> index cbd593f7d553..eff596c60c89 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_gpuvm.c
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_gpuvm.c
> @@ -1,3 +1,4 @@
> +// SPDX-License-Identifier: MIT

I'm not sure if this is correct. We've used "GPL-2.0 OR MIT" in KFD. In 
amdgpu there is currently a mix of licenses. Alex, do you want to make a 
call on a consistent one to use in amdgpu?

Other than that, this patch is

Reviewed-by: Felix Kuehling <Felix.Kuehling@amd.com>


>   /*
>    * Copyright 2014-2018 Advanced Micro Devices, Inc.
>    *
> @@ -1612,6 +1613,7 @@ size_t amdgpu_amdkfd_get_available_memory(struct amdgpu_device *adev)
>   	uint64_t reserved_for_pt =
>   		ESTIMATE_PT_SIZE(amdgpu_amdkfd_total_mem_size);
>   	size_t available;
> +
>   	spin_lock(&kfd_mem_limit.mem_limit_lock);
>   	available = adev->gmc.real_vram_size
>   		- adev->kfd.vram_used_aligned
> @@ -2216,7 +2218,7 @@ int amdgpu_amdkfd_gpuvm_get_vm_fault_info(struct amdgpu_device *adev,
>   {
>   	if (atomic_read(&adev->gmc.vm_fault_info_updated) == 1) {
>   		*mem = *adev->gmc.vm_fault_info;
> -		mb();
> +		mb(); /* make sure read happened */
>   		atomic_set(&adev->gmc.vm_fault_info_updated, 0);
>   	}
>   	return 0;
>
> base-commit: e47eb90a0a9ae20b82635b9b99a8d0979b757ad8