Received: by 2002:a05:6358:bb9e:b0:b9:5105:a5b4 with SMTP id df30csp4488763rwb; Tue, 6 Sep 2022 08:12:17 -0700 (PDT) X-Google-Smtp-Source: AA6agR4f4G1j1SFCyyt4YVPSYqQx7MVLb/8i0uz4krY5uj5/AvCw84l8n8zANoZ9COq3GRN6hBd5 X-Received: by 2002:a17:906:794c:b0:73d:b881:e3fe with SMTP id l12-20020a170906794c00b0073db881e3femr37340701ejo.570.1662477136919; Tue, 06 Sep 2022 08:12:16 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1662477136; cv=none; d=google.com; s=arc-20160816; b=M6Tya/Q9201pnCMAWK0T0368n7tuoCYOf9gSLrMOoQX22o1SrUZ9eE63jPnfv05Grf f7YbDNzeU1uZSKtTNFYSL2gkI+PikKcK3WxvZcCnRhFyKPqu7L6zYKpJ1B+WorX7l8lo 8cNnjQUmpNXb2E6kV1LyC4QoTGuzgDv7H5mc0TB4zxjLpx1ZDjN+TjfkeD/u7/K3/1Dv di+AxqctmUhBMsvolJBSkTCiSSSdl0IepQ8V8bTMy3kiRAM4va3kwJ9seNWJh3I+U5IA FeL+Bn7iAe1nJVaEG03qkZWDDKvUzzd47ExsLSW5nMWPXiFaZFngm/vT/VnkQm+bn8VX jFiA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=Pg4m/iTemLvca/VKDPsWQMxR0vJYMX1HdFOegI40LFs=; b=SAYIGwE0AaB2PkdrigtnkP7RTar+SgPgUfK7z+p9HqhxgGTXzGQTYBvAgi9KUVExg0 m63HWMTe82qRvfdvGAi2vadT3ha3VA6y+0uFINQko3ONLrz0fg/O7wNAKc1P+deyuDsv ZbpkRbcFntqiChfdBzf49PnCAS8z3h+yTFc5xncYq7oDfqjoAvWHRqI388O3Wg4/M1ZA +Nc94OMaUYmiAX29dCQots/sFA9BblSu6p4w19y1dew5C5SEF59/jwy+MP+RJnbxfNR8 rrGAH6zTbTC9+0CWpBY08yioTykraAFq4vhpk+j/aN/y4PH844ldy0+nlZvBk6TryK4A vD7A== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=mSUmZOEC; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id l12-20020a056402254c00b0044874cf4c88si11086541edb.430.2022.09.06.08.11.51; Tue, 06 Sep 2022 08:12:16 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=mSUmZOEC; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S241246AbiIFOML (ORCPT + 99 others); Tue, 6 Sep 2022 10:12:11 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46644 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S241551AbiIFOKJ (ORCPT ); Tue, 6 Sep 2022 10:10:09 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9B7E186C13; Tue, 6 Sep 2022 06:47:14 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 4FAE760F89; Tue, 6 Sep 2022 13:47:14 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 607C1C433D6; Tue, 6 Sep 2022 13:47:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1662472033; bh=qpDSi8Cq/D9AtkyR6e0dv7yhz5NO/64eV3IVCIZOq4o=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=mSUmZOECasTmTBGqpqCAOvM0rXjlq+iBkr87ueDr6n4l37W9ITIMf+Qgsq0yQkITf ue65WEIuvaIHQTnjvRiMqgJOmGfnqmW7x09CQgMY0vRaZ/PQ/3FNtWl+xj5pXcCdFM 6TefYGADgZsXAeGTLVPEbT9gAgfLAh957D8B5icQ= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Peter Chen , Pawel Laszczak Subject: [PATCH 5.19 124/155] usb: cdns3: fix issue with rearming ISO OUT endpoint Date: Tue, 6 Sep 2022 15:31:12 +0200 Message-Id: <20220906132834.694726677@linuxfoundation.org> X-Mailer: git-send-email 2.37.3 In-Reply-To: <20220906132829.417117002@linuxfoundation.org> References: <20220906132829.417117002@linuxfoundation.org> User-Agent: quilt/0.67 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Pawel Laszczak commit b46a6b09fa056042a302b181a1941f0056944603 upstream. ISO OUT endpoint is enabled during queuing first usb request in transfer ring and disabled when TRBERR is reported by controller. After TRBERR and before next transfer added to TR driver must again reenable endpoint but does not. To solve this issue during processing TRBERR event driver must set the flag EP_UPDATE_EP_TRBADDR in priv_ep->flags field. Fixes: 7733f6c32e36 ("usb: cdns3: Add Cadence USB3 DRD Driver") cc: Acked-by: Peter Chen Signed-off-by: Pawel Laszczak Link: https://lore.kernel.org/r/20220825062137.5766-1-pawell@cadence.com Signed-off-by: Greg Kroah-Hartman --- drivers/usb/cdns3/cdns3-gadget.c | 1 + 1 file changed, 1 insertion(+) --- a/drivers/usb/cdns3/cdns3-gadget.c +++ b/drivers/usb/cdns3/cdns3-gadget.c @@ -1690,6 +1690,7 @@ static int cdns3_check_ep_interrupt_proc ep_cfg &= ~EP_CFG_ENABLE; writel(ep_cfg, &priv_dev->regs->ep_cfg); priv_ep->flags &= ~EP_QUIRK_ISO_OUT_EN; + priv_ep->flags |= EP_UPDATE_EP_TRBADDR; } cdns3_transfer_completed(priv_dev, priv_ep); } else if (!(priv_ep->flags & EP_STALLED) &&