Received: by 2002:a05:6358:bb9e:b0:b9:5105:a5b4 with SMTP id df30csp4490361rwb; Tue, 6 Sep 2022 08:13:20 -0700 (PDT) X-Google-Smtp-Source: AA6agR54oQRK/3i1aKHneDho8UOX5qwpifiOhR4JJUHesDt8TBW2/zlWYDq1QnPclQzuWT6DyEtW X-Received: by 2002:aa7:9dde:0:b0:53e:5af7:ac10 with SMTP id g30-20020aa79dde000000b0053e5af7ac10mr656968pfq.16.1662477200129; Tue, 06 Sep 2022 08:13:20 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1662477200; cv=none; d=google.com; s=arc-20160816; b=pDLiqQzJN6ShaqYMPk+mG8olEV2PHSspIVUUrIlcUIaq3e+SV1EdyGZt7no77HF71w UcwyrgL+sR/CVNi2K/A3BvKa7/t9/CilvH4QtEyfdLHDKXhMmr1kN1EzRjYSW1ztdZiL oEp0qAdqD3g77p1feMXpvFLvJdJFeGlytbd7aMPVN8rBaUK0cXJlhRS8fMMWn1rPTLyL IiKTeAZ3OZswmrKQlLFcJmtVQ7+LSC2T1fBTU4YeLiwHvaSEa4IfhgHRPg3JHRr0Jes3 oCS5C7XdEkEz1xpaUgCtLpf5kAYgp+gpIejAQR5SLE2E/a8mWaNQ87rKR7lQ6t6S3paQ kwlQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=hg95GF17MEzfA78OHjyaKsMJdd/Nl8PNiQRW6bMPUYY=; b=oGAD2rr8d678DAi/atJujI7pAkjc7vzHItmeOSJtHa9PqAfIM9kmZIdlslS040CbHB vwCImqucrBRqZdhxJYkVOjA9e5LpZOwGYBce7T3STJq6B26iAcsFM/NKGw2rqhiD6Clb AxrO0ppxPh437vHdTKDSmD7KC4cPA0FbSLj6Ujwk8L7aZgU1JlSoO7ojJelMqvHTkFCm bTtpHjvvTX+cUxk8OTi8lqsRx+C5hV2ufNFskXu14iaurigEZ7KdWvg9tbYA4EGLiS+6 4S4Tiu14LXfwE7b0JqmfwhUJud71mP1EI9TLnSP5jkdF1m/6hJCa/x7zDvVdElXz40tx TLXg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=QUs1htsm; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id i4-20020a63b304000000b0041bfb11f138si16666747pgf.442.2022.09.06.08.13.06; Tue, 06 Sep 2022 08:13:20 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=QUs1htsm; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S240855AbiIFOHk (ORCPT + 99 others); Tue, 6 Sep 2022 10:07:40 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59382 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S240528AbiIFOFh (ORCPT ); Tue, 6 Sep 2022 10:05:37 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2DF2A857D0; Tue, 6 Sep 2022 06:45:27 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 102276154B; Tue, 6 Sep 2022 13:43:54 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 17129C433D6; Tue, 6 Sep 2022 13:43:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1662471833; bh=1daYR5RpHls9MGo8kFZHl6kckt8BltE2QD2sj07DhwA=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=QUs1htsm98TbSInHu9NvhIDpaeWyLXmW1tY0uFR5MyFNjWyseQIO4s9EzDJGPZqC1 EZaz+D+pq50ZeV0q8O2rr5DhcJGiAh2/DNzrrHTOeRj3lW4k2MHLW5Skvgt0GvQF5M 5v7KmM32ceAnmw8HTUhCFDbBGjnojv5vpERnJhwo= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, kernel test robot , Dan Carpenter , Vadim Pasternak , Hans de Goede , Sasha Levin Subject: [PATCH 5.19 054/155] platform/mellanox: mlxreg-lc: Fix coverity warning Date: Tue, 6 Sep 2022 15:30:02 +0200 Message-Id: <20220906132831.703660968@linuxfoundation.org> X-Mailer: git-send-email 2.37.3 In-Reply-To: <20220906132829.417117002@linuxfoundation.org> References: <20220906132829.417117002@linuxfoundation.org> User-Agent: quilt/0.67 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Vadim Pasternak [ Upstream commit 17c2bd6bea4c32fe691c1f9ebcc20fd48d77454a ] Fix smatch warning: drivers/platform/mellanox/mlxreg-lc.c:866 mlxreg_lc_probe() warn: passing zero to 'PTR_ERR' by removing 'err = PTR_ERR(regmap)'. Fixes: b4b830a34d80 ("platform/mellanox: mlxreg-lc: Fix error flow and extend verbosity") Reported-by: kernel test robot Reported-by: Dan Carpenter Signed-off-by: Vadim Pasternak Link: https://lore.kernel.org/r/20220823201937.46855-2-vadimp@nvidia.com Reviewed-by: Hans de Goede Signed-off-by: Hans de Goede Signed-off-by: Sasha Levin --- drivers/platform/mellanox/mlxreg-lc.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/platform/mellanox/mlxreg-lc.c b/drivers/platform/mellanox/mlxreg-lc.c index 55834ccb4ac7c..9a1bfcd24317d 100644 --- a/drivers/platform/mellanox/mlxreg-lc.c +++ b/drivers/platform/mellanox/mlxreg-lc.c @@ -863,7 +863,6 @@ static int mlxreg_lc_probe(struct platform_device *pdev) if (err) { dev_err(&pdev->dev, "Failed to sync regmap for client %s at bus %d at addr 0x%02x\n", data->hpdev.brdinfo->type, data->hpdev.nr, data->hpdev.brdinfo->addr); - err = PTR_ERR(regmap); goto regcache_sync_fail; } -- 2.35.1