Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <3f8c0e42-07dc-4349-5021-bcb75e640094@kernel.org>
Date:   Tue, 6 Sep 2022 15:43:33 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.2.0
Subject: Re: [PATCH -next] rv/reactor: add __init/__exit annotations to module
 init/exit funcs
To:     Xiu Jianfeng <xiujianfeng@huawei.com>
Cc:     linux-kernel@vger.kernel.org, rostedt@goodmis.org, mingo@redhat.com
References: <20220906111846.58738-1-xiujianfeng@huawei.com>
Content-Language: en-US
From:   Daniel Bristot de Oliveira <bristot@kernel.org>
In-Reply-To: <20220906111846.58738-1-xiujianfeng@huawei.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk


Hi Xiu
On 9/6/22 13:18, Xiu Jianfeng wrote:
> Add missing __init/__exit annotations to module init/exit funcs.

Regarding the Subject, this patch is not -next. I would suggest only using -next
when you are fixing something in the linux-next (which is not the case here).

You can also fix this for the printk reactor. Do you mind re-sending this patch
with including the printk reactor?

If you found it using an automatic tool, please add information to the patch.
Also, try to figure out why it pointed to the panic reactor but did not point to
printk.

Add to v2:

Fixes: 135b881ea885 ("rv/reactor: Add the printk reactor")
Fixes: e88043c0ac16 ("rv/reactor: Add the panic reactor")

> Signed-off-by: Xiu Jianfeng <xiujianfeng@huawei.com>

Thanks
-- Daniel