Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   =?UTF-8?q?Micha=C5=82=20Winiarski?= <michal.winiarski@intel.com>
To:     <dri-devel@lists.freedesktop.org>, <linux-kernel@vger.kernel.org>
CC:     David Airlie <airlied@linux.ie>, Daniel Vetter <daniel@ffwll.ch>,
        "Maarten Lankhorst" <maarten.lankhorst@linux.intel.com>,
        Maxime Ripard <mripard@kernel.org>,
        Thomas Zimmermann <tzimmermann@suse.de>,
        Simon Ser <contact@emersion.fr>,
        Matthew Wilcox <willy@infradead.org>,
        =?UTF-8?q?Micha=C5=82=20Winiarski?= <michal.winiarski@intel.com>
Subject: [PATCH v3 4/4] idr: Add might_alloc() annotation
Date:   Tue, 6 Sep 2022 16:01:17 +0200
Message-ID: <20220906140117.409852-5-michal.winiarski@intel.com>
In-Reply-To: <20220906140117.409852-1-michal.winiarski@intel.com>
References: <20220906140117.409852-1-michal.winiarski@intel.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?aVJsY1M3TkNQUXRyejVzSHR5SjlCOVZlM2E2aTlYbTV3eDF0MTJ1K2VlR2xp?=
 =?utf-8?B?VGcvUm10Z2JoYlhMMzZHZXFNVGVFUFBWRkVLbm1QK0NnTnZjQkR6U3p1d2I1?=
 =?utf-8?B?a1Yyc3BSUjdpSTRVWllwc0hGRDUwNC9odnhvTVppUU1sMDdPUnJkdXlUMVNS?=
 =?utf-8?B?OWZPNTY1dWpKTzFUdkQxSzc1RXcySmVLZG94WWMwaUxUUUpOcXpJVnBrNHkr?=
 =?utf-8?B?VTE1RVlRRnZzSitpd1RnNHZLNFpMOFpGOVo0YitiUFJPWXhMeG1lbXlISnB2?=
 =?utf-8?B?ZFhaN0JTeDMwV3B5K09KZUxDY212VGRVUUNSV0lLNGZ2ck1UZ2pSaVNXWFJr?=
 =?utf-8?B?TExiTXcxMTlXaGNHNmIzMzBrejlrSjdMVE1DMlZSOXNEYVNBcklmK0doeUg3?=
 =?utf-8?B?aURQOE1WL2ExM0NGUkVzcWVVSHJqZk1MWFdrV1NGek5NRG16WWc4NmFmL2Fj?=
 =?utf-8?B?QU11R0JRWWZsZDhsTHJTdUFOdncwRExxUFRVVkNGNVRUMm9KN3A4Qkd6SzBz?=
 =?utf-8?B?aEZpZm9tVnZobEdEWnhqeDFmSVdKU2RobDlVY2tqRGxVelJuMFl5Q0RYQ3JO?=
 =?utf-8?B?ZWsrcVYvc0lXZkd3Tms2WnZ1cTlqc2JRK3ZxMkFuVVNWclpyM0daVHZmajlH?=
 =?utf-8?B?RGtmZEdEQ2dQZzQrNzZrbXlsWDZSUVpSbm1wWHJCUlpZZnJXUWFoNktJVlhQ?=
 =?utf-8?B?YVRKVlFja0l0enNlcEptbStRZitZYmlpVHpjajBxbUJIdUNaTUhHdlY3WUhh?=
 =?utf-8?B?cmw0V0w2VGpkekkzbFQ0aUxEa0dGMGJTUUNMNG0zOXRTbDRlSXc2VVI2OXQ5?=
 =?utf-8?B?V1pEa2hXUUdDRWp1SlVOY1E4dzRaMXM2bWJhMTBWdTBpdXJ0VlZ4bDBqNkVG?=
 =?utf-8?B?NklhVTFqL1M5OW9oRStqaHM1MzJxMXdvL0VZQVF2NzBEQVpjZGp2Q21MQ3JS?=
 =?utf-8?B?YVRJS0FZaEZvZHduc3JXRFl1WlBEdjZHSXYydkFoMCsxNU9MOS9Gell4UzdN?=
 =?utf-8?B?bmc3RlZLOFFLVlV5VEZEWENvUU1XOGdVY0xPLy9qMFRUc0xuS3FxOCtmaHdH?=
 =?utf-8?B?K1FhQmhHYnZUVXgyUEFsY21pV2RTNkQrV1E0VG5na3JrSzRPWGlkbVRJY1Ux?=
 =?utf-8?B?Uldqc3NGMVlZakV5SXJBTHFjV1k2N0IwcUR0di9rN1ZjRjJqNGs2em1LdjlD?=
 =?utf-8?B?OTE3dGRLZzhEMXRUUnFKQzg3UGs1MkNJeC9WeU9yTnZYRTRXaWxOUUxTb1M5?=
 =?utf-8?B?bmVSR244bkJqZWNLQjVhcmdRODk1Szlwd0lXOFlYcnZ2amxGTWFBWDNld2hU?=
 =?utf-8?B?TWhOZm5HNklCRkFsTTNFLzZKcEtCZko2eW1nblVEOUtiY2VscHg2ZnFxTjNH?=
 =?utf-8?B?K0RjSmdUbHEwNG9mS1NpK0xnZm05cEQ0Z0E0WTQwRnZ0b3hBN2t2OEJaeVEy?=
 =?utf-8?B?NCtOVHBWMnV6TFFNazhLb0duYkxVZ2IyNEMrQlFvaHpyZVY0NEVXcmpZUmJY?=
 =?utf-8?B?ZERZSnBQRVFLWGJYdHoyNmRTVUJoWFdSaFdVZUx1UGhjTWg3ZkpiMThnK0l6?=
 =?utf-8?B?QVU2SnZHeFVwazVjaGFyem1JblFjM0dsdFdVYUVVcmt3MEgyVlNQWXIvZWxJ?=
 =?utf-8?B?ZVc1UHh4bUEyZFpuZ0ZwcHhEU09aYWpkaHo1TGhMWll6SHF2ZnRXdk9CYW52?=
 =?utf-8?B?UkdKNGlONVJQRFZ6aW5LSlQvZDBKeURvSUJ2RjZQWk53WnpRSnpYVWEwQ1Zl?=
 =?utf-8?B?ajVFRlpsTVNqRWkvR1FHNVYxanQwajJkR2VSd2xKb3pHNUJQbWE0NHVDTHo3?=
 =?utf-8?B?dXFPMkFJeTJqUDVDL1UvcVFrbnZqdFJvOVhEU3BubXBSejQvNWdJVWhhQWwr?=
 =?utf-8?B?SDk5eFNzc1dWdE5zMWNOQ2RXTXMzL1NEeTQzNmhNMFU0eHVwQVI5MUUxVnN5?=
 =?utf-8?B?dkQvTzgvTHptK2ZRaWJIVUxVWHZWVCtqS2JUSGVYUmM2UzQ1SWthMmxjWEJW?=
 =?utf-8?B?QnBXQmpKUEk2ZENEb01KVUxxTUdZY3cvQk1rL3U5YWg5MHkrRFYweUxRVk9q?=
 =?utf-8?B?bkpSQVhVMFg5cFpQMDN4QjJVS0s1T0pXR01xQndTSVlhSk9TU29oR3ZzcHpE?=
 =?utf-8?B?YjdSRUJheTlwZ3RvWm9MRytteGtEM093aEplUzk0QUJNY3JCakp2aTJUYXJh?=
 =?utf-8?B?ckE9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 25b75f90-7b2a-4e6a-b4af-08da9010620d
X-MS-Exchange-CrossTenant-AuthSource: DM4PR11MB5373.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Sep 2022 14:02:06.6839
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 99ESf6xA4T4oAKjTb1Daz9R0taG5cSe0oUYiqfwremDf8IF+U29x00pTiOrvYBOQ0BW9Ec/3+ikrWJbDupwAB2ZDxwPcfFeI+6jkNmEF3Fk=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN7PR11MB2804
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,
        SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Using might_alloc() lets us catch problems in a deterministic manner,
even if we end up not allocating anything.

Signed-off-by: Michał Winiarski <michal.winiarski@intel.com>
---
 lib/radix-tree.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/lib/radix-tree.c b/lib/radix-tree.c
index 3c78e1e8b2ad..787ab01001de 100644
--- a/lib/radix-tree.c
+++ b/lib/radix-tree.c
@@ -23,6 +23,7 @@
 #include <linux/preempt.h>		/* in_interrupt() */
 #include <linux/radix-tree.h>
 #include <linux/rcupdate.h>
+#include <linux/sched/mm.h>
 #include <linux/slab.h>
 #include <linux/string.h>
 #include <linux/xarray.h>
@@ -1481,6 +1482,8 @@ void __rcu **idr_get_free(struct radix_tree_root *root,
 	unsigned long maxindex, start = iter->next_index;
 	unsigned int shift, offset = 0;
 
+	might_alloc(gfp);
+
  grow:
 	shift = radix_tree_load_root(root, &child, &maxindex);
 	if (!radix_tree_tagged(root, IDR_FREE))
-- 
2.37.3