Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Tue, 6 Sep 2022 17:28:37 +0300
From:   Andy Shevchenko <andriy.shevchenko@intel.com>
To:     Martyn Welch <martyn.welch@collabora.com>
Cc:     Linus Walleij <linus.walleij@linaro.org>,
        Bartosz Golaszewski <brgl@bgdev.pl>,
        linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 5/5] gpio: pca953x: Add support for PCAL6534
Message-ID: <YxdZFRyv5E0qvXgS@smile.fi.intel.com>
References: <20220906082820.4030401-1-martyn.welch@collabora.co.uk>
 <20220906082820.4030401-5-martyn.welch@collabora.co.uk>
 <Yxc8GgUnHOuMIn4p@smile.fi.intel.com>
 <a71dec127a2e188b1eb7df1e385f71410051acca.camel@collabora.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <a71dec127a2e188b1eb7df1e385f71410051acca.camel@collabora.com>
Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo
Precedence: bulk

On Tue, Sep 06, 2022 at 03:01:51PM +0100, Martyn Welch wrote:
> On Tue, 2022-09-06 at 15:24 +0300, Andy Shevchenko wrote:
> > On Tue, Sep 06, 2022 at 09:28:19AM +0100, Martyn Welch wrote:

...

> > > +???????u8 (*recalc_addr)(struct pca953x_chip *chip, int reg , int
> > > off);
> > > +???????bool (*check_reg)(struct pca953x_chip *chip, unsigned int
> > > reg,
> > > +???????????????????????? u32 checkbank);
> > 
> > I would think of splitting this change. Like in a separate patch you
> > simply
> > create this interface and only add what you need in the next one.
> 
> Can do, though I didn't feel you were particularly fussed about me
> having split that out...

Oh, it just would be cleaner to see what you have done for a new chip support.
Up to you and maintainers.

-- 
With Best Regards,
Andy Shevchenko