Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Subject: Re: [PATCH -next] rv/reactor: add __init/__exit annotations to module
 init/exit funcs
To:     Daniel Bristot de Oliveira <bristot@kernel.org>
CC:     <linux-kernel@vger.kernel.org>, <rostedt@goodmis.org>,
        <mingo@redhat.com>
References: <20220906111846.58738-1-xiujianfeng@huawei.com>
 <3f8c0e42-07dc-4349-5021-bcb75e640094@kernel.org>
From:   xiujianfeng <xiujianfeng@huawei.com>
Message-ID: <65bb173d-1a36-283e-4e20-4bbbcac616c6@huawei.com>
Date:   Tue, 6 Sep 2022 22:21:24 +0800
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101
 Thunderbird/78.9.1
MIME-Version: 1.0
In-Reply-To: <3f8c0e42-07dc-4349-5021-bcb75e640094@kernel.org>
Content-Type: text/plain; charset="utf-8"; format=flowed
Content-Transfer-Encoding: 8bit
Precedence: bulk

Hi,

在 2022/9/6 21:43, Daniel Bristot de Oliveira 写道:
> 
> Hi Xiu
> On 9/6/22 13:18, Xiu Jianfeng wrote:
>> Add missing __init/__exit annotations to module init/exit funcs.
> 
> Regarding the Subject, this patch is not -next. I would suggest only using -next
> when you are fixing something in the linux-next (which is not the case here).
> 
> You can also fix this for the printk reactor. Do you mind re-sending this patch
> with including the printk reactor?

No problem, V2 already sent.

> 
> If you found it using an automatic tool, please add information to the patch.
> Also, try to figure out why it pointed to the panic reactor but did not point to
> printk.

Thanks, I found it by review not tools.

> 
> Add to v2:
> 
> Fixes: 135b881ea885 ("rv/reactor: Add the printk reactor")
> Fixes: e88043c0ac16 ("rv/reactor: Add the panic reactor")
> 
>> Signed-off-by: Xiu Jianfeng <xiujianfeng@huawei.com>
> 
> Thanks
> -- Daniel
> .
>