Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <5f29a2e1-4ecb-9f94-1e57-f7d8d3c7afb2@amd.com>
Date:   Tue, 6 Sep 2022 10:52:28 -0400
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.1.2
Subject: Re: [PATCH] drm/amd/display: fix memory leak when using
 debugfs_lookup()
Content-Language: en-US
To:     Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Harry Wentland <harry.wentland@amd.com>,
        Leo Li <sunpeng.li@amd.com>,
        Alex Deuc her <alexander.deucher@amd.com>,
        =?UTF-8?Q?Christian_K=c3=b6nig?= <christian.koenig@amd.com>,
        Xinhui.Pan@amd.com
Cc:     linux-kernel@vger.kernel.org, David Airlie <airlied@linux.ie>,
        Daniel Vetter <daniel@ffwll.ch>, Wayne Lin <Wayne.Lin@amd.com>,
        hersen wu <hersenxs.wu@amd.com>,
        Wenjing Liu <wenjing.liu@amd.com>,
        Patrik Jakobsson <patrik.r.jakobsson@gmail.com>,
        Thelford Williams <tdwilliamsiv@gmail.com>,
        Fangzhi Zuo <Jerry.Zuo@amd.com>,
        Yongzhi Liu <lyz_cs@pku.edu.cn>,
        Mikita Lipski <mikita.lipski@amd.com>,
        Jiapeng Chong <jiapeng.chong@linux.alibaba.com>,
        Bhanuprakash Modem <bhanuprakash.modem@intel.com>,
        Sean Paul <seanpaul@chromium.org>,
        amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org
References: <20220902130105.139138-1-gregkh@linuxfoundation.org>
 <YxIAvHOK7uNum9VI@kroah.com>
From:   Rodrigo Siqueira Jordao <Rodrigo.Siqueira@amd.com>
In-Reply-To: <YxIAvHOK7uNum9VI@kroah.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?SHVmNFNDUnd0UzBQOXRIZkVlVDQxOEJjcjFvS3BiTEJoanUxcXd1VVpWQ2hr?=
 =?utf-8?B?Nm44b1huM3FKeWRnNWxyN2ZkQU1RTmNHQVMxS0lNNXlLdERMN3JXMDZOeWQ2?=
 =?utf-8?B?NTRGajJMcEFrSHBneTFQd3ZDYXhsei9SKy9UZ2FjaVUyaVA3STVnTk5SMzRL?=
 =?utf-8?B?ZFBRWEdDNk94M1NRSURRQkVKY1VPTjVINHR1RGZWWVZLWlM1T2cwODYxaE12?=
 =?utf-8?B?U3NZSXFzRE5Fb05FaG0vcWdHa1ZXR2ZlUXNDZkROdFpIYUdZL2VrSGxuaVJT?=
 =?utf-8?B?N1FzN3JwKy9ybXRvT0RwbjZYYkFHMWlReEtPNkdQNXhPZjVFNzdOM252QnNJ?=
 =?utf-8?B?UjhxMVVYWXlmTFd6SCs4OFcreGpaMTRCblpVY01DQzVqcjBNbkpQMm5LR09T?=
 =?utf-8?B?ZkkxUWI3SjFBaGVqMG9QeEwxN0ZSZDMxVERJRkFOY0V2NStUcDV3eFVwbHBa?=
 =?utf-8?B?Z1lROVYxVjRDeDhLUERQbXRZU2hXWEkwOG0xY1ZOOVBkWkovTFdGem9abmVS?=
 =?utf-8?B?ck10eVdKZU9PTzBkZklYb3BpaGRnWFFZbUQ4TG1mRzRzMHhXWGlrVmx1K2sr?=
 =?utf-8?B?L05JUHN3Z0h3M0tvb21XZVp3TW5FQ01GMDFrU1V5Zy8waXVsYjN1M3ozUVRP?=
 =?utf-8?B?MW9IQWptYys1Mm14OFZtcWU4QjhUN3B4RjcycEpTRzNLM3Ezb1daYkdydzhT?=
 =?utf-8?B?RU5GVTFQV003Sjk0cDI0S0lrZXBVVi9lWEZncTRyY0JSOUl4WXphT1luT01W?=
 =?utf-8?B?K05la1Y0RXhTeFR2bWswSVJLMHJKajh0TFFkd1NlYStGc3d5aGNqOEdrazZu?=
 =?utf-8?B?Qk1Ec1RlMU4rMHQvTmhXUmxjVjh4Z2dJaHkrV0xNd2lGMHlialNFWnlxY3F6?=
 =?utf-8?B?ZHNsUmRxRTFNMmVXVVVOSU9wMFNoK0pYaWFUaDNOYjdtZTJIVXRtdmNqdmVU?=
 =?utf-8?B?dnFWUjJCejVIVlBELzZDRGNBTHBYRVdhL1NKeDZieUFUbGdQdUh4KzE0WVYw?=
 =?utf-8?B?M2NzYnJ1czZ1c1I0UWc5aHJ1eDJSNFZLcDVacEppZGZiL0lMRHpmaXRLaHdi?=
 =?utf-8?B?TTZrL3NaTTUrWHZIa2xSdE1jbStucks0Z3BBMVBQQmpteXArcmpOREdQZDhw?=
 =?utf-8?B?cjYwUG9DMy93TDMwMnJYTmpmbFVPQmxBS1RFKy9XKzNPYkxNYm5IdHVnNk8x?=
 =?utf-8?B?My9Zakx2NVBCK1lucXZUQ3NXU0RyTTBWeEY4YkxlSkhFaVlzQ0Y0dWNMUlhP?=
 =?utf-8?B?N2J6dzBKbE1hL1VGOG8rd3lIWEdZTVFYazFBTzlXRmFMK3hidkxac1pkM0xV?=
 =?utf-8?B?MThHVVhyckJMdW14MGdrYWdUYVBxT1pkVG9zS01nVmRiTmtqQVNnRnpJekUv?=
 =?utf-8?B?K3RMd1ZxTE80b2FUdDVIb0tuaUl6dU5sa0V0dHJseEpjRkxxdUhJd1Y3V0I0?=
 =?utf-8?B?TElxa25aTXJwZnMzMUh6QkxHNVBRZ3JGSUNSK0tOdHoxWHJFd1F3dlFCRm9G?=
 =?utf-8?B?dHhmMWQyN0lBOUpEa0owdjYxQmVPelgxT3dZRlBZU0Z2NVg3MVQzT1dqQWVK?=
 =?utf-8?B?Z09LQjk4M0E3ODhJbnFJOHZRdW9MOUwyaHlreEVDbDAzQkwxMFJVdVBtZHFk?=
 =?utf-8?B?NUZDVGZlclFqUTZ1SEtUYUVzSlBpb0dIbHJkTzdrY2Y5RnpYTzBRWSszSktZ?=
 =?utf-8?B?VURkMndlaGVwdDU4NW9kZC84QVlXVWVHVktDd2NJNk5NbnVyRHNiVlJEWVJx?=
 =?utf-8?B?MEpubkEzMkMxZkdsYTlML2pyRUtFOG1NZEdrOEF6b2U2TGxPWXdSdGl0RHNj?=
 =?utf-8?B?RDR5RUF2RjhjNVhNSkdoVEdaQUs2VytLSWZkaS9TWU9PWlJPSnlSNEc1MmFi?=
 =?utf-8?B?NGp3SnN0bFR2cERjNURGSVFBR09XMmRmd1htSTYzMkpNSklUNVF4c0NkRms1?=
 =?utf-8?B?dEROTU12WGdNbmg3b1loL1YwMG5zV3ZQNlhWQ1d5eHJVNkRqRGpNdUM0eEZ2?=
 =?utf-8?B?cVpIYURnVlYwZ3ZrMGU3UzMrUldNWnBucmNRZ1ZlY2NIdjB4cjBKVlBWYVNt?=
 =?utf-8?B?cXRGbEd0MVg4MlFOeERjb3RaTTdiM2VNU05MVGxWZnRVNFdVNU1oT3FhR3dO?=
 =?utf-8?Q?nGpqIA+AA1DSknDzhHF8lGxON?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 8b61d363-aa59-4d4f-1cf8-08da90176c6f
X-MS-Exchange-CrossTenant-AuthSource: MN2PR12MB2941.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Sep 2022 14:52:30.8433
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: MVPfqZnNHWAuWe4d+jQ5Dw8e72HpFiwK+Qmgzk5ZXBCyfI9xajprONpBYC/Viy3o61IkPA1pPuxtu26Zch4l/Q==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA0PR12MB4446
X-Spam-Status: No, score=-3.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,T_SCC_BODY_TEXT_LINE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 2022-09-02 09:10, Greg Kroah-Hartman wrote:
> On Fri, Sep 02, 2022 at 03:01:05PM +0200, Greg Kroah-Hartman wrote:
>> When calling debugfs_lookup() the result must have dput() called on it,
>> otherwise the memory will leak over time.  Fix this up by properly
>> calling dput().
>>
>> Cc: Harry Wentland <harry.wentland@amd.com>
>> Cc: Leo Li <sunpeng.li@amd.com>
>> Cc: Rodrigo Siqueira <Rodrigo.Siqueira@amd.com>
>> Cc: Alex Deucher <alexander.deucher@amd.com>
>> Cc: "Christian König" <christian.koenig@amd.com>
>> Cc: "Pan, Xinhui" <Xinhui.Pan@amd.com>
>> Cc: David Airlie <airlied@linux.ie>
>> Cc: Daniel Vetter <daniel@ffwll.ch>
>> Cc: Wayne Lin <Wayne.Lin@amd.com>
>> Cc: hersen wu <hersenxs.wu@amd.com>
>> Cc: Wenjing Liu <wenjing.liu@amd.com>
>> Cc: Patrik Jakobsson <patrik.r.jakobsson@gmail.com>
>> Cc: Thelford Williams <tdwilliamsiv@gmail.com>
>> Cc: Fangzhi Zuo <Jerry.Zuo@amd.com>
>> Cc: Yongzhi Liu <lyz_cs@pku.edu.cn>
>> Cc: Mikita Lipski <mikita.lipski@amd.com>
>> Cc: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
>> Cc: Bhanuprakash Modem <bhanuprakash.modem@intel.com>
>> Cc: Sean Paul <seanpaul@chromium.org>
>> Cc: amd-gfx@lists.freedesktop.org
>> Cc: dri-devel@lists.freedesktop.org
>> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
>> ---
> 
> Despite a zillion cc: items, I forgot to cc: stable on this.  Can the
> maintainer add that here, or do you all want me to resend it with that
> item added?
> 
> thanks,
> 
> greg k-h

Hi Greg,

Reviewed-by: Rodrigo Siqueira <Rodrigo.Siqueira@amd.com>

Is 'Cc: stable@vger.kernel.org' enough here? I can make this change 
before I merge it into amd-staging-drm-next.

Thanks
Siqueira