Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Tue, 6 Sep 2022 12:33:21 -0300
From:   Jason Gunthorpe <jgg@nvidia.com>
To:     David Hildenbrand <david@redhat.com>
Cc:     John Hubbard <jhubbard@nvidia.com>, Yang Shi <shy828301@gmail.com>,
        peterx@redhat.com, kirill.shutemov@linux.intel.com,
        hughd@google.com, akpm@linux-foundation.org, linux-mm@kvack.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mm: gup: fix the fast GUP race against THP collapse
Message-ID: <YxdoQR30GXfTH/6K@nvidia.com>
References: <20220901222707.477402-1-shy828301@gmail.com>
 <e6ad1084-c301-9f11-1fa7-7614bf859aaf@nvidia.com>
 <a969abc5-1ad0-4073-a1f9-82f0431a0104@redhat.com>
 <YxdPi2E63aO0Dgyd@nvidia.com>
 <4516a349-49cb-fd7b-176a-f1a9479906d9@redhat.com>
 <YxdZlCly2ad1rtcI@nvidia.com>
 <40486dbb-9f19-6fa6-d46d-99d2b033883d@redhat.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <40486dbb-9f19-6fa6-d46d-99d2b033883d@redhat.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?ZbF7FP8mYqYoJHcO5yBGRUTbv12lkchZ3sNFPRJIoKlmXMTutFqR0Dz/oOpK?=
 =?us-ascii?Q?adPDYDhvl7aOLqhWJIEgNFvvoIdp7w+Ot3mT8GpBlBCDNmdO7dS9hV9sf/Bv?=
 =?us-ascii?Q?zjA7UQj7nncb6gEFhjRVcv3b8x5OgZsQafRNWDVwponsj5IulgTSEKM7PpMT?=
 =?us-ascii?Q?NWnjBtFN5Z3Zxgpr0K0mein3GSN26mubyFdu0Q7tR3V3xV7+kcFQCzQ2o2A+?=
 =?us-ascii?Q?7oRsmZG0+fKqAfGoWZCzETEoDhdBwcgUQ1Dg56QEjXuR0rutRl9ntAhoyoXh?=
 =?us-ascii?Q?KJBIXG5kIFHGCsFrbOrUwuGZHVw4ckeIEeowU+TmsgppQGQbkWaytE8DSLw0?=
 =?us-ascii?Q?iGJdeCNvvKIz0Kfza94UbwwMQgKqVwPNOJ1ojmJ4l9ltFiCDXw8c9OU3P3Kz?=
 =?us-ascii?Q?Lf2vk5nPBqto2tVxIN3MX4W02IUgRobLPVMEInucemvsC2bg5+kuKFBzUpPy?=
 =?us-ascii?Q?dBIwWsmIqzdsoPGAUXgfT7T82yHcbCBFG6bvCGbpPHvwSAUxqh+E6LPFOVaN?=
 =?us-ascii?Q?n/ICRvyXVOTRVZphFmqVGm2mkJ3PFn+uz2qYGCz23Milno1kpFOThtc9fswg?=
 =?us-ascii?Q?wC69sWK3OQMXoML3tUptZ94KeD3hF2EfR9h5fJj243FUV8bgI2udgnvtNjbb?=
 =?us-ascii?Q?aXJsknFhYYQxHe7LudpeO8titnEKMxCZhTO71VtEOVIysXU0mRpRI3FwLUO/?=
 =?us-ascii?Q?/n9MF1CsLHOuOh+zmebJ2ep9nB3YQLfjAOrJpweYhDF8ozhvIMd1tRinasff?=
 =?us-ascii?Q?YnctdXvgPxYGo/F+Sylhr0r1Hd/0ysfQIiuK80PwPXWc+c+nwMNZCLk4YiF1?=
 =?us-ascii?Q?42IrspYP71ZV60vL0PX2GB1WraZB4IHktFP0P7lxEq+Y2PrMY/AKY5+4wWIX?=
 =?us-ascii?Q?wu46Go3AYufJQowlSpeBFbjnfYAcq0qEsyBelnUt3iNMZN8vHFYvZcU7ilgW?=
 =?us-ascii?Q?dIsMJSvbBIpGQNglLiSF894WG/RTCJ5jje4lx7beTrinS9xYOcUonTUxIu+4?=
 =?us-ascii?Q?EuJWf6JktrJ2+mMcBTGBqd8zTAJB9q3xpAt4kgOKSB9O7r9E00cKimzwBXKL?=
 =?us-ascii?Q?lDeXDzmJztKrzrLI5KsXXkpddWauzRRsaF+QzdGYfk/f5MkeJNazIzRR/qvU?=
 =?us-ascii?Q?gN28/rBMDm2DskUMZboKOL7e14Rg3NqzvPXIGwXNbe5SLirsutO3tRroK/VV?=
 =?us-ascii?Q?dH8g23SkSzZznnmOcCmKuR9EcjzoMrdklg5yPeG9k5f0hPvzInvavLueGAet?=
 =?us-ascii?Q?gHDKb93RqDPYL0qz3FQNxygJZNReHDuFDI7myvBuKvTixWwjkTAFGSJagapQ?=
 =?us-ascii?Q?l1NYJKOJvi7WSttcXa5tXDsIfw2LgeWaBQjMe3XE+9a2Mw8M5cDadfURFui5?=
 =?us-ascii?Q?bqHpyFsjREgRmbcD2CGluL4wNo39Pz+3aczhRQsj4epy9kyfB2TVGccmN6En?=
 =?us-ascii?Q?jr0GYTq3gOZh9npJtOh6PXEAw/gWUTyD+Yw2IwyLCwmpO28yytjvrt8dF0p2?=
 =?us-ascii?Q?S4v1seL2AzSTzXLDqX3BCy5OFFyx/zAHpmL88omwhnLQWoCJzHkyMsSXnROD?=
 =?us-ascii?Q?nV1AO2KL3bCWentCp99PVk+en88sQZ6tSTNBU24N?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 31ecc236-6791-4176-32f6-08da901d2202
X-MS-Exchange-CrossTenant-AuthSource: MN2PR12MB4192.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Sep 2022 15:33:22.7241
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: sAYWzqMobjPYE13FZTYr9n+x0o1vhuYAnjNh2oYb5eIxk6/7gufaCLpEIOBpUD8U
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH0PR12MB5026
X-Spam-Status: No, score=-1.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FORGED_SPF_HELO,
        RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_NONE,
        T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Tue, Sep 06, 2022 at 04:44:20PM +0200, David Hildenbrand wrote:

> ... I do wonder if we want to reuse ptep_get_lockless() instead of the
> READ_ONCE(). CONFIG_GUP_GET_PTE_LOW_HIGH is confusing.

Yes, that is a whole other topic, and you may be quite right on that.

Jason