Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <67fe15fc-bd6a-5eee-4359-5d6244db54ef@amd.com>
Date:   Tue, 6 Sep 2022 11:39:44 -0400
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.1.2
Subject: Re: [PATCH] drm/amd/display: fix memory leak when using
 debugfs_lookup()
Content-Language: en-US
To:     Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc:     Harry Wentland <harry.wentland@amd.com>,
        Leo Li <sunpeng.li@amd.com>,
        Alex Deuc her <alexander.deucher@amd.com>,
        =?UTF-8?Q?Christian_K=c3=b6nig?= <christian.koenig@amd.com>,
        Xinhui.Pan@amd.com, linux-kernel@vger.kernel.org,
        David Airlie <airlied@linux.ie>,
        Daniel Vetter <daniel@ffwll.ch>, Wayne Lin <Wayne.Lin@amd.com>,
        hersen wu <hersenxs.wu@amd.com>,
        Wenjing Liu <wenjing.liu@amd.com>,
        Patrik Jakobsson <patrik.r.jakobsson@gmail.com>,
        Thelford Williams <tdwilliamsiv@gmail.com>,
        Fangzhi Zuo <Jerry.Zuo@amd.com>,
        Yongzhi Liu <lyz_cs@pku.edu.cn>,
        Mikita Lipski <mikita.lipski@amd.com>,
        Jiapeng Chong <jiapeng.chong@linux.alibaba.com>,
        Bhanuprakash Modem <bhanuprakash.modem@intel.com>,
        Sean Paul <seanpaul@chromium.org>,
        amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org
References: <20220902130105.139138-1-gregkh@linuxfoundation.org>
 <YxIAvHOK7uNum9VI@kroah.com> <5f29a2e1-4ecb-9f94-1e57-f7d8d3c7afb2@amd.com>
 <YxdiBRCmhlrRxAz5@kroah.com>
From:   Rodrigo Siqueira Jordao <Rodrigo.Siqueira@amd.com>
In-Reply-To: <YxdiBRCmhlrRxAz5@kroah.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?ZGRpbVh2ZG1uQXZ5YmZzZ3U1cjNnTFZiWjFWbzJQaW1VWVdVVFFROUJtQzgx?=
 =?utf-8?B?TFR0a3ZXdllGaytWUUVpZExlMEluVExXNUJRY0JheHlFN3hYNTZVVERhN0d6?=
 =?utf-8?B?TVVPOEhKKy8wYVBGZzVhTmprR3Axa1JsT0xPR3Aramtza0FwTlZoNDJEQnR0?=
 =?utf-8?B?UEtFMExYQUR5bzRaa3h3dWx2NXdsRUdxRE5pcU9LZElzYk1UWjQrWUQ2eVhr?=
 =?utf-8?B?NTNDUDZ6TWJBUVRCWXdUVk5UbzEyamV2WGwva3FpVlRuR1BlOFdhaitQVDVT?=
 =?utf-8?B?bGU0ZXZYV1pOT3VsV08zTm44aWp0OGFCR1hFOVUzdmU3dWFMUTROWkF4ejVW?=
 =?utf-8?B?N3dHRnA5TXJ0TVRHcUF3eTkzTTA1TWJJTTRwNjZ1U25MQVN1YWtIS0ErUjlF?=
 =?utf-8?B?ZUNyZ1NSMHhCcDc5dklvencvWmhQd0EvQ2ZCYjQwbStvQUYrTSt0UHAyL29q?=
 =?utf-8?B?K29LS09yZ29tOE9hRUdyb0RtYngzTzQ1eVBSQlpzcUkxaW9zakpKNFJCTFpW?=
 =?utf-8?B?SHZTbkxxT245QlNrUFZoaDcyelFBZzVDOGlPb1gyV3lXeGJLYzNsZkx1cVBy?=
 =?utf-8?B?MHRZU1NacVVqajdrc1VxZm1mNDRIUGlTMTZ1S2U0Vm0ycDJOcXlhanl0dTJY?=
 =?utf-8?B?cTk0bWJtNGhyakRKcHBab2pwdk9Fa0Z3c00ySCswRUFuSVhEZFFHYUV5QzB3?=
 =?utf-8?B?OXpXRVg3bFZVTHRPODh1QVRQNVBzM09OMHpMNHpwbEYxUENIV3lPbDRRc3E5?=
 =?utf-8?B?dFJFTEpmRG9zUFJIN2FBc0JObDE2QVVpY2FWc09pald5Wmx6bi96UStKZ0lL?=
 =?utf-8?B?U3RjUUl2Y1o5T2dBTElOT1hPY1JoZEE2Y0txenEyTlJmQWg4emZNVUU5ZDd4?=
 =?utf-8?B?QXg1YUhFSk1BZmlGSUpmRWQ5eHpFMnhyeWdOTFJYY1BLUDdyckhwQnhEbnVj?=
 =?utf-8?B?M0tTeGY2N2o1UG94cmpONGRDSml4UXYzYWFrLzlETzhaZHd1ZlQwcGE1a05I?=
 =?utf-8?B?eWN2TVFPV2QwL1U5M3ZMNW5hVndYR2VjZXRRVkxocm5QamNTUmhvb2pPMXhz?=
 =?utf-8?B?VHB3ZFlhZUt5UGpmejVBRE9sQXMvZEJVWXlVd05iVFlMNDlCeTg2MFc4a0N3?=
 =?utf-8?B?d0dDUEh2aVR2dzBuQWJHZmF1Y1ExYUliY05vT3g2K2pGTUgvVktYN3ovNTF0?=
 =?utf-8?B?Z0NQUUh4eGYxU1J3RWVyZjJQZ2w3a1dPdUpJb2VwUGdVVGdBVktSQjZpTytq?=
 =?utf-8?B?czBLajdFRmIxT3lLTndROWZuQUtjaEV0a1ZwcmxLYWo3VGhhN3A0VFMxZVB2?=
 =?utf-8?B?RjdCUVorQWdzU3dkdGFVMGg1cUNHT0I0VmRlRVZGaFFLVFI5dHFZNUpBdkNK?=
 =?utf-8?B?N2FuVDlmTTVZTVI0SFBhVlZROUJvbHp4UEFsV2JxdWRXMWU2QSt3Y3U3c2Vx?=
 =?utf-8?B?OGh0SlAvR2JQaERkRjcxODBqeTZFR1NYSkJGVm5NQ2tIMUxMZWZQTU9zSW0z?=
 =?utf-8?B?SmFTeEVBdUliNnZ3RnhjVTA3Z2FpZXMwNDM3RWltZFk1SXZYR2FEeFQrWUt6?=
 =?utf-8?B?eXZlVUpXWkJGckhsV01ER2VqVzRKWjZ2VTEvWXBSTE1IcTRjWEZPSjgzRlhn?=
 =?utf-8?B?Z3NtS0k0SHBkdmlFeDBLSHByYkF3OEt2TWRKa3RyK1d2MXYxTkpoSFYwa3Zl?=
 =?utf-8?B?bmZMZy8zK2pIaVNidFhZc21FMzdQMmdVL1Z1UHgvcDBkN2duMlZqV0F1Ymp6?=
 =?utf-8?B?bmhGVjRveUllMDkzbG1RTjdDV1NpdEtQVDQ2QzJaR25wOHhKa3FOV0VaZHZ4?=
 =?utf-8?B?Y0hURmo3cjRjRFovM2pyS0pwSWVzQlc4L2RRZnZoYW55MW55SW81NG9KbzdD?=
 =?utf-8?B?RWJ2M0Rjam9uQ3hWaCtGKzQvZ3FzYmJRd3l3U08wSjlPSVQxV09tOVhjZHJt?=
 =?utf-8?B?SEd0bGJrakQwYmN5TjRqN0ovTmpvY0dyMjYvaDFFbTg1OU1Nemlzb3Q1alUz?=
 =?utf-8?B?OHVhQlBVK1k3Wks1V3Zua0QxOVlyUk9aSWtoTE5mYy9KVU8wVDQ4RHZ5TERz?=
 =?utf-8?B?R2JsTjNTZEhmZmVCdHYwRnA0OGJmUE43d0xwQ2M4d01QQ0RrTVorKzZLYTdE?=
 =?utf-8?Q?v7cREukpHY7bnMUk9zAuWT8tT?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 74ce9ed9-16b3-4a2a-92d4-08da901e065a
X-MS-Exchange-CrossTenant-AuthSource: MN2PR12MB2941.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Sep 2022 15:39:45.8551
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: ZTlLVzSABoh5YzFvpAZLEO59qyN8XjMvvpU1CL7qFzV3JwlF4PUvuj9wmw/7TVYx0XLwdEeus3dR3k0s5ajyKQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY5PR12MB6456
X-Spam-Status: No, score=-3.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,T_SCC_BODY_TEXT_LINE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 2022-09-06 11:06, Greg Kroah-Hartman wrote:
> On Tue, Sep 06, 2022 at 10:52:28AM -0400, Rodrigo Siqueira Jordao wrote:
>>
>>
>> On 2022-09-02 09:10, Greg Kroah-Hartman wrote:
>>> On Fri, Sep 02, 2022 at 03:01:05PM +0200, Greg Kroah-Hartman wrote:
>>>> When calling debugfs_lookup() the result must have dput() called on it,
>>>> otherwise the memory will leak over time.  Fix this up by properly
>>>> calling dput().
>>>>
>>>> Cc: Harry Wentland <harry.wentland@amd.com>
>>>> Cc: Leo Li <sunpeng.li@amd.com>
>>>> Cc: Rodrigo Siqueira <Rodrigo.Siqueira@amd.com>
>>>> Cc: Alex Deucher <alexander.deucher@amd.com>
>>>> Cc: "Christian König" <christian.koenig@amd.com>
>>>> Cc: "Pan, Xinhui" <Xinhui.Pan@amd.com>
>>>> Cc: David Airlie <airlied@linux.ie>
>>>> Cc: Daniel Vetter <daniel@ffwll.ch>
>>>> Cc: Wayne Lin <Wayne.Lin@amd.com>
>>>> Cc: hersen wu <hersenxs.wu@amd.com>
>>>> Cc: Wenjing Liu <wenjing.liu@amd.com>
>>>> Cc: Patrik Jakobsson <patrik.r.jakobsson@gmail.com>
>>>> Cc: Thelford Williams <tdwilliamsiv@gmail.com>
>>>> Cc: Fangzhi Zuo <Jerry.Zuo@amd.com>
>>>> Cc: Yongzhi Liu <lyz_cs@pku.edu.cn>
>>>> Cc: Mikita Lipski <mikita.lipski@amd.com>
>>>> Cc: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
>>>> Cc: Bhanuprakash Modem <bhanuprakash.modem@intel.com>
>>>> Cc: Sean Paul <seanpaul@chromium.org>
>>>> Cc: amd-gfx@lists.freedesktop.org
>>>> Cc: dri-devel@lists.freedesktop.org
>>>> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
>>>> ---
>>>
>>> Despite a zillion cc: items, I forgot to cc: stable on this.  Can the
>>> maintainer add that here, or do you all want me to resend it with that
>>> item added?
>>>
>>> thanks,
>>>
>>> greg k-h
>>
>> Hi Greg,
>>
>> Reviewed-by: Rodrigo Siqueira <Rodrigo.Siqueira@amd.com>
>>
>> Is 'Cc: stable@vger.kernel.org' enough here? I can make this change before I
>> merge it into amd-staging-drm-next.
> 
> Yes, please add the cc: stable@ line to the body of the patch, sorry I
> forgot that.
> 

Change applied to amd-staging-drm-next, with the Cc to the stable branch.

Thanks
Siqueira

> thanks,
> 
> greg k-h