Received: by 2002:a05:6358:bb9e:b0:b9:5105:a5b4 with SMTP id df30csp4596215rwb; Tue, 6 Sep 2022 09:37:23 -0700 (PDT) X-Google-Smtp-Source: AA6agR6Zm7owRObnRgGOKaIX5EcNWwvC5AEeCnRXQxBX03HKLS9zesIwLjpAxLpX2Z00VUpKq8JB X-Received: by 2002:a63:ce17:0:b0:42a:bfb6:f218 with SMTP id y23-20020a63ce17000000b0042abfb6f218mr45707507pgf.484.1662482243649; Tue, 06 Sep 2022 09:37:23 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1662482243; cv=none; d=google.com; s=arc-20160816; b=xtG1U1Hr/V1YtGsjspjKiM82ghApHXYYllux0SgxMeU2QCj2OV1gQnCPwS8BCvlJMu L+aXr4Uk9z4XAJbce7vLRE3VVWtX2007IL2KwzP+o4JaDQFBCKX77i8rhid4PPPMoCt/ jCs05Oo6w6AcKhSx04SLb9vikRdn4hSTBX859SKuiBsRzNlPhen9POvfM5llA406ka/H dwEklX+wI/8IcHkD/e4YY8RBrTSDjLb88z6k2yVVoP8x6SNTEIeatmOdtDYp3Ucn4KVW D46CuDCTRVLLM0jSbpYSneoB1pNrGA94uXKi6+wEyAoKQ0WvlzawvgwMffsDFcp4xkjd XWWQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-transfer-encoding :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=+jPWLc1o97S5C6ccVNk8zlplwxOmC/Z0u3ytiITeTOk=; b=RFwSZYaMaJK6HVflhL1Okxq2M3BsGTC4jYdmydf9dRqbGvlmAMlGcq+L2e/lwJ/orf QZ9+3F1fBGxvPCIP4xnRQl016vsKgBmDk1MfDKP/WxB5rvvQyNvEZY27fUv4rRrqLylH gd6wxaNZGaG5IhKauIJD+53Lg+X3n4RhTCAuv3p2cJYvywTi1ZArdTvjbvW5azXn0mn4 gt4D7k7WQazQg3tTEu7D9tbSXkGbZhH7xhduvAyqBJAoBp9HiZFZugD++ipTZnKbbvgz 1j9R81wVoqW3M9xXNJxYLPeXVIP8rtqmcJiAQRf3jW/PzC6ZoPS3EtJXfxZhVw0ZBabl KDgQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b="O/Kd9Wyv"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id u6-20020a170902e80600b0016ede1297cdsi7398213plg.494.2022.09.06.09.37.11; Tue, 06 Sep 2022 09:37:23 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b="O/Kd9Wyv"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234516AbiIFPvs (ORCPT + 99 others); Tue, 6 Sep 2022 11:51:48 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37588 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234358AbiIFPva (ORCPT ); Tue, 6 Sep 2022 11:51:30 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3E73E2125F for ; Tue, 6 Sep 2022 08:06:49 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id CE6616156C for ; Tue, 6 Sep 2022 15:06:48 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id A55A4C43470; Tue, 6 Sep 2022 15:06:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1662476808; bh=HKn5OtHPRNYi5Ma7JN4h+bzSjA8wE1EFVOf8KPNOmo4=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=O/Kd9WyvCC8md97D3KyKkPBWv2afnrofuMcsjPEdtM3LpqX6IEbhFZUyCBI8pTwRX 4kgrTKTiHuynGEwtGi+I2IsLenPfIcUGhl8EIuVw87tirpyNRbaSIRWpr57UPqGHC8 T5n9espBQz9VWinK4X2AEBfHHg2x1zEiN7eKQwVA= Date: Tue, 6 Sep 2022 17:06:45 +0200 From: Greg Kroah-Hartman To: Rodrigo Siqueira Jordao Cc: Harry Wentland , Leo Li , Alex Deuc her , Christian =?iso-8859-1?Q?K=F6nig?= , Xinhui.Pan@amd.com, linux-kernel@vger.kernel.org, David Airlie , Daniel Vetter , Wayne Lin , hersen wu , Wenjing Liu , Patrik Jakobsson , Thelford Williams , Fangzhi Zuo , Yongzhi Liu , Mikita Lipski , Jiapeng Chong , Bhanuprakash Modem , Sean Paul , amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org Subject: Re: [PATCH] drm/amd/display: fix memory leak when using debugfs_lookup() Message-ID: References: <20220902130105.139138-1-gregkh@linuxfoundation.org> <5f29a2e1-4ecb-9f94-1e57-f7d8d3c7afb2@amd.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <5f29a2e1-4ecb-9f94-1e57-f7d8d3c7afb2@amd.com> X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Sep 06, 2022 at 10:52:28AM -0400, Rodrigo Siqueira Jordao wrote: > > > On 2022-09-02 09:10, Greg Kroah-Hartman wrote: > > On Fri, Sep 02, 2022 at 03:01:05PM +0200, Greg Kroah-Hartman wrote: > > > When calling debugfs_lookup() the result must have dput() called on it, > > > otherwise the memory will leak over time. Fix this up by properly > > > calling dput(). > > > > > > Cc: Harry Wentland > > > Cc: Leo Li > > > Cc: Rodrigo Siqueira > > > Cc: Alex Deucher > > > Cc: "Christian K?nig" > > > Cc: "Pan, Xinhui" > > > Cc: David Airlie > > > Cc: Daniel Vetter > > > Cc: Wayne Lin > > > Cc: hersen wu > > > Cc: Wenjing Liu > > > Cc: Patrik Jakobsson > > > Cc: Thelford Williams > > > Cc: Fangzhi Zuo > > > Cc: Yongzhi Liu > > > Cc: Mikita Lipski > > > Cc: Jiapeng Chong > > > Cc: Bhanuprakash Modem > > > Cc: Sean Paul > > > Cc: amd-gfx@lists.freedesktop.org > > > Cc: dri-devel@lists.freedesktop.org > > > Signed-off-by: Greg Kroah-Hartman > > > --- > > > > Despite a zillion cc: items, I forgot to cc: stable on this. Can the > > maintainer add that here, or do you all want me to resend it with that > > item added? > > > > thanks, > > > > greg k-h > > Hi Greg, > > Reviewed-by: Rodrigo Siqueira > > Is 'Cc: stable@vger.kernel.org' enough here? I can make this change before I > merge it into amd-staging-drm-next. Yes, please add the cc: stable@ line to the body of the patch, sorry I forgot that. thanks, greg k-h