Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Tue, 06 Sep 2022 18:04:27 +0200
Message-ID: <877d2gfq0k.wl-tiwai@suse.de>
From:   Takashi Iwai <tiwai@suse.de>
To:     Jason Gunthorpe <jgg@nvidia.com>
Cc:     Takashi Iwai <tiwai@suse.de>, Lu Baolu <baolu.lu@linux.intel.com>,
        Joerg Roedel <jroedel@suse.de>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Bjorn Helgaas <bhelgaas@google.com>,
        Robin Murphy <robin.murphy@arm.com>,
        Eric Auger <eric.auger@redhat.com>,
        regressions@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [REGRESSION 5.19.x] AMD HD-audio devices missing on 5.19
In-Reply-To: <YxdtCMbrDQCc5N42@nvidia.com>
References: <874jy4cqok.wl-tiwai@suse.de>
        <20220823010021.GA5967@nvidia.com>
        <87h723sdde.wl-tiwai@suse.de>
        <87ilmjqj1f.wl-tiwai@suse.de>
        <20220823202824.GA4516@nvidia.com>
        <YxdqP9i0bEwUg4VJ@nvidia.com>
        <87edwofqkd.wl-tiwai@suse.de>
        <YxdtCMbrDQCc5N42@nvidia.com>
User-Agent: Wanderlust/2.15.9 (Almost Unreal) Emacs/27.2 Mule/6.0
MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue")
Content-Type: text/plain; charset=US-ASCII
Precedence: bulk

On Tue, 06 Sep 2022 17:53:44 +0200,
Jason Gunthorpe wrote:
> 
> On Tue, Sep 06, 2022 at 05:52:34PM +0200, Takashi Iwai wrote:
> > On Tue, 06 Sep 2022 17:41:51 +0200,
> > Jason Gunthorpe wrote:
> > > 
> > > On Tue, Aug 23, 2022 at 05:28:24PM -0300, Jason Gunthorpe wrote:
> > > > On Tue, Aug 23, 2022 at 01:46:36PM +0200, Takashi Iwai wrote:
> > > > > It was tested now and confirmed that the call path is via AMDGPU, as
> > > > > expected:
> > > > >   amdgpu_pci_probe ->
> > > > >   amdgpu_driver_load_kms ->
> > > > >   amdgpu_device_init ->
> > > > >   amdgpu_amdkfd_device_init ->
> > > > >   kgd2kfd_device_init ->
> > > > >   kgd2kfd_resume_iommu ->
> > > > >   kfd_iommu_resume ->
> > > > >   amd_iommu_init_device ->
> > > > >   iommu_attach_group ->
> > > > >   __iommu_attach_group
> > > > 
> > > > Oh, when you said sound intel I thought this was an Intel CPU..
> > > > 
> > > > Yes, there is this hacky private path from the amdgpu to
> > > > the amd iommu driver that makes a mess of it here. We discussed it in
> > > > this thread:
> > > > 
> > > > https://lore.kernel.org/linux-iommu/YgtuJQhY8SNlv9%2F6@8bytes.org/
> > > > 
> > > > But nobody put it together that it would be a problem with this.
> > > > 
> > > > Something like this, perhaps, but I didn't check if overriding the
> > > > type would cause other problems.
> > > 
> > > Takashi, do we want to do this patch?
> > 
> > I really have no much preference regarding the fix for this
> > regression from my side.  If you can work on it, it'd be greatly
> > appreciated.
> 
> If you say this patch works I will formally propose it, but I have no
> ability to test on this special AMD HW.

Erm, it's not clear which patch you're referring to.  The mentioned
URL points to a patch series.

If you can send (or point) a patch for test, I can set up a test
kernel and ask reporters for testing it.


thanks,

Takashi