Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Tue, 6 Sep 2022 09:05:38 -0700
From:   Arun Easi <aeasi@marvell.com>
To:     "Sudip Mukherjee (Codethink)" <sudipm.mukherjee@gmail.com>
CC:     Steven Rostedt <rostedt@goodmis.org>,
        Nilesh Javali <njavali@marvell.com>,
        "Martin K. Petersen" <martin.petersen@oracle.com>,
        <GR-QLogic-Storage-Upstream@marvell.com>,
        "James E.J. Bottomley" <jejb@linux.ibm.com>,
        <linux-scsi@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
        <linux-next@vger.kernel.org>
Subject: Re: [EXT] build failure of next-20220906 due to 8bfc149ba24c ("scsi:
 qla2xxx: Enhance driver tracing with separate tunable and more")
In-Reply-To: <YxdZ/9XOsWilvVSd@debian>
Message-ID: <44fe9ca0-e1d7-1e4f-9fd8-0f48a84dca72@marvell.com>
References: <YxdZ/9XOsWilvVSd@debian>
MIME-Version: 1.0
Content-Type: multipart/mixed;
        boundary="1879738122-875352785-1662480340=:17437"
Precedence: bulk

--1879738122-875352785-1662480340=:17437
Content-Type: text/plain; charset="US-ASCII"

Hi Sudip,

On Tue, 6 Sep 2022, 7:32am, Sudip Mukherjee (Codethink) wrote:

> External Email
> 
> ----------------------------------------------------------------------
> Hi All,
> 
> The builds of loongarch loongson3_defconfig have failed to build
> next-20220906 with the error:
> 
> drivers/scsi/qla2xxx/qla_os.c: In function 'qla_trace_init':
> drivers/scsi/qla2xxx/qla_os.c:2854:25: error: implicit declaration of function 'trace_array_get_by_name'; did you mean 'trace_array_set_clr_event'? [-Werror=implicit-function-declaration]
>  2854 |         qla_trc_array = trace_array_get_by_name("qla2xxx");
>       |                         ^~~~~~~~~~~~~~~~~~~~~~~
>       |                         trace_array_set_clr_event
> 
> drivers/scsi/qla2xxx/qla_os.c: In function 'qla_trace_uninit':
> drivers/scsi/qla2xxx/qla_os.c:2869:9: error: implicit declaration of function 'trace_array_put' [-Werror=implicit-function-declaration]
>  2869 |         trace_array_put(qla_trc_array);
>       |         ^~~~~~~~~~~~~~~
> 
> 
> git bisect pointed to 8bfc149ba24c ("scsi: qla2xxx: Enhance driver tracing with separate tunable and more").
> 
> I will be happy to test any patch or provide any extra log if needed.
> 
> 

This looks like is happening due to CONFIG_TRACING not being enabled (same 
as what kernel test bot reported). Could you try out the fix attached?

@Steven, please see the patch attached. Do you think the fix belongs 
better in linux/trace.h ?

Regards,
-Arun
--1879738122-875352785-1662480340=:17437
Content-Type: text/plain; charset="US-ASCII";
	name="0001-fixup-qla2xxx-Enhance-driver-tracing-with-separate-t.patch"
Content-Transfer-Encoding: BASE64
Content-ID: <ca92e75f-12ed-0867-418f-7fdbb4702c48@marvell.com>
Content-Description: 
Content-Disposition: attachment;
	filename="0001-fixup-qla2xxx-Enhance-driver-tracing-with-separate-t.patch"

RnJvbSBhZTQ2MDM3MTJjOWYzYTQ5ZDY3MDE1ZjYzODZjNTIwYTc3MzE5ZmZh
IE1vbiBTZXAgMTcgMDA6MDA6MDAgMjAwMQ0KRnJvbTogQXJ1biBFYXNpIDxh
ZWFzaUBtYXJ2ZWxsLmNvbT4NCkRhdGU6IEZyaSwgMiBTZXAgMjAyMiAxNzo1
MzozMCAtMDcwMA0KU3ViamVjdDogW1BBVENIXSBmaXh1cCEgcWxhMnh4eDog
RW5oYW5jZSBkcml2ZXIgdHJhY2luZyB3aXRoIHNlcGFyYXRlIHR1bmFibGUN
CiBhbmQgbW9yZQ0KDQpGaXggdGhpcyBjb21waWxhdGlvbiBlcnJvciBzZWVu
IHdoZW4gQ09ORklHX1RSQUNJTkcgaXMgbm90IGVuYWJsZWQ6DQoNCmRyaXZl
cnMvc2NzaS9xbGEyeHh4L3FsYV9vcy5jOiBJbiBmdW5jdGlvbiAncWxhX3Ry
YWNlX2luaXQnOg0KZHJpdmVycy9zY3NpL3FsYTJ4eHgvcWxhX29zLmM6Mjg1
NDoyNTogZXJyb3I6IGltcGxpY2l0IGRlY2xhcmF0aW9uIG9mIGZ1bmN0aW9u
DQondHJhY2VfYXJyYXlfZ2V0X2J5X25hbWUnOyBkaWQgeW91IG1lYW4gJ3Ry
YWNlX2FycmF5X3NldF9jbHJfZXZlbnQnPw0KWy1XZXJyb3I9aW1wbGljaXQt
ZnVuY3Rpb24tZGVjbGFyYXRpb25dDQogMjg1NCB8ICAgICAgICAgcWxhX3Ry
Y19hcnJheSA9IHRyYWNlX2FycmF5X2dldF9ieV9uYW1lKCJxbGEyeHh4Iik7
DQogICAgICB8ICAgICAgICAgICAgICAgICAgICAgICAgIF5+fn5+fn5+fn5+
fn5+fn5+fn5+fn5+DQogICAgICB8ICAgICAgICAgICAgICAgICAgICAgICAg
IHRyYWNlX2FycmF5X3NldF9jbHJfZXZlbnQNCg0KZHJpdmVycy9zY3NpL3Fs
YTJ4eHgvcWxhX29zLmM6IEluIGZ1bmN0aW9uICdxbGFfdHJhY2VfdW5pbml0
JzoNCmRyaXZlcnMvc2NzaS9xbGEyeHh4L3FsYV9vcy5jOjI4Njk6OTogZXJy
b3I6IGltcGxpY2l0IGRlY2xhcmF0aW9uIG9mIGZ1bmN0aW9uDQondHJhY2Vf
YXJyYXlfcHV0JyBbLVdlcnJvcj1pbXBsaWNpdC1mdW5jdGlvbi1kZWNsYXJh
dGlvbl0NCiAyODY5IHwgICAgICAgICB0cmFjZV9hcnJheV9wdXQocWxhX3Ry
Y19hcnJheSk7DQogICAgICB8ICAgICAgICAgXn5+fn5+fn5+fn5+fn5+DQoN
ClJlcG9ydGVkLWJ5OiBrZXJuZWwgdGVzdCByb2JvdCA8bGtwQGludGVsLmNv
bT4NCi0tLQ0KIGRyaXZlcnMvc2NzaS9xbGEyeHh4L3FsYV9kZWYuaCB8IDcg
KysrKysrKw0KIDEgZmlsZSBjaGFuZ2VkLCA3IGluc2VydGlvbnMoKykNCg0K
ZGlmZiAtLWdpdCBhL2RyaXZlcnMvc2NzaS9xbGEyeHh4L3FsYV9kZWYuaCBi
L2RyaXZlcnMvc2NzaS9xbGEyeHh4L3FsYV9kZWYuaA0KaW5kZXggM2VjNmEy
MDA5NDJlLi5kMGRhNzM3ZTUxZTIgMTAwNjQ0DQotLS0gYS9kcml2ZXJzL3Nj
c2kvcWxhMnh4eC9xbGFfZGVmLmgNCisrKyBiL2RyaXZlcnMvc2NzaS9xbGEy
eHh4L3FsYV9kZWYuaA0KQEAgLTM1LDYgKzM1LDEzIEBADQogDQogI2luY2x1
ZGUgPHVhcGkvc2NzaS9mYy9mY19lbHMuaD4NCiANCisjaWZuZGVmIENPTkZJ
R19UUkFDSU5HDQorI2lmbmRlZiB0cmFjZV9hcnJheV9nZXRfYnlfbmFtZQ0K
KyNkZWZpbmUgdHJhY2VfYXJyYXlfZ2V0X2J5X25hbWUoX3RyY19hcnIpCU5V
TEwNCisjZGVmaW5lIHRyYWNlX2FycmF5X3B1dChfdHJjX2FycikNCisjZW5k
aWYgLyogdHJhY2VfYXJyYXlfZ2V0X2J5X25hbWUgKi8NCisjZW5kaWYgLyog
Q09ORklHX1RSQUNJTkcgKi8NCisNCiAvKiBCaWcgZW5kaWFuIEZpYnJlIENo
YW5uZWwgU19JRCAoc291cmNlIElEKSBvciBEX0lEIChkZXN0aW5hdGlvbiBJ
RCkuICovDQogdHlwZWRlZiBzdHJ1Y3Qgew0KIAl1aW50OF90IGRvbWFpbjsN
Ci0tIA0KMi4yNy4wDQoNCg==

--1879738122-875352785-1662480340=:17437--